[PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Martin Jansa]

* original webkit-gtk_1.8.3.bb recipe already had this, I don't know
  why it was removed when upgrading to 2.8.5

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.8.5.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
index 82d670d..859d0cb 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
@@ -18,7 +18,10 @@ SRC_URI = "\
 SRC_URI[md5sum] = "df79991848a5096d3a75289ebce547ae"
 SRC_URI[sha256sum] = "3d1f0c534935f43fd74df90f2648fcee672d60f1f57a30fa557a77891ae04d20"
 
-inherit cmake lib_package pkgconfig perlnative pythonnative
+inherit cmake lib_package pkgconfig perlnative pythonnative distro_features_check
+
+# depends on libxt
+REQUIRED_DISTRO_FEATURES = "x11"
 
 DEPENDS = "zlib enchant libsoup-2.4 curl libxml2 cairo libxslt libxt libidn gnutls \
            gtk+ gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
-- 
2.5.1

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Alexander Kanavin]

On 09/21/2015 05:01 PM, Martin Jansa wrote:
> * original webkit-gtk_1.8.3.bb recipe already had this, I don't know
>    why it was removed when upgrading to 2.8.5

It was removed because I couldn't figure out why it's actually needed. 
What is the scenario?

Regards,
Alex

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

On 21 September 2015 at 17:01, Alexander Kanavin <
alexander.kanavin@linux.intel.com> wrote:

> On 09/21/2015 05:01 PM, Martin Jansa wrote:
>
>> * original webkit-gtk_1.8.3.bb recipe already had this, I don't know
>>    why it was removed when upgrading to 2.8.5
>>
>
> It was removed because I couldn't figure out why it's actually needed.
> What is the scenario?
>

Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need
or use X") and build webkitgtk.  webkitgtk depends on libxt which depends
on libx11 which then refuses to build because you explicitly said you
didn't want X.

We're adding required_distro_feature annotations as required so that world
builds without X11 enabled still work by skipping the recipes instead of
failing to build.

Ross

[-- Attachment #2: Type: text/html, Size: 1469 bytes --]

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[alexander.kanavin]

> Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need
> or use X") and build webkitgtk.  webkitgtk depends on libxt which depends
> on libx11 which then refuses to build because you explicitly said you
> didn't want X.
>
> We're adding required_distro_feature annotations as required so that world
> builds without X11 enabled still work by skipping the recipes instead of
> failing to build.


But this means you need to add this to every recipe that directly or
indirectly depends on libx11. Which is crazy awkward and error-prone.

Why can't the tools figure out which recipes should be excluded from
builds without explicit annotations?


Alex

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

On Tue, Sep 22, 2015 at 02:12:36PM +0300, alexander.kanavin@linux.intel.com wrote:
> > Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need
> > or use X") and build webkitgtk.  webkitgtk depends on libxt which depends
> > on libx11 which then refuses to build because you explicitly said you
> > didn't want X.
> >
> > We're adding required_distro_feature annotations as required so that world
> > builds without X11 enabled still work by skipping the recipes instead of
> > failing to build.
> 
> 
> But this means you need to add this to every recipe that directly or
> indirectly depends on libx11. Which is crazy awkward and error-prone.

And was already done:
http://git.openembedded.org/openembedded-core/commit/?id=78d269fa9a586e24ef058ba5315c696f15935f56
http://git.openembedded.org/openembedded-core/commit/?id=bc4d051c2fa56acb0479330b4342a39396de30d4
http://git.openembedded.org/openembedded-core/commit/?id=8764282a06fa5f7571c479a5b3b35c7baaad241f
http://git.openembedded.org/openembedded-core/commit/?id=fda535d5b5239b091c79e957f68a45d4eab0ab5d
http://git.openembedded.org/openembedded-core/commit/?id=1cf0245344ce272e7330cfe1b04a0ed7bd18e8f5
http://git.openembedded.org/openembedded-core/commit/?id=fa1d9b518708103b0b2e259aa78f8dd694cfc0d6

and it's not so error-prone, just call "bitbake world" in DISTRO without
x11 in DISTRO_FEATURES and fix all the ERROR: messages at the beginning.

> Why can't the tools figure out which recipes should be excluded from
> builds without explicit annotations?

See discussion around this change on ML and please don't remove stuff
just because you don't know/remember why it was added without at least
using "git blame" to read commit which introduced it.

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[alexander.kanavin]

>> Why can't the tools figure out which recipes should be excluded from
>> builds without explicit annotations?
>
> See discussion around this change on ML and please don't remove stuff
> just because you don't know/remember why it was added without at least
> using "git blame" to read commit which introduced it.

Fair enough. What about adding new recipes? How is one supposed to figure
out whether there are required distro features to list?


Alex

Re: [PATCH] webkitgtk: add REQUIRED_DISTRO_FEATURES

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

On Mon, Sep 21, 2015 at 07:01:15PM +0300, Alexander Kanavin wrote:
> On 09/21/2015 05:01 PM, Martin Jansa wrote:
> > * original webkit-gtk_1.8.3.bb recipe already had this, I don't know
> >    why it was removed when upgrading to 2.8.5
> 
> It was removed because I couldn't figure out why it's actually needed. 
> What is the scenario?

DISTROs without x11 shouldn't try to build webkitgtk, because it will
fail with ugly error message about libxt not being available.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]