[jethro] [PATCH 0/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[jethro] [PATCH 0/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[Robert Yang]

The following changes since commit 901af5a00338fd8f1ace939123484ea91c090a7a:

  libaio: don't disable linking to the system libraries (2016-01-14 15:18:16 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/jethro-next
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/jethro-next

Robert Yang (1):
  gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

 .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.9.5

[PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[Robert Yang]

The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from
PACKAGECONFIG, now add it back.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
index edaafe8..2f987b4 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
@@ -11,7 +11,7 @@ inherit gettext
 PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
-    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib v4l2\
+    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
     "
 
 X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
-- 
1.7.9.5

Re: [PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

On Fri, Jan 15, 2016 at 01:07:20AM -0800, Robert Yang wrote:
> The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from
> PACKAGECONFIG, now add it back.

It was removed intentionally, because for systemd images there isn't
libgudev provider in oe-core, only in meta-oe.

RP's fix:
http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc458ae9586b45b11b6908eadb31e94d892e698f

breaks the dependencies again, because when systemd is used there won't
be libgudev needed by gstreamer1.0-plugins-good

Please revert both "fixes"

Regards,

> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> index edaafe8..2f987b4 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> @@ -11,7 +11,7 @@ inherit gettext
>  PACKAGECONFIG ??= " \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
> -    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib v4l2\
> +    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
>      "
>  
>  X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[Richard Purdie]

On Mon, 2016-01-18 at 17:53 +0100, Martin Jansa wrote:
> On Fri, Jan 15, 2016 at 01:07:20AM -0800, Robert Yang wrote:
> > The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev
> > from
> > PACKAGECONFIG, now add it back.
> 
> It was removed intentionally, because for systemd images there isn't
> libgudev provider in oe-core, only in meta-oe.
> 
> RP's fix:
> http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc4
> 58ae9586b45b11b6908eadb31e94d892e698f
> 
> breaks the dependencies again, because when systemd is used there
> won't
> be libgudev needed by gstreamer1.0-plugins-good
> 
> Please revert both "fixes"

The "backported" patch should have made mention of the changes compared
to the version in master since otherwise, "intentionally" looked like a
mistake :/.

What is the impact to gstreamer of removing libgudev?

Cheers,

Richard

Re: [PATCH 1/1] gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

[Robert Yang]

On 01/19/2016 01:52 AM, Richard Purdie wrote:
> On Mon, 2016-01-18 at 17:53 +0100, Martin Jansa wrote:
>> On Fri, Jan 15, 2016 at 01:07:20AM -0800, Robert Yang wrote:
>>> The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev
>>> from
>>> PACKAGECONFIG, now add it back.
>>
>> It was removed intentionally, because for systemd images there isn't
>> libgudev provider in oe-core, only in meta-oe.
>>
>> RP's fix:
>> http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc4
>> 58ae9586b45b11b6908eadb31e94d892e698f
>>
>> breaks the dependencies again, because when systemd is used there
>> won't
>> be libgudev needed by gstreamer1.0-plugins-good
>>
>> Please revert both "fixes"

Sorry, I wrongly thought it was a mistake, but was intention.

// Robert

>
> The "backported" patch should have made mention of the changes compared
> to the version in master since otherwise, "intentionally" looked like a
> mistake :/.
>
> What is the impact to gstreamer of removing libgudev?
>
> Cheers,
>
> Richard
>