* [PATCH] file: specify c std as c99 or greater required
@ 2016-09-06 13:25 Jack Mitchell
2016-09-06 18:36 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Jack Mitchell @ 2016-09-06 13:25 UTC (permalink / raw)
To: openembedded-core; +Cc: Jack Mitchell
From: Jack Mitchell <jack@embed.me.uk>
when using a toolchain not shipped by OE core such as linaro we
can't be sure what the std will be set to. Ensure file is compiled
as c99 or greater as required.
Signed-off-by: Jack Mitchell <jack@embed.me.uk>
---
meta/recipes-devtools/file/file_5.28.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/file/file_5.28.bb b/meta/recipes-devtools/file/file_5.28.bb
index 516c8c5..94848db 100644
--- a/meta/recipes-devtools/file/file_5.28.bb
+++ b/meta/recipes-devtools/file/file_5.28.bb
@@ -27,6 +27,8 @@ inherit autotools
EXTRA_OEMAKE_append_class-target = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
EXTRA_OEMAKE_append_class-nativesdk = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
+CFLAGS_append = " -std=gnu11"
+
FILES_${PN} += "${datadir}/misc/*.mgc"
do_install_append_class-native() {
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] file: specify c std as c99 or greater required
2016-09-06 13:25 [PATCH] file: specify c std as c99 or greater required Jack Mitchell
@ 2016-09-06 18:36 ` Khem Raj
2016-09-06 18:49 ` Jack Mitchell
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2016-09-06 18:36 UTC (permalink / raw)
To: Jack Mitchell; +Cc: Jack Mitchell, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
> On Sep 6, 2016, at 6:25 AM, Jack Mitchell <ml@embed.me.uk> wrote:
>
> From: Jack Mitchell <jack@embed.me.uk>
>
> when using a toolchain not shipped by OE core such as linaro we
> can't be sure what the std will be set to. Ensure file is compiled
> as c99 or greater as required.
comment does not match the code, its using gnu11, secondly is gnu11 needed or can it live with
c11
>
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ---
> meta/recipes-devtools/file/file_5.28.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/file/file_5.28.bb b/meta/recipes-devtools/file/file_5.28.bb
> index 516c8c5..94848db 100644
> --- a/meta/recipes-devtools/file/file_5.28.bb
> +++ b/meta/recipes-devtools/file/file_5.28.bb
> @@ -27,6 +27,8 @@ inherit autotools
> EXTRA_OEMAKE_append_class-target = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
> EXTRA_OEMAKE_append_class-nativesdk = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
>
> +CFLAGS_append = " -std=gnu11"
> +
> FILES_${PN} += "${datadir}/misc/*.mgc"
>
> do_install_append_class-native() {
> --
> 2.9.3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] file: specify c std as c99 or greater required
2016-09-06 18:36 ` Khem Raj
@ 2016-09-06 18:49 ` Jack Mitchell
0 siblings, 0 replies; 3+ messages in thread
From: Jack Mitchell @ 2016-09-06 18:49 UTC (permalink / raw)
To: Khem Raj; +Cc: Jack Mitchell, openembedded-core
On 06/09/16 19:36, Khem Raj wrote:
>> On Sep 6, 2016, at 6:25 AM, Jack Mitchell <ml@embed.me.uk> wrote:
>>
>> From: Jack Mitchell <jack@embed.me.uk>
>>
>> when using a toolchain not shipped by OE core such as linaro we
>> can't be sure what the std will be set to. Ensure file is compiled
>> as c99 or greater as required.
> comment does not match the code, its using gnu11, secondly is gnu11 needed or can it live with
> c11
Comment says it needs 'c99 or greater' so I set it to gnu11 which is the
default we use for gcc6, no? The minimum it can compile with is c99,
would that be a better option to set?
Cheers,
>
>> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
>> ---
>> meta/recipes-devtools/file/file_5.28.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/file/file_5.28.bb b/meta/recipes-devtools/file/file_5.28.bb
>> index 516c8c5..94848db 100644
>> --- a/meta/recipes-devtools/file/file_5.28.bb
>> +++ b/meta/recipes-devtools/file/file_5.28.bb
>> @@ -27,6 +27,8 @@ inherit autotools
>> EXTRA_OEMAKE_append_class-target = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
>> EXTRA_OEMAKE_append_class-nativesdk = "-e FILE_COMPILE=${STAGING_BINDIR_NATIVE}/file-native/file"
>>
>> +CFLAGS_append = " -std=gnu11"
>> +
>> FILES_${PN} += "${datadir}/misc/*.mgc"
>>
>> do_install_append_class-native() {
>> --
>> 2.9.3
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-06 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-06 13:25 [PATCH] file: specify c std as c99 or greater required Jack Mitchell
2016-09-06 18:36 ` Khem Raj
2016-09-06 18:49 ` Jack Mitchell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox