[PATCH] e2fsprogs: configure with enable-symlink

[PATCH] e2fsprogs: configure with enable-symlink

[Patrick Williams]

The /sbin/fsck.ext[234] programs currently installed are all
the same binary as e2fsck.  The package provides an option to
have fsck.ext[234] be symlinked to /sbin/e2fsck instead.  This
reduces the uncompressed footprint of this package by ~1MB on ARM.

Add --enable-symlink-install to EXTRA_OECONF to enable.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
index f4855bc..d6db612 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
@@ -18,7 +18,8 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+\.\d+(\.\d+)*)$"
 
 EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
                 --enable-elf-shlibs --disable-libuuid --disable-uuidd \
-                --disable-libblkid --enable-verbose-makecmds"
+                --disable-libblkid --enable-verbose-makecmds \
+                --enable-symlink-install"
 
 EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs"
 
-- 
2.9.0

Re: [PATCH] e2fsprogs: configure with enable-symlink

[André Draszik]

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On 14 Sep 2016 5:40 p.m., "Patrick Williams" <patrick@stwcx.xyz> wrote:
>
> The /sbin/fsck.ext[234] programs currently installed are all
> the same binary as e2fsck.  The package provides an option to
> have fsck.ext[234] be symlinked to /sbin/e2fsck instead.  This
> reduces the uncompressed footprint of this package by ~1MB on ARM.

They were all hardlinks last time I checked not long ago. Why do hardlinks
increase the footprint?

A.

>
> Add --enable-symlink-install to EXTRA_OECONF to enable.
>
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> ---
>  meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> index f4855bc..d6db612 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> @@ -18,7 +18,8 @@ UPSTREAM_CHECK_GITTAGREGEX =
"v(?P<pver>\d+\.\d+(\.\d+)*)$"
>
>  EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
>                  --enable-elf-shlibs --disable-libuuid --disable-uuidd \
> -                --disable-libblkid --enable-verbose-makecmds"
> +                --disable-libblkid --enable-verbose-makecmds \
> +                --enable-symlink-install"
>
>  EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir}
--enable-bsd-shlibs"
>
> --
> 2.9.0
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 2533 bytes --]

Re: [PATCH] e2fsprogs: configure with enable-symlink

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

It was also proposed and discussed some 15 months ago and it was packaging
issue not handling hardlinks correctly:
http://lists.openembedded.org/pipermail/openembedded-core/2015-April/103939.html

I believe this was fixed then, but maybe it got broken again?

On Wed, Sep 14, 2016 at 9:50 PM, André Draszik <git@andred.net> wrote:

> On 14 Sep 2016 5:40 p.m., "Patrick Williams" <patrick@stwcx.xyz> wrote:
> >
> > The /sbin/fsck.ext[234] programs currently installed are all
> > the same binary as e2fsck.  The package provides an option to
> > have fsck.ext[234] be symlinked to /sbin/e2fsck instead.  This
> > reduces the uncompressed footprint of this package by ~1MB on ARM.
>
> They were all hardlinks last time I checked not long ago. Why do hardlinks
> increase the footprint?
>
> A.
>
> >
> > Add --enable-symlink-install to EXTRA_OECONF to enable.
> >
> > Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> > ---
> >  meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> > index f4855bc..d6db612 100644
> > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
> > @@ -18,7 +18,8 @@ UPSTREAM_CHECK_GITTAGREGEX =
> "v(?P<pver>\d+\.\d+(\.\d+)*)$"
> >
> >  EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
> >                  --enable-elf-shlibs --disable-libuuid --disable-uuidd \
> > -                --disable-libblkid --enable-verbose-makecmds"
> > +                --disable-libblkid --enable-verbose-makecmds \
> > +                --enable-symlink-install"
> >
> >  EXTRA_OECONF_darwin = "--libdir=${base_libdir}
> --sbindir=${base_sbindir} --enable-bsd-shlibs"
> >
> > --
> > 2.9.0
> >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 4019 bytes --]

Re: [PATCH] e2fsprogs: configure with enable-symlink

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On Wed, Sep 14, 2016 at 11:23:47PM +0200, Martin Jansa wrote:
> It was also proposed and discussed some 15 months ago and it was packaging
> issue not handling hardlinks correctly:
> http://lists.openembedded.org/pipermail/openembedded-core/2015-April/103939.html
> 
> I believe this was fixed then, but maybe it got broken again?

Sorry, this is my fault.  I didn't think about hard-links.  I was just
skimming the cpio extract for parts that could be trimmed out and
noticed it.

    $ ls -i *fsck*
    19455718 e2fsck
    19455671 fsck
    19455718 fsck.ext2
    19455718 fsck.ext3
    19455718 fsck.ext4
    19455718 fsck.ext4dev
    19455679 fsck.minix
    19455695 fsck.minix.util-linux
    19455675 fsck.util-linux

Is there a reason to prefer hardlinks over softlinks, for my own
education?  My desktop system used softlinks for fsck.

-- 
Patrick Williams

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] e2fsprogs: configure with enable-symlink

[André Draszik]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

On 15 Sep 2016 03:21, "Patrick Williams" <patrick@stwcx.xyz> wrote:
>
> On Wed, Sep 14, 2016 at 11:23:47PM +0200, Martin Jansa wrote:
> > It was also proposed and discussed some 15 months ago and it was
packaging
> > issue not handling hardlinks correctly:
> >
http://lists.openembedded.org/pipermail/openembedded-core/2015-April/103939.html
> >
> > I believe this was fixed then, but maybe it got broken again?
>
> Sorry, this is my fault.  I didn't think about hard-links.  I was just
> skimming the cpio extract for parts that could be trimmed out and
> noticed it.
>
>     $ ls -i *fsck*
>     19455718 e2fsck
>     19455671 fsck
>     19455718 fsck.ext2
>     19455718 fsck.ext3
>     19455718 fsck.ext4
>     19455718 fsck.ext4dev
>     19455679 fsck.minix
>     19455695 fsck.minix.util-linux
>     19455675 fsck.util-linux
>
> Is there a reason to prefer hardlinks over softlinks, for my own
> education?  My desktop system used softlinks for fsck.

Mine too. I don't really care, soft links are surely more obvious, though.

A.

[-- Attachment #2: Type: text/html, Size: 1489 bytes --]