* [PATCH 1/6] wic: use 2 sysroots to find native executable
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-21 15:23 ` [PATCH 2/6] wic: use image recipe sysroot as default Ed Bartosh
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
Currently there is no way to specify a dependency on native
tools for wic without modifying wic-tools recipe. Obvious
way to make it more flexible is to use image sysroot and
wic-tools together to find an executable.
Modified run_native_cmd to use image and wic-tools sysroots
to find native executable.
[YOCTO #11017]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/lib/wic/utils/misc.py | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
index 4b822f0..3bab2f1 100644
--- a/scripts/lib/wic/utils/misc.py
+++ b/scripts/lib/wic/utils/misc.py
@@ -105,9 +105,13 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
if pseudo:
cmd_and_args = pseudo + cmd_and_args
+
+ wtools_sysroot = get_bitbake_var("RECIPE_SYSROOT_NATIVE", "wic-tools")
+
native_paths = \
- "%s/sbin:%s/usr/sbin:%s/usr/bin" % \
- (native_sysroot, native_sysroot, native_sysroot)
+ "%s/sbin:%s/usr/sbin:%s/usr/bin:%s/sbin:%s/usr/sbin:%s/usr/bin" % \
+ (wtools_sysroot, wtools_sysroot, wtools_sysroot,
+ native_sysroot, native_sysroot, native_sysroot)
native_cmd_and_args = "export PATH=%s:$PATH;%s" % \
(native_paths, cmd_and_args)
logger.debug("exec_native_cmd: %s", cmd_and_args)
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/6] wic: use image recipe sysroot as default
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
2017-02-21 15:23 ` [PATCH 1/6] wic: use 2 sysroots to find native executable Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-21 15:23 ` [PATCH 3/6] wic: exec_native_cmd: improve debug message Ed Bartosh
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
Switched from using wic-tools recipe sysroot to using
image sysroot in wic script. This way is more logical
and consistent with the way wic uses other artifacts.
[YOCTO #11017]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/wic | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/wic b/scripts/wic
index f32cb19..99721dc 100755
--- a/scripts/wic
+++ b/scripts/wic
@@ -190,7 +190,7 @@ def wic_create_subcommand(args, usage_str):
rootfs_dir = get_bitbake_var("IMAGE_ROOTFS", options.image_name)
kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE", options.image_name)
native_sysroot = get_bitbake_var("RECIPE_SYSROOT_NATIVE",
- "wic-tools", cache=False)
+ options.image_name) #, cache=False)
else:
if options.build_rootfs:
raise WicError("Image name is not specified, exiting. "
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/6] wic: exec_native_cmd: improve debug message
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
2017-02-21 15:23 ` [PATCH 1/6] wic: use 2 sysroots to find native executable Ed Bartosh
2017-02-21 15:23 ` [PATCH 2/6] wic: use image recipe sysroot as default Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-21 15:23 ` [PATCH 4/6] wic: exec_native_cmd: fix undefined variable error Ed Bartosh
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
Added search paths to the debug message to make it
easier to see where the native command is searched.
[YOCTO #11017]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/lib/wic/utils/misc.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
index 3bab2f1..6769e39 100644
--- a/scripts/lib/wic/utils/misc.py
+++ b/scripts/lib/wic/utils/misc.py
@@ -114,7 +114,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
native_sysroot, native_sysroot, native_sysroot)
native_cmd_and_args = "export PATH=%s:$PATH;%s" % \
(native_paths, cmd_and_args)
- logger.debug("exec_native_cmd: %s", cmd_and_args)
+ logger.debug("exec_native_cmd: %s", native_cmd_and_args)
# If the command isn't in the native sysroot say we failed.
if spawn.find_executable(args[0], native_paths):
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/6] wic: exec_native_cmd: fix undefined variable error
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
` (2 preceding siblings ...)
2017-02-21 15:23 ` [PATCH 3/6] wic: exec_native_cmd: improve debug message Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-21 15:23 ` [PATCH 5/6] wic: add WKS_FILE_DEPENDS variable Ed Bartosh
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
Defined variable 'out' to fix this exception:
UnboundLocalError: local variable 'out' referenced before assignment
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/lib/wic/utils/misc.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
index 6769e39..216ab7b 100644
--- a/scripts/lib/wic/utils/misc.py
+++ b/scripts/lib/wic/utils/misc.py
@@ -121,6 +121,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
ret, out = _exec_cmd(native_cmd_and_args, True, catch)
else:
ret = 127
+ out = "can't find native executable %s in %s" % (args[0], native_paths)
prog = args[0]
# shell command-not-found
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/6] wic: add WKS_FILE_DEPENDS variable
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
` (3 preceding siblings ...)
2017-02-21 15:23 ` [PATCH 4/6] wic: exec_native_cmd: fix undefined variable error Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-21 15:23 ` [PATCH 6/6] wic: raise WicError instead of calling logger.error Ed Bartosh
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
This variable should be used to specify dependencies that
will be added to DEPENDS only if wic image build is 'active'
i.e. when 'wic' is in IMAGE_FSTYPES.
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
meta/classes/image_types_wic.bbclass | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta-selftest/recipes-test/images/wic-image-minimal.bb b/meta-selftest/recipes-test/images/wic-image-minimal.bb
index 9e93b8e..b687935 100644
--- a/meta-selftest/recipes-test/images/wic-image-minimal.bb
+++ b/meta-selftest/recipes-test/images/wic-image-minimal.bb
@@ -6,7 +6,7 @@ IMAGE_INSTALL = "packagegroup-core-boot ${ROOTFS_PKGMANAGE_BOOTSTRAP}"
IMAGE_FSTYPES = "wic"
-DEPENDS = "syslinux syslinux-native dosfstools-native mtools-native gptfdisk-native"
+WKS_FILE_DEPENDS = "syslinux syslinux-native dosfstools-native mtools-native gptfdisk-native"
LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
diff --git a/meta/classes/image_types_wic.bbclass b/meta/classes/image_types_wic.bbclass
index ec6c14d..43b2917 100644
--- a/meta/classes/image_types_wic.bbclass
+++ b/meta/classes/image_types_wic.bbclass
@@ -40,6 +40,8 @@ USING_WIC = "${@bb.utils.contains_any('IMAGE_FSTYPES', 'wic ' + ' '.join('wic.%s
WKS_FILE_CHECKSUM = "${@'${WKS_FULL_PATH}:%s' % os.path.exists('${WKS_FULL_PATH}') if '${USING_WIC}' else ''}"
do_image_wic[file-checksums] += "${WKS_FILE_CHECKSUM}"
do_image_wic[depends] += "wic-tools:do_build"
+WKS_FILE_DEPENDS ??= ''
+DEPENDS += "${@ '${WKS_FILE_DEPENDS}' if d.getVar('USING_WIC') else '' }"
python do_write_wks_template () {
"""Write out expanded template contents to WKS_FULL_PATH."""
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/6] wic: raise WicError instead of calling logger.error
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
` (4 preceding siblings ...)
2017-02-21 15:23 ` [PATCH 5/6] wic: add WKS_FILE_DEPENDS variable Ed Bartosh
@ 2017-02-21 15:23 ` Ed Bartosh
2017-02-22 16:38 ` [PATCH 0/6] wic: fix for #11017 Burton, Ross
2017-02-23 14:08 ` Patrick Ohly
7 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-21 15:23 UTC (permalink / raw)
To: openembedded-core
Replaced forgotten calls of logger.error with raising
WicError exception. Otherwise errors will be ignored.
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/lib/wic/plugins/source/bootimg-pcbios.py | 4 ++--
scripts/lib/wic/utils/misc.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
index 74c75a0..bbc9f47 100644
--- a/scripts/lib/wic/plugins/source/bootimg-pcbios.py
+++ b/scripts/lib/wic/plugins/source/bootimg-pcbios.py
@@ -96,8 +96,8 @@ class BootimgPcbiosPlugin(SourcePlugin):
logger.debug("Using custom configuration file %s "
"for syslinux.cfg", bootloader.configfile)
else:
- logger.error("configfile is specified but failed to "
- "get it from %s.", bootloader.configfile)
+ raise WicError("configfile is specified but failed to "
+ "get it from %s." % bootloader.configfile)
if not custom_cfg:
# Create syslinux configuration using parameters from wks file
diff --git a/scripts/lib/wic/utils/misc.py b/scripts/lib/wic/utils/misc.py
index 216ab7b..c941112 100644
--- a/scripts/lib/wic/utils/misc.py
+++ b/scripts/lib/wic/utils/misc.py
@@ -136,7 +136,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
else:
msg += "Wic failed to find a recipe to build native %s. Please "\
"file a bug against wic.\n" % prog
- logger.error(msg)
+ raise WicError(msg)
return ret, out
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/6] wic: fix for #11017
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
` (5 preceding siblings ...)
2017-02-21 15:23 ` [PATCH 6/6] wic: raise WicError instead of calling logger.error Ed Bartosh
@ 2017-02-22 16:38 ` Burton, Ross
2017-02-22 20:53 ` Ed Bartosh
2017-02-23 14:08 ` Patrick Ohly
7 siblings, 1 reply; 12+ messages in thread
From: Burton, Ross @ 2017-02-22 16:38 UTC (permalink / raw)
To: Ed Bartosh; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]
Hi Ed,
Something in your latest patchset is breaking selftest:
https://autobuilder.yoctoproject.org/main/builders/nightly-wic/builds/626/steps/CreateWicImages/logs/stdio
The broken commit is somewhere in ross/mut-wic. Can you verify that I
didn't leave something out, or otherwise chase this?
Ross
On 21 February 2017 at 15:23, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> Hi,
>
> This patchset improves handling of wic native tool dependencies and
> fixes minor bugs in the wic code.
>
> The following changes since commit 9a0ddad5e178d16f302af2d05c3236
> 8572849fd3:
>
> wic: pluginbase: use global dictionary (2017-02-20 11:58:28 +0200)
>
> are available in the git repository at:
>
> git://git.yoctoproject.org/poky-contrib ed/wic/wip
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip
>
> Ed Bartosh (6):
> wic: use 2 sysroots to find native executable
> wic: use image recipe sysroot as default
> wic: exec_native_cmd: improve debug message
> wic: exec_native_cmd: fix undefined variable error
> wic: add WKS_FILE_DEPENDS variable
> wic: raise WicError instead of calling logger.error
>
> meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
> meta/classes/image_types_wic.bbclass | 2 ++
> scripts/lib/wic/plugins/source/bootimg-pcbios.py | 4 ++--
> scripts/lib/wic/utils/misc.py | 13 +++++++++----
> scripts/wic | 2 +-
> 5 files changed, 15 insertions(+), 8 deletions(-)
>
> --
> Regards,
> Ed
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 3039 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/6] wic: fix for #11017
2017-02-22 16:38 ` [PATCH 0/6] wic: fix for #11017 Burton, Ross
@ 2017-02-22 20:53 ` Ed Bartosh
2017-02-23 10:18 ` Ed Bartosh
0 siblings, 1 reply; 12+ messages in thread
From: Ed Bartosh @ 2017-02-22 20:53 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Wed, Feb 22, 2017 at 04:38:55PM +0000, Burton, Ross wrote:
> Hi Ed,
>
> Something in your latest patchset is breaking selftest:
>
> https://autobuilder.yoctoproject.org/main/builders/nightly-wic/builds/626/steps/CreateWicImages/logs/stdio
>
> The broken commit is somewhere in ross/mut-wic. Can you verify that I
> didn't leave something out, or otherwise chase this?
>
I couldn't reproduce this so far. Will investigate further.
Can you merge this patchset please?
http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132854.html
The failure is most probably caused by patchset from this thread.
Regards,
Ed
> On 21 February 2017 at 15:23, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
>
> > Hi,
> >
> > This patchset improves handling of wic native tool dependencies and
> > fixes minor bugs in the wic code.
> >
> > The following changes since commit 9a0ddad5e178d16f302af2d05c3236
> > 8572849fd3:
> >
> > wic: pluginbase: use global dictionary (2017-02-20 11:58:28 +0200)
> >
> > are available in the git repository at:
> >
> > git://git.yoctoproject.org/poky-contrib ed/wic/wip
> > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip
> >
> > Ed Bartosh (6):
> > wic: use 2 sysroots to find native executable
> > wic: use image recipe sysroot as default
> > wic: exec_native_cmd: improve debug message
> > wic: exec_native_cmd: fix undefined variable error
> > wic: add WKS_FILE_DEPENDS variable
> > wic: raise WicError instead of calling logger.error
> >
> > meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
> > meta/classes/image_types_wic.bbclass | 2 ++
> > scripts/lib/wic/plugins/source/bootimg-pcbios.py | 4 ++--
> > scripts/lib/wic/utils/misc.py | 13 +++++++++----
> > scripts/wic | 2 +-
> > 5 files changed, 15 insertions(+), 8 deletions(-)
> >
> > --
> > Regards,
> > Ed
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/6] wic: fix for #11017
2017-02-22 20:53 ` Ed Bartosh
@ 2017-02-23 10:18 ` Ed Bartosh
2017-02-23 10:39 ` Ed Bartosh
0 siblings, 1 reply; 12+ messages in thread
From: Ed Bartosh @ 2017-02-23 10:18 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Wed, Feb 22, 2017 at 10:53:35PM +0200, Ed Bartosh wrote:
> On Wed, Feb 22, 2017 at 04:38:55PM +0000, Burton, Ross wrote:
> > Hi Ed,
> >
> > Something in your latest patchset is breaking selftest:
> >
> > https://autobuilder.yoctoproject.org/main/builders/nightly-wic/builds/626/steps/CreateWicImages/logs/stdio
> >
> > The broken commit is somewhere in ross/mut-wic. Can you verify that I
> > didn't leave something out, or otherwise chase this?
> >
> I couldn't reproduce this so far. Will investigate further.
>
> Can you merge this patchset please?
> http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132854.html
>
> The failure is most probably caused by patchset from this thread.
>
Still not able to reproduce it. It works just fine in my environment.
This time I used setup as close to AB as I could get: core-image-sato
image, genericx86-64 machine, clean build.
[build-genericx86-64 (ed/wic/wip)]$ rm -rf tmp/
[build-genericx86-64 (ed/wic/wip)]$ bitbake core-image-sato
WARNING: Host distribution "opensuse-13.2" has not been validated with
this version of the build system; you may possibly experience unexpected
failures. It is recommended that you use a tested distribution.
Parsing recipes: 100%
|###############################################################################################################################################|
Time: 0:00:13
Parsing of 856 .bb files complete (0 cached, 856 parsed). 1322 targets,
53 skipped, 0 masked, 0 errors.
NOTE: Resolving any missing task queue dependencies
Build Configuration:
BB_VERSION = "1.33.1"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING = "opensuse-13.2"
TARGET_SYS = "x86_64-poky-linux"
MACHINE = "genericx86-64"
DISTRO = "poky"
DISTRO_VERSION = "2.2+snapshot-20170222"
TUNE_FEATURES = "m64 core2"
TARGET_FPU = ""
meta
meta-poky
meta-yocto-bsp =
"ed/wic/wip:5d96bc6d1af89dda11f3266548fe1547152c86e1"
Initialising tasks: 100%
|############################################################################################################################################|
Time: 0:00:15
NOTE: Executing SetScene Tasks
NOTE: Executing RunQueue Tasks
NOTE: Tasks Summary: Attempted 6116 tasks of which 2807 didn't need to
be rerun and all succeeded.
Summary: There was 1 WARNING message shown.
[build-genericx86-64 (ed/wic/wip)]$ wic create directdisk -e core-image-sato
INFO: Creating image(s)...
INFO: The new image(s) can be found here:
./directdisk-201702231207-sda.direct
The following build artifacts were used to create the image(s):
ROOTFS_DIR:
/home/ed/git/yocto/poky/build-genericx86-64/tmp/work/genericx86_64-poky-linux/core-image-sato/1.0-r0/rootfs
BOOTIMG_DIR:
/home/ed/git/yocto/poky/build-genericx86-64/tmp/work/core2-64-poky-linux/wic-tools/1.0-r0/recipe-sysroot/usr/share
KERNEL_DIR:
/home/ed/git/yocto/poky/build-genericx86-64/tmp/deploy/images/genericx86-64
NATIVE_SYSROOT:
/home/ed/git/yocto/poky/build-genericx86-64/tmp/work/genericx86_64-poky-linux/core-image-sato/1.0-r0/recipe-sysroot-native
INFO: The image(s) were created using OE kickstart file:
/home/ed/git/yocto/poky/scripts/lib/wic/canned-wks/directdisk.wks
Could it be because of something in AB setup?
Regards,
Ed
> > On 21 February 2017 at 15:23, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> >
> > > Hi,
> > >
> > > This patchset improves handling of wic native tool dependencies and
> > > fixes minor bugs in the wic code.
> > >
> > > The following changes since commit 9a0ddad5e178d16f302af2d05c3236
> > > 8572849fd3:
> > >
> > > wic: pluginbase: use global dictionary (2017-02-20 11:58:28 +0200)
> > >
> > > are available in the git repository at:
> > >
> > > git://git.yoctoproject.org/poky-contrib ed/wic/wip
> > > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip
> > >
> > > Ed Bartosh (6):
> > > wic: use 2 sysroots to find native executable
> > > wic: use image recipe sysroot as default
> > > wic: exec_native_cmd: improve debug message
> > > wic: exec_native_cmd: fix undefined variable error
> > > wic: add WKS_FILE_DEPENDS variable
> > > wic: raise WicError instead of calling logger.error
> > >
> > > meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
> > > meta/classes/image_types_wic.bbclass | 2 ++
> > > scripts/lib/wic/plugins/source/bootimg-pcbios.py | 4 ++--
> > > scripts/lib/wic/utils/misc.py | 13 +++++++++----
> > > scripts/wic | 2 +-
> > > 5 files changed, 15 insertions(+), 8 deletions(-)
> > >
> > > --
> > > Regards,
> > > Ed
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > >
>
> --
> --
> Regards,
> Ed
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/6] wic: fix for #11017
2017-02-23 10:18 ` Ed Bartosh
@ 2017-02-23 10:39 ` Ed Bartosh
0 siblings, 0 replies; 12+ messages in thread
From: Ed Bartosh @ 2017-02-23 10:39 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Thu, Feb 23, 2017 at 12:18:04PM +0200, Ed Bartosh wrote:
> On Wed, Feb 22, 2017 at 10:53:35PM +0200, Ed Bartosh wrote:
> > On Wed, Feb 22, 2017 at 04:38:55PM +0000, Burton, Ross wrote:
> > > Hi Ed,
> > >
> > > Something in your latest patchset is breaking selftest:
> > >
> > > https://autobuilder.yoctoproject.org/main/builders/nightly-wic/builds/626/steps/CreateWicImages/logs/stdio
> > >
> > > The broken commit is somewhere in ross/mut-wic. Can you verify that I
> > > didn't leave something out, or otherwise chase this?
> > >
> > I couldn't reproduce this so far. Will investigate further.
> >
> > Can you merge this patchset please?
> > http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132854.html
> >
> > The failure is most probably caused by patchset from this thread.
> >
>
> Still not able to reproduce it. It works just fine in my environment.
> This time I used setup as close to AB as I could get: core-image-sato
> image, genericx86-64 machine, clean build.
>
> [build-genericx86-64 (ed/wic/wip)]$ rm -rf tmp/
>
> [build-genericx86-64 (ed/wic/wip)]$ bitbake core-image-sato
> WARNING: Host distribution "opensuse-13.2" has not been validated with
> this version of the build system; you may possibly experience unexpected
> failures. It is recommended that you use a tested distribution.
> Parsing recipes: 100%
> |###############################################################################################################################################|
> Time: 0:00:13
> Parsing of 856 .bb files complete (0 cached, 856 parsed). 1322 targets,
> 53 skipped, 0 masked, 0 errors.
> NOTE: Resolving any missing task queue dependencies
>
> Build Configuration:
> BB_VERSION = "1.33.1"
> BUILD_SYS = "x86_64-linux"
> NATIVELSBSTRING = "opensuse-13.2"
> TARGET_SYS = "x86_64-poky-linux"
> MACHINE = "genericx86-64"
> DISTRO = "poky"
> DISTRO_VERSION = "2.2+snapshot-20170222"
> TUNE_FEATURES = "m64 core2"
> TARGET_FPU = ""
> meta
> meta-poky
> meta-yocto-bsp =
> "ed/wic/wip:5d96bc6d1af89dda11f3266548fe1547152c86e1"
>
> Initialising tasks: 100%
> |############################################################################################################################################|
> Time: 0:00:15
> NOTE: Executing SetScene Tasks
> NOTE: Executing RunQueue Tasks
> NOTE: Tasks Summary: Attempted 6116 tasks of which 2807 didn't need to
> be rerun and all succeeded.
>
> Summary: There was 1 WARNING message shown.
>
> [build-genericx86-64 (ed/wic/wip)]$ wic create directdisk -e core-image-sato
> INFO: Creating image(s)...
>
> INFO: The new image(s) can be found here:
> ./directdisk-201702231207-sda.direct
>
> The following build artifacts were used to create the image(s):
> ROOTFS_DIR:
> /home/ed/git/yocto/poky/build-genericx86-64/tmp/work/genericx86_64-poky-linux/core-image-sato/1.0-r0/rootfs
> BOOTIMG_DIR:
> /home/ed/git/yocto/poky/build-genericx86-64/tmp/work/core2-64-poky-linux/wic-tools/1.0-r0/recipe-sysroot/usr/share
> KERNEL_DIR:
> /home/ed/git/yocto/poky/build-genericx86-64/tmp/deploy/images/genericx86-64
> NATIVE_SYSROOT:
> /home/ed/git/yocto/poky/build-genericx86-64/tmp/work/genericx86_64-poky-linux/core-image-sato/1.0-r0/recipe-sysroot-native
>
> INFO: The image(s) were created using OE kickstart file:
> /home/ed/git/yocto/poky/scripts/lib/wic/canned-wks/directdisk.wks
>
>
> Could it be because of something in AB setup?
>
Now I'm pretty sure it's because of AB setup.
I was not able to reproduce it as I used genericx86-64 machine mentioned
on the build page:
https://autobuilder.yoctoproject.org/main/builders/nightly-wic/builds/623
However, AB switched to qemux86-64 machine despite of what's specified.
This is very confusing.
Anyway, the reason of the failure is that AB builds set of tools for wic
in step 12: BuildImages Building syslinux syslinux-native parted-native
gptfdisk-native dosfstools-native mtools-native, but due to RSS those
tools are not accessible by wic. AB should build wic-tools instead.
Regards,
Ed
> > > On 21 February 2017 at 15:23, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > This patchset improves handling of wic native tool dependencies and
> > > > fixes minor bugs in the wic code.
> > > >
> > > > The following changes since commit 9a0ddad5e178d16f302af2d05c3236
> > > > 8572849fd3:
> > > >
> > > > wic: pluginbase: use global dictionary (2017-02-20 11:58:28 +0200)
> > > >
> > > > are available in the git repository at:
> > > >
> > > > git://git.yoctoproject.org/poky-contrib ed/wic/wip
> > > > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip
> > > >
> > > > Ed Bartosh (6):
> > > > wic: use 2 sysroots to find native executable
> > > > wic: use image recipe sysroot as default
> > > > wic: exec_native_cmd: improve debug message
> > > > wic: exec_native_cmd: fix undefined variable error
> > > > wic: add WKS_FILE_DEPENDS variable
> > > > wic: raise WicError instead of calling logger.error
> > > >
> > > > meta-selftest/recipes-test/images/wic-image-minimal.bb | 2 +-
> > > > meta/classes/image_types_wic.bbclass | 2 ++
> > > > scripts/lib/wic/plugins/source/bootimg-pcbios.py | 4 ++--
> > > > scripts/lib/wic/utils/misc.py | 13 +++++++++----
> > > > scripts/wic | 2 +-
> > > > 5 files changed, 15 insertions(+), 8 deletions(-)
> > > >
> > > > --
> > > > Regards,
> > > > Ed
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-core mailing list
> > > > Openembedded-core@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > > >
> >
> > --
> > --
> > Regards,
> > Ed
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> --
> Regards,
> Ed
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/6] wic: fix for #11017
2017-02-21 15:23 [PATCH 0/6] wic: fix for #11017 Ed Bartosh
` (6 preceding siblings ...)
2017-02-22 16:38 ` [PATCH 0/6] wic: fix for #11017 Burton, Ross
@ 2017-02-23 14:08 ` Patrick Ohly
7 siblings, 0 replies; 12+ messages in thread
From: Patrick Ohly @ 2017-02-23 14:08 UTC (permalink / raw)
To: Ed Bartosh; +Cc: openembedded-core
On Tue, 2017-02-21 at 17:23 +0200, Ed Bartosh wrote:
> This patchset improves handling of wic native tool dependencies and
> fixes minor bugs in the wic code.
I haven't tested it, but the patches themselves look good to me. Thanks!
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
^ permalink raw reply [flat|nested] 12+ messages in thread