[PATCH v5 1/3] wayland : Bump to version 1.14.0

[PATCH v5 1/3] wayland : Bump to version 1.14.0

[Fabien Lahoudere]

Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
 .../recipes-graphics/wayland/{wayland_1.13.0.bb => wayland_1.14.0.bb} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-graphics/wayland/{wayland_1.13.0.bb => wayland_1.14.0.bb} (92%)

diff --git a/meta/recipes-graphics/wayland/wayland_1.13.0.bb b/meta/recipes-graphics/wayland/wayland_1.14.0.bb
similarity index 92%
rename from meta/recipes-graphics/wayland/wayland_1.13.0.bb
rename to meta/recipes-graphics/wayland/wayland_1.14.0.bb
index b9396b6c75..2a2489d658 100644
--- a/meta/recipes-graphics/wayland/wayland_1.13.0.bb
+++ b/meta/recipes-graphics/wayland/wayland_1.14.0.bb
@@ -14,8 +14,8 @@ DEPENDS = "expat libxml2 libffi wayland-native"
 
 SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
            "
-SRC_URI[md5sum] = "cae152ed956da6de53f9727bc1c45039"
-SRC_URI[sha256sum] = "69b052c031a61e89af7cc8780893d0da1e301492352aa449dee9345043e6fe51"
+SRC_URI[md5sum] = "0235f6075c32c3be61cff94fa0b9f108"
+SRC_URI[sha256sum] = "ed80cabc0961a759a42092e2c39aabfc1ec9a13c86c98bbe2b812f008da27ab8"
 
 inherit autotools pkgconfig
 
-- 
2.11.0

[PATCH v5 2/3] wayland-protocols: Fix installation patch issue

[Fabien Lahoudere]

This patch also remove workaround to find wayland-protocols:

WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}

in:

- gtk+3
- libsdl2
- xserver-xorg
- gstreamer1.0-plugins-bad
- weston-2.0.0

Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
 meta/recipes-gnome/gtk+/gtk+3.inc                  |  1 -
 meta/recipes-graphics/libsdl2/libsdl2_2.0.5.bb     |  2 +-
 .../usesysrootprefixforpkgdatadirvariable.patch    | 27 ++++++++++++++++++++++
 .../wayland/wayland-protocols_1.10.bb              |  1 +
 meta/recipes-graphics/wayland/weston_2.0.0.bb      |  1 -
 .../recipes-graphics/xorg-xserver/xserver-xorg.inc |  1 -
 .../gstreamer/gstreamer1.0-plugins-bad_1.12.2.bb   |  1 -
 7 files changed, 29 insertions(+), 5 deletions(-)
 create mode 100644 meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch

diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc
index 0a357db049..420ead2ca2 100644
--- a/meta/recipes-gnome/gtk+/gtk+3.inc
+++ b/meta/recipes-gnome/gtk+/gtk+3.inc
@@ -35,7 +35,6 @@ EXTRA_OECONF += " \
                  --enable-modules \
                  --disable-cups \
                  --disable-colord \
-                 WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \
                  ${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \
                  "
 
diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.5.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.5.bb
index 12d3aaf6f0..6bfa13200b 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.5.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.5.bb
@@ -35,7 +35,7 @@ EXTRA_OECONF = "--disable-oss --disable-esd --disable-arts \
                 --enable-pthreads \
                 --enable-sdl-dlopen \
                 --disable-rpath \
-                WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}"
+                "
 
 # opengl packageconfig factored out to make it easy for distros
 # and BSP layers to pick either (desktop) opengl, gles2, or no GL
diff --git a/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch b/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch
new file mode 100644
index 0000000000..0922a4d2c2
--- /dev/null
+++ b/meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch
@@ -0,0 +1,27 @@
+From 875130ee3cbcf62266901ef4b91b9a0fb6adad43 Mon Sep 17 00:00:00 2001
+From: Tomek Bury <tomek.bury@broadcom.com>
+Date: Fri, 4 Aug 2017 16:16:38 +0100
+Subject: Use sysroot prefix for pkgdatadir variable
+
+The pc_sysroot is automatically added to cflags and libs but not
+to 'pkg-config --variable'
+
+Upstream-Status: Backport [https://cgit.freedesktop.org/wayland/wayland-protocols/commit/?id=875130ee3cbcf62266901ef4b91b9a0fb6adad43]
+
+Reviewed-by: Daniel Stone <daniels@collabora.com>
+
+diff --git a/wayland-protocols.pc.in b/wayland-protocols.pc.in
+index a26744c..379be06 100644
+--- a/wayland-protocols.pc.in
++++ b/wayland-protocols.pc.in
+@@ -1,6 +1,6 @@
+ prefix=@prefix@
+ datarootdir=@datarootdir@
+-pkgdatadir=@datadir@/@PACKAGE@
++pkgdatadir=${pc_sysrootdir}@datadir@/@PACKAGE@
+ 
+ Name: Wayland Protocols
+ Description: Wayland protocol files
+-- 
+cgit v0.10.2
+
diff --git a/meta/recipes-graphics/wayland/wayland-protocols_1.10.bb b/meta/recipes-graphics/wayland/wayland-protocols_1.10.bb
index 4f9e9f32bf..1ff12c607b 100644
--- a/meta/recipes-graphics/wayland/wayland-protocols_1.10.bb
+++ b/meta/recipes-graphics/wayland/wayland-protocols_1.10.bb
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c7b12b6702da38ca028ace54aae3d484 \
                     file://stable/presentation-time/presentation-time.xml;endline=26;md5=4646cd7d9edc9fa55db941f2d3a7dc53"
 
 SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
+	   file://usesysrootprefixforpkgdatadirvariable.patch \
            "
 SRC_URI[md5sum] = "84a7846c2b6a6a3e265fc9be36453e60"
 SRC_URI[sha256sum] = "5719c51d7354864983171c5083e93a72ac99229e2b460c4bb10513de08839c0a"
diff --git a/meta/recipes-graphics/wayland/weston_2.0.0.bb b/meta/recipes-graphics/wayland/weston_2.0.0.bb
index 54b07bd6b9..8160f5556d 100644
--- a/meta/recipes-graphics/wayland/weston_2.0.0.bb
+++ b/meta/recipes-graphics/wayland/weston_2.0.0.bb
@@ -25,7 +25,6 @@ DEPENDS += "wayland wayland-protocols libinput virtual/egl pango wayland-native"
 
 EXTRA_OECONF = "--enable-setuid-install \
                 --disable-rdp-compositor \
-                WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \
                 "
 EXTRA_OECONF_append_qemux86 = "\
 		WESTON_NATIVE_BACKEND=fbdev-backend.so \
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
index 863d80ce43..e8025de55f 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
@@ -117,7 +117,6 @@ EXTRA_OECONF += "--with-fop=no \
                  --sysconfdir=/etc/X11 \
                  --localstatedir=/var \
                  --with-xkb-output=/var/lib/xkb \
-                 WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT} \
 "
 
 OPENGL_PKGCONFIGS = "dri glx glamor dri3 xshmfence"
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.12.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.12.2.bb
index 8321da0c27..a83a5bab21 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.12.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.12.2.bb
@@ -22,5 +22,4 @@ SRC_URI[sha256sum] = "9c2c7edde4f59d74eb414e0701c55131f562e5c605a3ce9b091754f106
 
 S = "${WORKDIR}/gst-plugins-bad-${PV}"
 
-EXTRA_OECONF += "WAYLAND_PROTOCOLS_SYSROOT_DIR=${RECIPE_SYSROOT}"
 
-- 
2.11.0

[PATCH v5 3/3] weston: Bump version to 3.0.0

[Fabien Lahoudere]

Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
 .../wayland/weston/fix-missing-header.patch        | 18 +++++++
 ...t-pitch-correctly-for-subsampled-textures.patch | 55 ++++++++++++++++++++++
 .../wayland/{weston_2.0.0.bb => weston_3.0.0.bb}   | 17 +++----
 3 files changed, 82 insertions(+), 8 deletions(-)
 create mode 100644 meta/recipes-graphics/wayland/weston/fix-missing-header.patch
 create mode 100644 meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
 rename meta/recipes-graphics/wayland/{weston_2.0.0.bb => weston_3.0.0.bb} (89%)

diff --git a/meta/recipes-graphics/wayland/weston/fix-missing-header.patch b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
new file mode 100644
index 0000000000..5db3a17393
--- /dev/null
+++ b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
@@ -0,0 +1,18 @@
+Fix missing header
+
+Upstream-Status: Pending
+
+Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
+
+Index: weston-3.0.0/shared/timespec-util.h
+===================================================================
+--- weston-3.0.0.orig/shared/timespec-util.h
++++ weston-3.0.0/shared/timespec-util.h
+@@ -28,6 +28,7 @@
+ 
+ #include <stdint.h>
+ #include <assert.h>
++#include <time.h>
+ 
+ #define NSEC_PER_SEC 1000000000
+ 
diff --git a/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
new file mode 100644
index 0000000000..69284a9616
--- /dev/null
+++ b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
@@ -0,0 +1,55 @@
+Multi-plane sub-sampled textures have partial width/height, e.g.
+YUV420/I420 has a full-size Y plane, followed by a half-width/height U
+plane, and a half-width/height V plane.
+
+zwp_linux_dmabuf_v1 allows clients to pass an explicit pitch for each
+plane, but for wl_shm this must be inferred. gl-renderer was correctly
+accounting for the width and height when subsampling, but the pitch was
+being taken as the pitch for the first plane.
+
+This does not match the requirements for GStreamer's waylandsink, in
+particular, as well as other clients. Fix the SHM upload path to
+correctly set the pitch for each plane, according to subsampling.
+
+Tested with:
+  $ gst-launch-1.0 videotestsrc ! waylandsink
+
+Upstream-status: Backport [https://patchwork.freedesktop.org/patch/180767/]
+
+Signed-off-by: Daniel Stone <daniels@collabora.com>
+Fixes: fdeefe42418 ("gl-renderer: add support of WL_SHM_FORMAT_YUV420")
+Reported-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
+Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103063
+
+---
+ libweston/gl-renderer.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
+index 244ce309..40bf0bb6 100644
+--- a/libweston/gl-renderer.c
++++ b/libweston/gl-renderer.c
+@@ -1445,14 +1445,13 @@ gl_renderer_flush_damage(struct weston_surface *surface)
+ 		goto done;
+ 	}
+ 
+-	glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch);
+-
+ 	if (gs->needs_full_upload) {
+ 		glPixelStorei(GL_UNPACK_SKIP_PIXELS_EXT, 0);
+ 		glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, 0);
+ 		wl_shm_buffer_begin_access(buffer->shm_buffer);
+ 		for (j = 0; j < gs->num_textures; j++) {
+ 			glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
++			glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
+ 			glTexImage2D(GL_TEXTURE_2D, 0,
+ 				     gs->gl_format[j],
+ 				     gs->pitch / gs->hsub[j],
+@@ -1477,6 +1476,7 @@ gl_renderer_flush_damage(struct weston_surface *surface)
+ 		glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, r.y1);
+ 		for (j = 0; j < gs->num_textures; j++) {
+ 			glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
++			glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
+ 			glTexSubImage2D(GL_TEXTURE_2D, 0,
+ 					r.x1 / gs->hsub[j],
+ 					r.y1 / gs->vsub[j],
diff --git a/meta/recipes-graphics/wayland/weston_2.0.0.bb b/meta/recipes-graphics/wayland/weston_3.0.0.bb
similarity index 89%
rename from meta/recipes-graphics/wayland/weston_2.0.0.bb
rename to meta/recipes-graphics/wayland/weston_3.0.0.bb
index 8160f5556d..ad0cdc2b0f 100644
--- a/meta/recipes-graphics/wayland/weston_2.0.0.bb
+++ b/meta/recipes-graphics/wayland/weston_3.0.0.bb
@@ -9,12 +9,13 @@ SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
            file://weston.png \
            file://weston.desktop \
            file://0001-make-error-portable.patch \
-           file://0001-configure.ac-Fix-wayland-protocols-path.patch \
            file://xwayland.weston-start \
            file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \
+	   file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch \
+	   file://fix-missing-header.patch \
 "
-SRC_URI[md5sum] = "15f38945942bf2a91fe2687145fb4c7d"
-SRC_URI[sha256sum] = "b4e446ac27f118196f1609dab89bb3cb3e81652d981414ad860e733b355365d8"
+SRC_URI[md5sum] = "9c42a4c51a1b9f35d040fa9d45ada36d"
+SRC_URI[sha256sum] = "cde1d55e8dd70c3cbb3d1ec72f60e60000041579caa1d6a262bd9c35e93723a5"
 
 inherit autotools pkgconfig useradd distro_features_check
 # depends on virtual/egl
@@ -76,7 +77,7 @@ PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam"
 
 do_install_append() {
 	# Weston doesn't need the .la files to load modules, so wipe them
-	rm -f ${D}/${libdir}/libweston-2/*.la
+	rm -f ${D}/${libdir}/libweston-3/*.la
 
 	# If X11, ship a desktop file to launch it
 	if [ "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}" ]; then
@@ -93,16 +94,16 @@ do_install_append() {
 }
 
 PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'xwayland', '${PN}-xwayland', '', d)} \
-             libweston-2 ${PN}-examples"
+             libweston-3 ${PN}-examples"
 
 FILES_${PN} = "${bindir}/weston ${bindir}/weston-terminal ${bindir}/weston-info ${bindir}/weston-launch ${bindir}/wcap-decode ${libexecdir} ${libdir}/${BPN}/*.so ${datadir}"
 
-FILES_libweston-2 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-2/*.so"
-SUMMARY_libweston-2 = "Helper library for implementing 'wayland window managers'."
+FILES_libweston-3 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-3/*.so"
+SUMMARY_libweston-3 = "Helper library for implementing 'wayland window managers'."
 
 FILES_${PN}-examples = "${bindir}/*"
 
-FILES_${PN}-xwayland = "${libdir}/libweston-2/xwayland.so"
+FILES_${PN}-xwayland = "${libdir}/libweston-3/xwayland.so"
 RDEPENDS_${PN}-xwayland += "xserver-xorg-xwayland"
 
 RDEPENDS_${PN} += "xkeyboard-config"
-- 
2.11.0

Re: [PATCH v5 1/3] wayland : Bump to version 1.14.0

[Fabien Lahoudere]

Bad serie please ignore.

Sorry

On Mon, 2017-10-16 at 19:21 +0200, Fabien Lahoudere wrote:
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> ---
>  .../recipes-graphics/wayland/{wayland_1.13.0.bb => wayland_1.14.0.bb} | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  rename meta/recipes-graphics/wayland/{wayland_1.13.0.bb => wayland_1.14.0.bb} (92%)
> 
> diff --git a/meta/recipes-graphics/wayland/wayland_1.13.0.bb b/meta/recipes-
> graphics/wayland/wayland_1.14.0.bb
> similarity index 92%
> rename from meta/recipes-graphics/wayland/wayland_1.13.0.bb
> rename to meta/recipes-graphics/wayland/wayland_1.14.0.bb
> index b9396b6c75..2a2489d658 100644
> --- a/meta/recipes-graphics/wayland/wayland_1.13.0.bb
> +++ b/meta/recipes-graphics/wayland/wayland_1.14.0.bb
> @@ -14,8 +14,8 @@ DEPENDS = "expat libxml2 libffi wayland-native"
>  
>  SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
>             "
> -SRC_URI[md5sum] = "cae152ed956da6de53f9727bc1c45039"
> -SRC_URI[sha256sum] = "69b052c031a61e89af7cc8780893d0da1e301492352aa449dee9345043e6fe51"
> +SRC_URI[md5sum] = "0235f6075c32c3be61cff94fa0b9f108"
> +SRC_URI[sha256sum] = "ed80cabc0961a759a42092e2c39aabfc1ec9a13c86c98bbe2b812f008da27ab8"
>  
>  inherit autotools pkgconfig
>  
-- 
Fabien

✗ patchtest: failure for "[v5] wayland : Bump to version..." and 2 more

[Patchwork]

== Series Details ==

Series: "[v5] wayland : Bump to version..." and 2 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/9362/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] 
  Suggested fix    Add Upstream-Status: <status> to the header of meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue             A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence] 
  Suggested fix    Sign off the added patch file (meta/recipes-graphics/wayland/wayland-protocols/usesysrootprefixforpkgdatadirvariable.patch)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Otavio Salvador]

On Mon, Oct 16, 2017 at 3:21 PM, Fabien Lahoudere
<fabien.lahoudere@collabora.co.uk> wrote:
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> ---
>  .../wayland/weston/fix-missing-header.patch        | 18 +++++++
>  ...t-pitch-correctly-for-subsampled-textures.patch | 55 ++++++++++++++++++++++
>  .../wayland/{weston_2.0.0.bb => weston_3.0.0.bb}   | 17 +++----
>  3 files changed, 82 insertions(+), 8 deletions(-)
>  create mode 100644 meta/recipes-graphics/wayland/weston/fix-missing-header.patch
>  create mode 100644 meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
>  rename meta/recipes-graphics/wayland/{weston_2.0.0.bb => weston_3.0.0.bb} (89%)
>
> diff --git a/meta/recipes-graphics/wayland/weston/fix-missing-header.patch b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
> new file mode 100644
> index 0000000000..5db3a17393
> --- /dev/null
> +++ b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
> @@ -0,0 +1,18 @@
> +Fix missing header
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> +
> +Index: weston-3.0.0/shared/timespec-util.h
> +===================================================================
> +--- weston-3.0.0.orig/shared/timespec-util.h
> ++++ weston-3.0.0/shared/timespec-util.h
> +@@ -28,6 +28,7 @@
> +
> + #include <stdint.h>
> + #include <assert.h>
> ++#include <time.h>
> +
> + #define NSEC_PER_SEC 1000000000
> +
> diff --git a/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> new file mode 100644
> index 0000000000..69284a9616
> --- /dev/null
> +++ b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> @@ -0,0 +1,55 @@
> +Multi-plane sub-sampled textures have partial width/height, e.g.
> +YUV420/I420 has a full-size Y plane, followed by a half-width/height U
> +plane, and a half-width/height V plane.
> +
> +zwp_linux_dmabuf_v1 allows clients to pass an explicit pitch for each
> +plane, but for wl_shm this must be inferred. gl-renderer was correctly
> +accounting for the width and height when subsampling, but the pitch was
> +being taken as the pitch for the first plane.
> +
> +This does not match the requirements for GStreamer's waylandsink, in
> +particular, as well as other clients. Fix the SHM upload path to
> +correctly set the pitch for each plane, according to subsampling.
> +
> +Tested with:
> +  $ gst-launch-1.0 videotestsrc ! waylandsink
> +
> +Upstream-status: Backport [https://patchwork.freedesktop.org/patch/180767/]
> +
> +Signed-off-by: Daniel Stone <daniels@collabora.com>
> +Fixes: fdeefe42418 ("gl-renderer: add support of WL_SHM_FORMAT_YUV420")
> +Reported-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> +Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103063
> +
> +---
> + libweston/gl-renderer.c | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
> +index 244ce309..40bf0bb6 100644
> +--- a/libweston/gl-renderer.c
> ++++ b/libweston/gl-renderer.c
> +@@ -1445,14 +1445,13 @@ gl_renderer_flush_damage(struct weston_surface *surface)
> +               goto done;
> +       }
> +
> +-      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch);
> +-
> +       if (gs->needs_full_upload) {
> +               glPixelStorei(GL_UNPACK_SKIP_PIXELS_EXT, 0);
> +               glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, 0);
> +               wl_shm_buffer_begin_access(buffer->shm_buffer);
> +               for (j = 0; j < gs->num_textures; j++) {
> +                       glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
> ++                      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
> +                       glTexImage2D(GL_TEXTURE_2D, 0,
> +                                    gs->gl_format[j],
> +                                    gs->pitch / gs->hsub[j],
> +@@ -1477,6 +1476,7 @@ gl_renderer_flush_damage(struct weston_surface *surface)
> +               glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, r.y1);
> +               for (j = 0; j < gs->num_textures; j++) {
> +                       glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
> ++                      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
> +                       glTexSubImage2D(GL_TEXTURE_2D, 0,
> +                                       r.x1 / gs->hsub[j],
> +                                       r.y1 / gs->vsub[j],
> diff --git a/meta/recipes-graphics/wayland/weston_2.0.0.bb b/meta/recipes-graphics/wayland/weston_3.0.0.bb
> similarity index 89%
> rename from meta/recipes-graphics/wayland/weston_2.0.0.bb
> rename to meta/recipes-graphics/wayland/weston_3.0.0.bb
> index 8160f5556d..ad0cdc2b0f 100644
> --- a/meta/recipes-graphics/wayland/weston_2.0.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_3.0.0.bb
> @@ -9,12 +9,13 @@ SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
>             file://weston.png \
>             file://weston.desktop \
>             file://0001-make-error-portable.patch \
> -           file://0001-configure.ac-Fix-wayland-protocols-path.patch \
>             file://xwayland.weston-start \
>             file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \
> +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch \
> +          file://fix-missing-header.patch \

Those should be documented on commit log

>  "
> -SRC_URI[md5sum] = "15f38945942bf2a91fe2687145fb4c7d"
> -SRC_URI[sha256sum] = "b4e446ac27f118196f1609dab89bb3cb3e81652d981414ad860e733b355365d8"
> +SRC_URI[md5sum] = "9c42a4c51a1b9f35d040fa9d45ada36d"
> +SRC_URI[sha256sum] = "cde1d55e8dd70c3cbb3d1ec72f60e60000041579caa1d6a262bd9c35e93723a5"
>
>  inherit autotools pkgconfig useradd distro_features_check
>  # depends on virtual/egl
> @@ -76,7 +77,7 @@ PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam"
>
>  do_install_append() {
>         # Weston doesn't need the .la files to load modules, so wipe them
> -       rm -f ${D}/${libdir}/libweston-2/*.la
> +       rm -f ${D}/${libdir}/libweston-3/*.la
>
>         # If X11, ship a desktop file to launch it
>         if [ "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}" ]; then
> @@ -93,16 +94,16 @@ do_install_append() {
>  }
>
>  PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'xwayland', '${PN}-xwayland', '', d)} \
> -             libweston-2 ${PN}-examples"
> +             libweston-3 ${PN}-examples"
>
>  FILES_${PN} = "${bindir}/weston ${bindir}/weston-terminal ${bindir}/weston-info ${bindir}/weston-launch ${bindir}/wcap-decode ${libexecdir} ${libdir}/${BPN}/*.so ${datadir}"
>
> -FILES_libweston-2 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-2/*.so"
> -SUMMARY_libweston-2 = "Helper library for implementing 'wayland window managers'."
> +FILES_libweston-3 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-3/*.so"
> +SUMMARY_libweston-3 = "Helper library for implementing 'wayland window managers'."
>
>  FILES_${PN}-examples = "${bindir}/*"
>
> -FILES_${PN}-xwayland = "${libdir}/libweston-2/xwayland.so"
> +FILES_${PN}-xwayland = "${libdir}/libweston-3/xwayland.so"
>  RDEPENDS_${PN}-xwayland += "xserver-xorg-xwayland"
>
>  RDEPENDS_${PN} += "xkeyboard-config"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Denys Dmytriyenko]

On Mon, Oct 16, 2017 at 03:30:34PM -0200, Otavio Salvador wrote:
> On Mon, Oct 16, 2017 at 3:21 PM, Fabien Lahoudere
> <fabien.lahoudere@collabora.co.uk> wrote:
> > Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> > ---
> >  .../wayland/weston/fix-missing-header.patch        | 18 +++++++
> >  ...t-pitch-correctly-for-subsampled-textures.patch | 55 ++++++++++++++++++++++
> >  .../wayland/{weston_2.0.0.bb => weston_3.0.0.bb}   | 17 +++----
> >  3 files changed, 82 insertions(+), 8 deletions(-)
> >  create mode 100644 meta/recipes-graphics/wayland/weston/fix-missing-header.patch
> >  create mode 100644 meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> >  rename meta/recipes-graphics/wayland/{weston_2.0.0.bb => weston_3.0.0.bb} (89%)
> >
> > diff --git a/meta/recipes-graphics/wayland/weston/fix-missing-header.patch b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
> > new file mode 100644
> > index 0000000000..5db3a17393
> > --- /dev/null
> > +++ b/meta/recipes-graphics/wayland/weston/fix-missing-header.patch
> > @@ -0,0 +1,18 @@
> > +Fix missing header
> > +
> > +Upstream-Status: Pending
> > +
> > +Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> > +
> > +Index: weston-3.0.0/shared/timespec-util.h
> > +===================================================================
> > +--- weston-3.0.0.orig/shared/timespec-util.h
> > ++++ weston-3.0.0/shared/timespec-util.h
> > +@@ -28,6 +28,7 @@
> > +
> > + #include <stdint.h>
> > + #include <assert.h>
> > ++#include <time.h>
> > +
> > + #define NSEC_PER_SEC 1000000000
> > +
> > diff --git a/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> > new file mode 100644
> > index 0000000000..69284a9616
> > --- /dev/null
> > +++ b/meta/recipes-graphics/wayland/weston/weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> > @@ -0,0 +1,55 @@
> > +Multi-plane sub-sampled textures have partial width/height, e.g.
> > +YUV420/I420 has a full-size Y plane, followed by a half-width/height U
> > +plane, and a half-width/height V plane.
> > +
> > +zwp_linux_dmabuf_v1 allows clients to pass an explicit pitch for each
> > +plane, but for wl_shm this must be inferred. gl-renderer was correctly
> > +accounting for the width and height when subsampling, but the pitch was
> > +being taken as the pitch for the first plane.
> > +
> > +This does not match the requirements for GStreamer's waylandsink, in
> > +particular, as well as other clients. Fix the SHM upload path to
> > +correctly set the pitch for each plane, according to subsampling.
> > +
> > +Tested with:
> > +  $ gst-launch-1.0 videotestsrc ! waylandsink
> > +
> > +Upstream-status: Backport [https://patchwork.freedesktop.org/patch/180767/]
> > +
> > +Signed-off-by: Daniel Stone <daniels@collabora.com>
> > +Fixes: fdeefe42418 ("gl-renderer: add support of WL_SHM_FORMAT_YUV420")
> > +Reported-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
> > +Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103063
> > +
> > +---
> > + libweston/gl-renderer.c | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c
> > +index 244ce309..40bf0bb6 100644
> > +--- a/libweston/gl-renderer.c
> > ++++ b/libweston/gl-renderer.c
> > +@@ -1445,14 +1445,13 @@ gl_renderer_flush_damage(struct weston_surface *surface)
> > +               goto done;
> > +       }
> > +
> > +-      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch);
> > +-
> > +       if (gs->needs_full_upload) {
> > +               glPixelStorei(GL_UNPACK_SKIP_PIXELS_EXT, 0);
> > +               glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, 0);
> > +               wl_shm_buffer_begin_access(buffer->shm_buffer);
> > +               for (j = 0; j < gs->num_textures; j++) {
> > +                       glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
> > ++                      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
> > +                       glTexImage2D(GL_TEXTURE_2D, 0,
> > +                                    gs->gl_format[j],
> > +                                    gs->pitch / gs->hsub[j],
> > +@@ -1477,6 +1476,7 @@ gl_renderer_flush_damage(struct weston_surface *surface)
> > +               glPixelStorei(GL_UNPACK_SKIP_ROWS_EXT, r.y1);
> > +               for (j = 0; j < gs->num_textures; j++) {
> > +                       glBindTexture(GL_TEXTURE_2D, gs->textures[j]);
> > ++                      glPixelStorei(GL_UNPACK_ROW_LENGTH_EXT, gs->pitch / gs->hsub[j]);
> > +                       glTexSubImage2D(GL_TEXTURE_2D, 0,
> > +                                       r.x1 / gs->hsub[j],
> > +                                       r.y1 / gs->vsub[j],
> > diff --git a/meta/recipes-graphics/wayland/weston_2.0.0.bb b/meta/recipes-graphics/wayland/weston_3.0.0.bb
> > similarity index 89%
> > rename from meta/recipes-graphics/wayland/weston_2.0.0.bb
> > rename to meta/recipes-graphics/wayland/weston_3.0.0.bb
> > index 8160f5556d..ad0cdc2b0f 100644
> > --- a/meta/recipes-graphics/wayland/weston_2.0.0.bb
> > +++ b/meta/recipes-graphics/wayland/weston_3.0.0.bb
> > @@ -9,12 +9,13 @@ SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
> >             file://weston.png \
> >             file://weston.desktop \
> >             file://0001-make-error-portable.patch \
> > -           file://0001-configure.ac-Fix-wayland-protocols-path.patch \

If this patch is no longer needed, should it be removed.


> >             file://xwayland.weston-start \
> >             file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \
> > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch \
> > +          file://fix-missing-header.patch \
> 
> Those should be documented on commit log

And I'm not sure the one about "pitch" correction in gl-renderer is critical 
enough to take it locally, is it?


> >  "
> > -SRC_URI[md5sum] = "15f38945942bf2a91fe2687145fb4c7d"
> > -SRC_URI[sha256sum] = "b4e446ac27f118196f1609dab89bb3cb3e81652d981414ad860e733b355365d8"
> > +SRC_URI[md5sum] = "9c42a4c51a1b9f35d040fa9d45ada36d"
> > +SRC_URI[sha256sum] = "cde1d55e8dd70c3cbb3d1ec72f60e60000041579caa1d6a262bd9c35e93723a5"
> >
> >  inherit autotools pkgconfig useradd distro_features_check
> >  # depends on virtual/egl
> > @@ -76,7 +77,7 @@ PACKAGECONFIG[pam] = "--with-pam,--without-pam,libpam"
> >
> >  do_install_append() {
> >         # Weston doesn't need the .la files to load modules, so wipe them
> > -       rm -f ${D}/${libdir}/libweston-2/*.la
> > +       rm -f ${D}/${libdir}/libweston-3/*.la
> >
> >         # If X11, ship a desktop file to launch it
> >         if [ "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}" ]; then
> > @@ -93,16 +94,16 @@ do_install_append() {
> >  }
> >
> >  PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'xwayland', '${PN}-xwayland', '', d)} \
> > -             libweston-2 ${PN}-examples"
> > +             libweston-3 ${PN}-examples"
> >
> >  FILES_${PN} = "${bindir}/weston ${bindir}/weston-terminal ${bindir}/weston-info ${bindir}/weston-launch ${bindir}/wcap-decode ${libexecdir} ${libdir}/${BPN}/*.so ${datadir}"
> >
> > -FILES_libweston-2 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-2/*.so"
> > -SUMMARY_libweston-2 = "Helper library for implementing 'wayland window managers'."
> > +FILES_libweston-3 = "${libdir}/lib*${SOLIBS} ${libdir}/libweston-3/*.so"
> > +SUMMARY_libweston-3 = "Helper library for implementing 'wayland window managers'."
> >
> >  FILES_${PN}-examples = "${bindir}/*"
> >
> > -FILES_${PN}-xwayland = "${libdir}/libweston-2/xwayland.so"
> > +FILES_${PN}-xwayland = "${libdir}/libweston-3/xwayland.so"
> >  RDEPENDS_${PN}-xwayland += "xserver-xorg-xwayland"
> >
> >  RDEPENDS_${PN} += "xkeyboard-config"
> > --
> > 2.11.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On 16 October 2017 at 18:30, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

>
> > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> \
> > +          file://fix-missing-header.patch \
>
> Those should be documented on commit log
>
>
Agreed.  The missing header one should say what platform causes it to be a
problem (in case it never gets upstreamed and someone tests it again on
just glibc).  And is the pitch patch sufficiently broken that we need to
backport it?

Ross

[-- Attachment #2: Type: text/html, Size: 1018 bytes --]

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Denys Dmytriyenko]

On Mon, Oct 16, 2017 at 09:34:04PM +0100, Burton, Ross wrote:
> On 16 October 2017 at 18:30, Otavio Salvador <
> otavio.salvador@ossystems.com.br> wrote:
> 
> >
> > > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> > \
> > > +          file://fix-missing-header.patch \
> >
> > Those should be documented on commit log
> >
> >
> Agreed.  The missing header one should say what platform causes it to be a
> problem (in case it never gets upstreamed and someone tests it again on
> just glibc).  


> And is the pitch patch sufficiently broken that we need to backport it?

My point exactly - doesn't seem to be a very broad problem...

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Fabien Lahoudere]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Mon, 2017-10-16 at 21:34 +0100, Burton, Ross wrote:
> On 16 October 2017 at 18:30, Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
> > > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch \
> > 
> > > +          file://fix-missing-header.patch \
> > 
> > 
> > 
> > Those should be documented on commit log
> > 
> > 
> > 
> 
> Agreed.  The missing header one should say what platform causes it to be a problem (in case it
> never gets upstreamed and someone tests it again on just glibc).  And is the pitch patch
> sufficiently broken that we need to backport it?

Without the pitch patch, all applications generating YUV420 will not be displayed correctly. For
example "gstlaunch1.0 testvideosrc ! waylandsink" fail.I can keep this patch in a bbappend if you
don't want it. Just tell me.
For the header patch, I will improve commit message.
I see there is an OVERRIDE libc-musl, should I use this patch in SRC_URI_libc-musl?
> Ross 
-- 
Fabien

[-- Attachment #2: Type: text/html, Size: 1802 bytes --]

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Em 17 de out de 2017 6:21 AM, "Fabien Lahoudere" <
fabien.lahoudere@collabora.co.uk> escreveu:

On Mon, 2017-10-16 at 21:34 +0100, Burton, Ross wrote:

On 16 October 2017 at 18:30, Otavio Salvador <otavio.salvador@ossystems.
com.br> wrote:


> +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
\
> +          file://fix-missing-header.patch \

Those should be documented on commit log



Agreed.  The missing header one should say what platform causes it to be a
problem (in case it never gets upstreamed and someone tests it again on
just glibc).  And is the pitch patch sufficiently broken that we need to
backport it?


Without the pitch patch, all applications generating YUV420 will not be
displayed correctly. For example "gstlaunch1.0 testvideosrc ! waylandsink"
fail.
I can keep this patch in a bbappend if you don't want it. Just tell me.


Please keep the patch. It fixes a issue and it is not BSP specific, so it
belongs to core. Just explain it on commit log.


For the header patch, I will improve commit message.

I see there is an OVERRIDE libc-musl, should I use this patch in
SRC_URI_libc-musl?


No, just mention it on commit log...



Ross

-- 

Fabien

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3416 bytes --]

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Denys Dmytriyenko]

On Tue, Oct 17, 2017 at 08:31:10AM -0200, Otavio Salvador wrote:
> Em 17 de out de 2017 6:21 AM, "Fabien Lahoudere" <
> fabien.lahoudere@collabora.co.uk> escreveu:
> 
> On Mon, 2017-10-16 at 21:34 +0100, Burton, Ross wrote:
> 
> On 16 October 2017 at 18:30, Otavio Salvador <otavio.salvador@ossystems.
> com.br> wrote:
> 
> 
> > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> \
> > +          file://fix-missing-header.patch \
> 
> Those should be documented on commit log
> 
> 
> 
> Agreed.  The missing header one should say what platform causes it to be a
> problem (in case it never gets upstreamed and someone tests it again on
> just glibc).  And is the pitch patch sufficiently broken that we need to
> backport it?
> 
> 
> Without the pitch patch, all applications generating YUV420 will not be
> displayed correctly. For example "gstlaunch1.0 testvideosrc ! waylandsink"
> fail.
> I can keep this patch in a bbappend if you don't want it. Just tell me.
> 
> 
> Please keep the patch. It fixes a issue and it is not BSP specific, so it
> belongs to core. Just explain it on commit log.

I don't have a very strong objection here, but it sounds like a corner case 
for one of the formats. Plus what's the difference between "fail" and "not 
displayed correctly"?


> For the header patch, I will improve commit message.
> 
> I see there is an OVERRIDE libc-musl, should I use this patch in
> SRC_URI_libc-musl?
> 
> 
> No, just mention it on commit log...
> 
> 
> 
> Ross
> 
> -- 
> 
> Fabien
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Fabien Lahoudere]

On Tue, 2017-10-17 at 18:59 -0400, Denys Dmytriyenko wrote:
> On Tue, Oct 17, 2017 at 08:31:10AM -0200, Otavio Salvador wrote:
> > Em 17 de out de 2017 6:21 AM, "Fabien Lahoudere" <
> > fabien.lahoudere@collabora.co.uk> escreveu:
> > 
> > On Mon, 2017-10-16 at 21:34 +0100, Burton, Ross wrote:
> > 
> > On 16 October 2017 at 18:30, Otavio Salvador <otavio.salvador@ossystems.
> > com.br> wrote:
> > 
> > 
> > > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> > 
> > \
> > > +          file://fix-missing-header.patch \
> > 
> > Those should be documented on commit log
> > 
> > 
> > 
> > Agreed.  The missing header one should say what platform causes it to be a
> > problem (in case it never gets upstreamed and someone tests it again on
> > just glibc).  And is the pitch patch sufficiently broken that we need to
> > backport it?
> > 
> > 
> > Without the pitch patch, all applications generating YUV420 will not be
> > displayed correctly. For example "gstlaunch1.0 testvideosrc ! waylandsink"
> > fail.
> > I can keep this patch in a bbappend if you don't want it. Just tell me.
> > 
> > 
> > Please keep the patch. It fixes a issue and it is not BSP specific, so it
> > belongs to core. Just explain it on commit log.
> 
> I don't have a very strong objection here, but it sounds like a corner case 
> for one of the formats. Plus what's the difference between "fail" and "not 
> displayed correctly"?
> 

"fail" means not display correctly but the issue can also lead to a weston crash.

> 
> > For the header patch, I will improve commit message.
> > 
> > I see there is an OVERRIDE libc-musl, should I use this patch in
> > SRC_URI_libc-musl?
> > 
> > 
> > No, just mention it on commit log...
> > 
> > 
> > 
> > Ross
> > 
> > -- 
> > 
> > Fabien
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > -- 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
-- 
Fabien