* [PATCH 1/3] packagegroup-core-sdk: Disable SANITIZERS for riscv64
@ 2018-03-09 11:00 Khem Raj
2018-03-09 11:00 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
2018-03-09 11:00 ` [PATCH 3/3] recipes: Disable lttng for riscv Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2018-03-09 11:00 UTC (permalink / raw)
To: openembedded-core
Dont build yet
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-core/packagegroups/packagegroup-core-sdk.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb b/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb
index 393f0d3d13..a137e7748f 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb
@@ -33,6 +33,7 @@ SANITIZERS_mipsarch = ""
SANITIZERS_nios2 = ""
SANITIZERS_powerpc64 = ""
SANITIZERS_sparc = ""
+SANITIZERS_riscv64 = ""
SANITIZERS_libc-musl = ""
RRECOMMENDS_packagegroup-core-sdk = "\
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] liburcu: Explicitly add pthread options to cflags
2018-03-09 11:00 [PATCH 1/3] packagegroup-core-sdk: Disable SANITIZERS for riscv64 Khem Raj
@ 2018-03-09 11:00 ` Khem Raj
2018-03-09 15:56 ` Richard Purdie
2018-03-09 11:00 ` [PATCH 3/3] recipes: Disable lttng for riscv Khem Raj
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2018-03-09 11:00 UTC (permalink / raw)
To: openembedded-core
Some architectures e.g. riscv gcc does not add -D_REENTRANT
when enabling pthreads. Help it here by adding these options
while gcc gets fixed
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-support/liburcu/liburcu_0.10.1.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-support/liburcu/liburcu_0.10.1.bb b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
index 0c8cd3571a..a73890af90 100644
--- a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
+++ b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
@@ -15,3 +15,5 @@ SRC_URI[sha256sum] = "9c09220be4435dc27fcd22d291707b94b97f159e0c442fbcd60c168f8f
S = "${WORKDIR}/userspace-rcu-${PV}"
inherit autotools
+
+CPPFLAGS += "-pthread -D_REENTRANT"
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] recipes: Disable lttng for riscv
2018-03-09 11:00 [PATCH 1/3] packagegroup-core-sdk: Disable SANITIZERS for riscv64 Khem Raj
2018-03-09 11:00 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
@ 2018-03-09 11:00 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2018-03-09 11:00 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb | 2 ++
meta/recipes-devtools/gdb/gdb-common.inc | 1 +
meta/recipes-kernel/lttng/lttng-tools_2.10.2.bb | 1 +
3 files changed, 4 insertions(+)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index e3814a44bc..554f529889 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -40,9 +40,11 @@ SYSTEMTAP_aarch64 = ""
# lttng-ust uses sched_getcpu() which is not there on for some platforms.
LTTNGUST = "lttng-ust"
LTTNGUST_libc-musl = ""
+LTTNGUST_riscv64 = ""
LTTNGTOOLS = "lttng-tools"
LTTNGTOOLS_libc-musl = ""
+LTTNGTOOLS_riscv64 = ""
LTTNGMODULES = "lttng-modules"
diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 9164a2bba4..039577b8e2 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -5,6 +5,7 @@ DEPENDS = "expat zlib ncurses virtual/libiconv ${LTTNGUST}"
LTTNGUST = "lttng-ust"
LTTNGUST_aarch64 = ""
+LTTNGUST_riscv64 = ""
LTTNGUST_mipsarch = ""
LTTNGUST_sh4 = ""
LTTNGUST_libc-musl = ""
diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.10.2.bb b/meta/recipes-kernel/lttng/lttng-tools_2.10.2.bb
index e8d041d1c6..fd5abbb113 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.10.2.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.10.2.bb
@@ -25,6 +25,7 @@ PACKAGECONFIG[lttng-ust] = "--with-lttng-ust, --without-lttng-ust, lttng-ust"
PACKAGECONFIG[kmod] = "--with-kmod, --without-kmod, kmod"
PACKAGECONFIG[manpages] = "--enable-man-pages, --disable-man-pages, asciidoc-native xmlto-native libxslt-native"
PACKAGECONFIG_remove_libc-musl = "lttng-ust"
+PACKAGECONFIG_remove_riscv64 = "lttng-ust"
SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
file://x32.patch \
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] liburcu: Explicitly add pthread options to cflags
2018-03-09 11:00 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
@ 2018-03-09 15:56 ` Richard Purdie
2018-03-09 16:24 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2018-03-09 15:56 UTC (permalink / raw)
To: Khem Raj, openembedded-core
On Fri, 2018-03-09 at 03:00 -0800, Khem Raj wrote:
> Some architectures e.g. riscv gcc does not add -D_REENTRANT
> when enabling pthreads. Help it here by adding these options
> while gcc gets fixed
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-support/liburcu/liburcu_0.10.1.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> index 0c8cd3571a..a73890af90 100644
> --- a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> +++ b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> @@ -15,3 +15,5 @@ SRC_URI[sha256sum] =
> "9c09220be4435dc27fcd22d291707b94b97f159e0c442fbcd60c168f8f
>
> S = "${WORKDIR}/userspace-rcu-${PV}"
> inherit autotools
> +
> +CPPFLAGS += "-pthread -D_REENTRANT"
Should we use a riscv override here so that we have some idea why we're
doing this and show its not needed for other arches?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] liburcu: Explicitly add pthread options to cflags
2018-03-09 15:56 ` Richard Purdie
@ 2018-03-09 16:24 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2018-03-09 16:24 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Fri, Mar 9, 2018 at 7:56 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2018-03-09 at 03:00 -0800, Khem Raj wrote:
>> Some architectures e.g. riscv gcc does not add -D_REENTRANT
>> when enabling pthreads. Help it here by adding these options
>> while gcc gets fixed
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-support/liburcu/liburcu_0.10.1.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
>> b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
>> index 0c8cd3571a..a73890af90 100644
>> --- a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
>> +++ b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
>> @@ -15,3 +15,5 @@ SRC_URI[sha256sum] =
>> "9c09220be4435dc27fcd22d291707b94b97f159e0c442fbcd60c168f8f
>>
>> S = "${WORKDIR}/userspace-rcu-${PV}"
>> inherit autotools
>> +
>> +CPPFLAGS += "-pthread -D_REENTRANT"
>
> Should we use a riscv override here so that we have some idea why we're
> doing this and show its not needed for other arches?
we could, its a difference in gcc specs for riscv, it seems a bug to me in gcc.
this change actually provides the options that configure tries to
otherwise guess.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] liburcu: Explicitly add pthread options to cflags
2018-03-09 20:28 [PATCH 0/3] Build fixed for riscv64 Khem Raj
@ 2018-03-09 20:29 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2018-03-09 20:29 UTC (permalink / raw)
To: openembedded-core
Some architectures e.g. riscv gcc does not add -D_REENTRANT
when enabling pthreads. Help it here by adding these options
while gcc gets fixed
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-support/liburcu/liburcu_0.10.1.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-support/liburcu/liburcu_0.10.1.bb b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
index 0c8cd3571a..459c04a7a1 100644
--- a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
+++ b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
@@ -15,3 +15,5 @@ SRC_URI[sha256sum] = "9c09220be4435dc27fcd22d291707b94b97f159e0c442fbcd60c168f8f
S = "${WORKDIR}/userspace-rcu-${PV}"
inherit autotools
+
+CPPFLAGS_append_riscv64 = " -pthread -D_REENTRANT"
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-09 20:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-09 11:00 [PATCH 1/3] packagegroup-core-sdk: Disable SANITIZERS for riscv64 Khem Raj
2018-03-09 11:00 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
2018-03-09 15:56 ` Richard Purdie
2018-03-09 16:24 ` Khem Raj
2018-03-09 11:00 ` [PATCH 3/3] recipes: Disable lttng for riscv Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2018-03-09 20:28 [PATCH 0/3] Build fixed for riscv64 Khem Raj
2018-03-09 20:29 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox