[PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS

[PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS

[Martin Jansa]

* add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8
  to build this, otherwise it fails with:
  ../git/gen-des-tables.c: In function 'write_table_u8':
  ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations are only allowed in C99 mode
     for (size_t i = 0; i < m; i++)
     ^

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
index b1982c1991..a1be4be7ef 100644
--- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
+++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
@@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* ${libdir}/libcrypt-*.so ${libdir}/libowc
 
 S = "${WORKDIR}/git"
 
-BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}"
+BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99"
 TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}"
 
 python () {
-- 
2.15.1

Re: [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS

[Khem Raj]

On 4/9/18 12:51 AM, Martin Jansa wrote:
> * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8
>   to build this, otherwise it fails with:
>   ../git/gen-des-tables.c: In function 'write_table_u8':
>   ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations are only allowed in C99 mode
>      for (size_t i = 0; i < m; i++)
>      ^
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> index b1982c1991..a1be4be7ef 100644
> --- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> +++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* ${libdir}/libcrypt-*.so ${libdir}/libowc
>  
>  S = "${WORKDIR}/git"
>  
> -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}"
> +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99"

This might change behaviour with gcc5+ e.g. where default is gnu11
in anycase, I think if we could limit this to native version can limit
the impact.

>  TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}"
>  
>  python () {
> 

Re: [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]

The anonymous python bellow this chunk limits this whole recipe only
for nativesdk (I don't know why it uses BBCLASSEXTEND + anonymous python
instead of just inheritting nativesdk directly from nativesdk-libxcrypt
recipe to make it more obvious ...).

On Mon, Apr 9, 2018 at 11:59 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On 4/9/18 12:51 AM, Martin Jansa wrote:
> > * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8
> >   to build this, otherwise it fails with:
> >   ../git/gen-des-tables.c: In function 'write_table_u8':
> >   ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations
> are only allowed in C99 mode
> >      for (size_t i = 0; i < m; i++)
> >      ^
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> > index b1982c1991..a1be4be7ef 100644
> > --- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> > +++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb
> > @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.*
> ${libdir}/libcrypt-*.so ${libdir}/libowc
> >
> >  S = "${WORKDIR}/git"
> >
> > -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}"
> > +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99"
>
> This might change behaviour with gcc5+ e.g. where default is gnu11
> in anycase, I think if we could limit this to native version can limit
> the impact.
>
> >  TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}"
> >
> >  python () {
> >
>
>

[-- Attachment #2: Type: text/html, Size: 2725 bytes --]