* [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS [not found] <CA+chaQeNd3F9oXBYFsj4YaxfJ+k3uvXDcdcHy-AP32MWaHT8aQ@mail.gmail.com> @ 2018-04-09 7:51 ` Martin Jansa 2018-04-09 21:59 ` Khem Raj 0 siblings, 1 reply; 3+ messages in thread From: Martin Jansa @ 2018-04-09 7:51 UTC (permalink / raw) To: openembedded-core * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8 to build this, otherwise it fails with: ../git/gen-des-tables.c: In function 'write_table_u8': ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations are only allowed in C99 mode for (size_t i = 0; i < m; i++) ^ Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb index b1982c1991..a1be4be7ef 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb +++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* ${libdir}/libcrypt-*.so ${libdir}/libowc S = "${WORKDIR}/git" -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99" TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}" python () { -- 2.15.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS 2018-04-09 7:51 ` [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS Martin Jansa @ 2018-04-09 21:59 ` Khem Raj 2018-04-09 22:03 ` Martin Jansa 0 siblings, 1 reply; 3+ messages in thread From: Khem Raj @ 2018-04-09 21:59 UTC (permalink / raw) To: Martin Jansa, openembedded-core On 4/9/18 12:51 AM, Martin Jansa wrote: > * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8 > to build this, otherwise it fails with: > ../git/gen-des-tables.c: In function 'write_table_u8': > ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations are only allowed in C99 mode > for (size_t i = 0; i < m; i++) > ^ > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > --- > meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > index b1982c1991..a1be4be7ef 100644 > --- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > +++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* ${libdir}/libcrypt-*.so ${libdir}/libowc > > S = "${WORKDIR}/git" > > -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" > +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99" This might change behaviour with gcc5+ e.g. where default is gnu11 in anycase, I think if we could limit this to native version can limit the impact. > TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}" > > python () { > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS 2018-04-09 21:59 ` Khem Raj @ 2018-04-09 22:03 ` Martin Jansa 0 siblings, 0 replies; 3+ messages in thread From: Martin Jansa @ 2018-04-09 22:03 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 1702 bytes --] The anonymous python bellow this chunk limits this whole recipe only for nativesdk (I don't know why it uses BBCLASSEXTEND + anonymous python instead of just inheritting nativesdk directly from nativesdk-libxcrypt recipe to make it more obvious ...). On Mon, Apr 9, 2018 at 11:59 PM, Khem Raj <raj.khem@gmail.com> wrote: > On 4/9/18 12:51 AM, Martin Jansa wrote: > > * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8 > > to build this, otherwise it fails with: > > ../git/gen-des-tables.c: In function 'write_table_u8': > > ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations > are only allowed in C99 mode > > for (size_t i = 0; i < m; i++) > > ^ > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > --- > > meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > > index b1982c1991..a1be4be7ef 100644 > > --- a/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > > +++ b/meta/recipes-core/libxcrypt/libxcrypt_4.0.0.bb > > @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* > ${libdir}/libcrypt-*.so ${libdir}/libowc > > > > S = "${WORKDIR}/git" > > > > -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" > > +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99" > > This might change behaviour with gcc5+ e.g. where default is gnu11 > in anycase, I think if we could limit this to native version can limit > the impact. > > > TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}" > > > > python () { > > > > [-- Attachment #2: Type: text/html, Size: 2725 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-09 22:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CA+chaQeNd3F9oXBYFsj4YaxfJ+k3uvXDcdcHy-AP32MWaHT8aQ@mail.gmail.com>
2018-04-09 7:51 ` [PATCH] libxcrypt: add -std=gnu99 to BUILD_CPPFLAGS Martin Jansa
2018-04-09 21:59 ` Khem Raj
2018-04-09 22:03 ` Martin Jansa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox