Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] `NameError` is currently thrown in create_npm.py
@ 2018-04-26  0:11 sarah.marsh.engineer
  2018-04-26  0:32 ` ✗ patchtest: failure for " Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: sarah.marsh.engineer @ 2018-04-26  0:11 UTC (permalink / raw)
  To: openembedded-core; +Cc: Sarah Marsh

From: Sarah Marsh <sarah.marsh.engineer@gmail.com>

This happens if an optional npm dependency does not support Linux.

Signed-off-by: Sarah Marsh <sarah.marsh.engineer@gmail.com>
---
 scripts/lib/recipetool/create_npm.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/lib/recipetool/create_npm.py b/scripts/lib/recipetool/create_npm.py
index fb57e705f2..bb42a5ca5c 100644
--- a/scripts/lib/recipetool/create_npm.py
+++ b/scripts/lib/recipetool/create_npm.py
@@ -320,6 +320,7 @@ class NpmRecipeHandler(RecipeHandler):
                     blacklist = True
                     break
             if (not blacklist and 'linux' not in pkg_os) or '!linux' in pkg_os:
+                pkg = pdata.get('name', 'Unnamed package')
                 logger.debug(2, "Skipping %s since it's incompatible with Linux" % pkg)
                 return False
         return True
-- 
2.14.3 (Apple Git-98)



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* ✗ patchtest: failure for `NameError` is currently thrown in create_npm.py
  2018-04-26  0:11 [PATCH] `NameError` is currently thrown in create_npm.py sarah.marsh.engineer
@ 2018-04-26  0:32 ` Patchwork
  0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2018-04-26  0:32 UTC (permalink / raw)
  To: sarah.marsh.engineer; +Cc: openembedded-core

== Series Details ==

Series: `NameError` is currently thrown in create_npm.py
Revision: 1
URL   : https://patchwork.openembedded.org/series/11926/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            `NameError` is currently thrown in create_npm.py
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26  0:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-26  0:11 [PATCH] `NameError` is currently thrown in create_npm.py sarah.marsh.engineer
2018-04-26  0:32 ` ✗ patchtest: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox