[PATCH] autotools.bbclass: output failed config.log

[PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

If do_configure failed, output content of config.log
to configure log, it is helpful to trace the do_configure
failure on the build system which is hard to login.
(such as autobuilder)

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/classes/autotools.bbclass | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 8768a6a..03cbe1b 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -90,7 +90,11 @@ oe_runconf () {
 		bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
 		if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
 			bbnote "The following config.log files may provide further information."
-			bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
+			config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
+			bbnote "$config_log"
+			[ -e "$config_log" ] && cat "$config_log" | while read line; do
+				bbnote "$line"
+			done
 			bbfatal_log "configure failed"
 		fi
 	else
-- 
2.7.4

Re: [PATCH] autotools.bbclass: output failed config.log

[Andreas Müller]

On Wed, May 15, 2019 at 11:23 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> If do_configure failed, output content of config.log
> to configure log, it is helpful to trace the do_configure
> failure on the build system which is hard to login.
> (such as autobuilder)
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/classes/autotools.bbclass | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> index 8768a6a..03cbe1b 100644
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -90,7 +90,11 @@ oe_runconf () {
>                 bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
>                 if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
>                         bbnote "The following config.log files may provide further information."
> -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
> +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
> +                       bbnote "$config_log"
> +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
> +                               bbnote "$line"
> +                       done
>                         bbfatal_log "configure failed"
>                 fi
>         else
> --
> 2.7.4
>
That output is useful only sometimes and extremly verbose. I'd suggest
to introduce a switch to enable/disable (even as newbie user I am able
to find config.log). How about making autobuilder's WORKDIR
accessible?

Andreas

Re: [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

[-- Attachment #1: Type: text/plain, Size: 1657 bytes --]

On 5/15/19 5:32 PM, Andreas Müller wrote:
>> --- a/meta/classes/autotools.bbclass
>> +++ b/meta/classes/autotools.bbclass
>> @@ -90,7 +90,11 @@ oe_runconf () {
>>                  bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
>>                  if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
>>                          bbnote "The following config.log files may provide further information."
>> -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
>> +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
>> +                       bbnote "$config_log"
>> +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
>> +                               bbnote "$line"
>> +                       done
>>                          bbfatal_log "configure failed"
>>                  fi
>>          else
>> --
>> 2.7.4
>>
> That output is useful only sometimes and extremly verbose. I'd suggest
> to introduce a switch to enable/disable (even as newbie user I am able
> to find config.log). How about making autobuilder's WORKDIR
> accessible?

The output only happens while do_configure failure, it does nothing when 
build succeed,

while failure occurs, I believe related message is the more the better.

The autobuilder is just an example, for community development, it is 
hard to login

others build host to debug issue, and we have to take time to reproduce it

if we could trace it with a simple glance from the log, why not


//Hongxu


> Andreas



[-- Attachment #2: Type: text/html, Size: 2478 bytes --]

Re: [PATCH] autotools.bbclass: output failed config.log

[Andreas Müller]

On Wed, May 15, 2019 at 11:50 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> On 5/15/19 5:32 PM, Andreas Müller wrote:
>
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -90,7 +90,11 @@ oe_runconf () {
>                 bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
>                 if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
>                         bbnote "The following config.log files may provide further information."
> -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
> +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
> +                       bbnote "$config_log"
> +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
> +                               bbnote "$line"
> +                       done
>                         bbfatal_log "configure failed"
>                 fi
>         else
> --
> 2.7.4
>
> That output is useful only sometimes and extremly verbose. I'd suggest
> to introduce a switch to enable/disable (even as newbie user I am able
> to find config.log). How about making autobuilder's WORKDIR
> accessible?
>
> The output only happens while do_configure failure, it does nothing when build succeed,
>
> while failure occurs, I believe related message is the more the better.
>
> The autobuilder is just an example, for community development, it is hard to login
>
> others build host to debug issue, and we have to take time to reproduce it
>
> if we could trace it with a simple glance from the log, why not
>
Errors are common at recipe creation. I am asking for a knob to
prevent me from scrolling through endless wallpapers (confg.logs can
be >> 100K) to find simple errors.

And it just works around an autobuilder hiding useful information,

My 2ct

Andreas

Re: [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 6:54 PM, Andreas Müller wrote:
> On Wed, May 15, 2019 at 11:50 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> On 5/15/19 5:32 PM, Andreas Müller wrote:
>>
>> --- a/meta/classes/autotools.bbclass
>> +++ b/meta/classes/autotools.bbclass
>> @@ -90,7 +90,11 @@ oe_runconf () {
>>                  bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
>>                  if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
>>                          bbnote "The following config.log files may provide further information."
>> -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
>> +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
>> +                       bbnote "$config_log"
>> +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
>> +                               bbnote "$line"
>> +                       done
>>                          bbfatal_log "configure failed"
>>                  fi
>>          else
>> --
>> 2.7.4
>>
>> That output is useful only sometimes and extremly verbose. I'd suggest
>> to introduce a switch to enable/disable (even as newbie user I am able
>> to find config.log). How about making autobuilder's WORKDIR
>> accessible?
>>
>> The output only happens while do_configure failure, it does nothing when build succeed,
>>
>> while failure occurs, I believe related message is the more the better.
>>
>> The autobuilder is just an example, for community development, it is hard to login
>>
>> others build host to debug issue, and we have to take time to reproduce it
>>
>> if we could trace it with a simple glance from the log, why not
>>
> Errors are common at recipe creation. I am asking for a knob to
> prevent me from scrolling through endless wallpapers (confg.logs can
> be >> 100K) to find simple errors.

I think a knob does make sense, I will add it in V2

//Hongxu

> And it just works around an autobuilder hiding useful information,
>
> My 2ct
>
> Andreas

Re: [PATCH] autotools.bbclass: output failed config.log

[Adrian Bunk]

On Wed, May 15, 2019 at 05:50:44PM +0800, Hongxu Jia wrote:
> On 5/15/19 5:32 PM, Andreas Müller wrote:
> > > --- a/meta/classes/autotools.bbclass
> > > +++ b/meta/classes/autotools.bbclass
> > > @@ -90,7 +90,11 @@ oe_runconf () {
> > >                  bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
> > >                  if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
> > >                          bbnote "The following config.log files may provide further information."
> > > -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
> > > +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
> > > +                       bbnote "$config_log"
> > > +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
> > > +                               bbnote "$line"
> > > +                       done
> > >                          bbfatal_log "configure failed"
> > >                  fi
> > >          else
> > > --
> > > 2.7.4
> > > 
> > That output is useful only sometimes and extremly verbose. I'd suggest
> > to introduce a switch to enable/disable (even as newbie user I am able
> > to find config.log). How about making autobuilder's WORKDIR
> > accessible?
> 
> The output only happens while do_configure failure, it does nothing when
> build succeed,
> 
> while failure occurs, I believe related message is the more the better.
> 
> The autobuilder is just an example, for community development, it is hard to
> login
> 
> others build host to debug issue, and we have to take time to reproduce it
> 
> if we could trace it with a simple glance from the log, why not

The end of config.log often contains expected error messages completely 
unrelated to the actual problem.

Debian autobuilders already dump config.log when when configuring failed,
and there it is a common problem that people end up searching for the 
problem in the wrong places due to that.

If possible, it would therefore be better to make it accessible separately.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 7:08 PM, Adrian Bunk wrote:
> The end of config.log often contains expected error messages completely
> unrelated to the actual problem.

I am afraid you did not suffer pain from it, the most related message

with do_configure failure is config.log. Take a example, as my previous

commit [grub/grub-efi: fix unrecognized command line option

'-pipe-Wno-error' in CFLAGS]

It takes me hours to reproduce grub/grub-efi build faiure (only

happen while DEBUG_BUILD = "1"), and from log.do_configure, I can't

tell the root cause

...

checking for i586-wrs-linux-gcc... i586-wrs-linux-gcc  -m32 -march=i586 
--sysroot=TOPDIR/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot
checking whether the C compiler works... no
configure: error: in 
`TOPDIR/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build':
configure: error: C compiler cannot create executables

...


But from config.log, I got more detail '-pipe-Wno-error'

which helps me to locate the issue

...

configure:5094: i586-wrs-linux-gcc  -m32 -march=i586 
--sysroot=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot 
-Og -g -feliminate-unused-debug-types 
-fmacro-prefix-map=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0=/usr/src/debug/grub/2.02-r0 
-fdebug-prefix-map=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0=/usr/src/debug/grub/2.02-r0 
-fdebug-prefix-map=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot= 
-fdebug-prefix-map=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot-native= 
-pipe-Wno-error  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed 
-fstack-protector-strong -Wl,-z,relro,-z,now conftest.c >&5
i586-wrs-linux-gcc: error: unrecognized command line option 
'-pipe-Wno-error'; did you mean '-Wno-error'?
...
configure:5141: error: in 
`/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build':
configure:5143: error: C compiler cannot create executables

...


> Debian autobuilders already dump config.log when when configuring failed,
> and there it is a common problem that people end up searching for the
> problem in the wrong places due to that.

It's another story, it is better that autobuilder provide sufficient and

necessary info and data, not only config.log, but also local.conf,

all available log.do_***, sources in ${B} and ${S}, even data in ${WORKDIR},

result of `bitbake -e'

but before we got there, the fix is best choice for do_configure failure

//Hongxu

i

//Hongxu

> If possible, it would therefore be better to make it accessible separately.

Re: [PATCH] autotools.bbclass: output failed config.log

[Adrian Bunk]

On Wed, May 15, 2019 at 08:30:03PM +0800, Hongxu Jia wrote:
> On 5/15/19 7:08 PM, Adrian Bunk wrote:
> > The end of config.log often contains expected error messages completely
> > unrelated to the actual problem.
> 
> I am afraid you did not suffer pain from it, the most related message
> 
> with do_configure failure is config.log. Take a example, as my previous
> 
> commit [grub/grub-efi: fix unrecognized command line option
> 
> '-pipe-Wno-error' in CFLAGS]
> 
> It takes me hours to reproduce grub/grub-efi build faiure (only
>...

I fully understand your pain, and have already suffered it many times.

> > Debian autobuilders already dump config.log when when configuring failed,
> > and there it is a common problem that people end up searching for the
> > problem in the wrong places due to that.
> 
> It's another story, it is better that autobuilder provide sufficient and
> 
> necessary info and data, not only config.log, but also local.conf,
> 
> all available log.do_***, sources in ${B} and ${S}, even data in ${WORKDIR},
> 
> result of `bitbake -e'
> 
> but before we got there, the fix is best choice for do_configure failure

There is no universal best choice here.

Let me give you an example when building a more recent ofono locally 
with and without your patch.

When a configure task fails, the last lines from log.do_configure
are dumped to the shell.

Without your patch I get when building in a shell:
...
| checking whether to build shared libraries... yes
| checking whether to build static libraries... no
| checking for signalfd... yes
| checking for dlopen in -ldl... yes
| checking for glib-2.0 >= 2.32... yes
| checking for dbus-1 >= 1.4... yes
| checking for libudev >= 143... yes
| checking for mobile-broadband-provider-info... yes
| checking for ell >= 0.12... no
| configure: error: Embedded Linux library >= 0.12 is required
...

The problem is immediately visible.

With your patch, one has to scroll up through the whole config.log for 
getting this information.

And the config.log contains plenty of other (expected) errors a user 
might mistake as cause of the problem.

For autobuilders dumping config.log can be OK if there is no better 
option available, but people looking at autobuilder logs should be
aware what to scroll over when starting to look at the log.

For anyone building manually in a shell these should really not be done,
it has a high potential of confuding the user and the config.log is 
easily available.

The best available option might be to have a knob with default off,
and autobuilders might be configured to dump config.log.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 9:42 PM, Adrian Bunk wrote:
> On Wed, May 15, 2019 at 08:30:03PM +0800, Hongxu Jia wrote:
>> On 5/15/19 7:08 PM, Adrian Bunk wrote:
>>> The end of config.log often contains expected error messages completely
>>> unrelated to the actual problem.
>> I am afraid you did not suffer pain from it, the most related message
>>
>> with do_configure failure is config.log. Take a example, as my previous
>>
>> commit [grub/grub-efi: fix unrecognized command line option
>>
>> '-pipe-Wno-error' in CFLAGS]
>>
>> It takes me hours to reproduce grub/grub-efi build faiure (only
>> ...
> I fully understand your pain, and have already suffered it many times.
>
>>> Debian autobuilders already dump config.log when when configuring failed,
>>> and there it is a common problem that people end up searching for the
>>> problem in the wrong places due to that.
>> It's another story, it is better that autobuilder provide sufficient and
>>
>> necessary info and data, not only config.log, but also local.conf,
>>
>> all available log.do_***, sources in ${B} and ${S}, even data in ${WORKDIR},
>>
>> result of `bitbake -e'
>>
>> but before we got there, the fix is best choice for do_configure failure
> There is no universal best choice here.
>
> Let me give you an example when building a more recent ofono locally
> with and without your patch.
>
> When a configure task fails, the last lines from log.do_configure
> are dumped to the shell.
>
> Without your patch I get when building in a shell:
> ...
> | checking whether to build shared libraries... yes
> | checking whether to build static libraries... no
> | checking for signalfd... yes
> | checking for dlopen in -ldl... yes
> | checking for glib-2.0 >= 2.32... yes
> | checking for dbus-1 >= 1.4... yes
> | checking for libudev >= 143... yes
> | checking for mobile-broadband-provider-info... yes
> | checking for ell >= 0.12... no
> | configure: error: Embedded Linux library >= 0.12 is required
> ...
>
> The problem is immediately visible.
>
> With your patch, one has to scroll up through the whole config.log for
> getting this information.
>
> And the config.log contains plenty of other (expected) errors a user
> might mistake as cause of the problem.
>
> For autobuilders dumping config.log can be OK if there is no better
> option available, but people looking at autobuilder logs should be
> aware what to scroll over when starting to look at the log.
>
> For anyone building manually in a shell these should really not be done,
> it has a high potential of confuding the user and the config.log is
> easily available.
>
> The best available option might be to have a knob with default off,
> and autobuilders might be configured to dump config.log.

After applying my fix, here is the sample

...

checking for i586-wrs-linux-gcc... i586-wrs-linux-gcc  -m32 -march=i586 
--sysroot=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot
checking whether the C compiler works... no
configure: error: in 
`/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build':
configure: error: C compiler cannot create executables
See `config.log' for more details
NOTE: The following config.log files may provide further information.
NOTE: 
/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build/config.log
NOTE: This file contains any messages produced by compilers while
NOTE: running configure, to aid debugging if configure makes a mistake.

...

The content of config.log has prefix `NOTE:' and also tells user

See `config.log' for more dettails and balabala

//Hongxu

>> //Hongxu
> cu
> Adrian
>

Re: [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 9:50 PM, Hongxu Jia wrote:
>
> The best available option might be to have a knob with default off,
> and autobuilders might be configured to dump config.log. 

See my V2 for detail

//Hongxu

Re: [PATCH] autotools.bbclass: output failed config.log

[Adrian Bunk]

On Wed, May 15, 2019 at 09:50:35PM +0800, Hongxu Jia wrote:
> 
> After applying my fix, here is the sample
> 
> ...
> 
> checking for i586-wrs-linux-gcc... i586-wrs-linux-gcc  -m32 -march=i586 --sysroot=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot
> checking whether the C compiler works... no
> configure: error: in `/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
> NOTE: The following config.log files may provide further information.
> NOTE: /buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build/config.log
> NOTE: This file contains any messages produced by compilers while
> NOTE: running configure, to aid debugging if configure makes a mistake.
> 
> ...
> 
> The content of config.log has prefix `NOTE:' and also tells user
>...

The problem is that the last > 1000 lines are NOTE: - and they all get 
dumped to the terminal.

It is a problem when you have to scroll up through more than a thousand 
lines of mostly irrelvant information before you are seeing the most 
relevant information.

> //Hongxu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] autotools.bbclass: output failed config.log

[Khem Raj]

On 5/15/19 7:02 AM, Adrian Bunk wrote:
> On Wed, May 15, 2019 at 09:50:35PM +0800, Hongxu Jia wrote:
>>
>> After applying my fix, here is the sample
>>
>> ...
>>
>> checking for i586-wrs-linux-gcc... i586-wrs-linux-gcc  -m32 -march=i586 --sysroot=/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/recipe-sysroot
>> checking whether the C compiler works... no
>> configure: error: in `/buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build':
>> configure: error: C compiler cannot create executables
>> See `config.log' for more details
>> NOTE: The following config.log files may provide further information.
>> NOTE: /buildarea1/hjia/wrlinux-1019/build_master-wr_qemux86_2019051509/build/tmp-glibc/work/i586-wrs-linux/grub/2.02-r0/build/config.log
>> NOTE: This file contains any messages produced by compilers while
>> NOTE: running configure, to aid debugging if configure makes a mistake.
>>
>> ...
>>
>> The content of config.log has prefix `NOTE:' and also tells user
>> ...
> 
> The problem is that the last > 1000 lines are NOTE: - and they all get
> dumped to the terminal.
> 
> It is a problem when you have to scroll up through more than a thousand
> lines of mostly irrelvant information before you are seeing the most
> relevant information.
> 


It would be good to extract relevant information from config.log and 
dump that instead of verbose concatenation of the whole file.

Are there any markers we can use  ?

>> //Hongxu
> 
> cu
> Adrian
> 

[PATCH V2] autotools.bbclass: output failed config.log

[Hongxu Jia]

If do_configure failed, output content of config.log
to configure log, it is helpful to trace the do_configure
failure on the build system which is hard to login.
(such as autobuilder)

Add a knob OUTPUT_CONFIG_LOG to control config.log output

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/classes/autotools.bbclass | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 8768a6a..5fc9d0a 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -82,6 +82,7 @@ CONFIGURE_SCRIPT ?= "${AUTOTOOLS_SCRIPT_PATH}/configure"
 
 AUTOTOOLS_AUXDIR ?= "${AUTOTOOLS_SCRIPT_PATH}"
 
+OUTPUT_CONFIG_LOG ??= ""
 oe_runconf () {
 	# Use relative path to avoid buildpaths in files
 	cfgscript_name="`basename ${CONFIGURE_SCRIPT}`"
@@ -90,7 +91,11 @@ oe_runconf () {
 		bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
 		if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
 			bbnote "The following config.log files may provide further information."
-			bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
+			config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
+			bbnote "$config_log"
+			[ -n "${OUTPUT_CONFIG_LOG}" ] && [ -e "$config_log" ] && while read line; do
+				bbnote "$line"
+			done <"$config_log"
 			bbfatal_log "configure failed"
 		fi
 	else
-- 
2.7.4

Re: [PATCH V2] autotools.bbclass: output failed config.log

[richard.purdie]

On Wed, 2019-05-15 at 21:32 +0800, Hongxu Jia wrote:
> If do_configure failed, output content of config.log
> to configure log, it is helpful to trace the do_configure
> failure on the build system which is hard to login.
> (such as autobuilder)
> 
> Add a knob OUTPUT_CONFIG_LOG to control config.log output
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/classes/autotools.bbclass | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
We did used to do this, it was removed:

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/autotools.bbclass?id=ba837f10555998a8677eb99bfc6698e0cc1f7942

Cheers,

Richard

Re: [PATCH V2] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 10:01 PM, richard.purdie@linuxfoundation.org wrote:
> On Wed, 2019-05-15 at 21:32 +0800, Hongxu Jia wrote:
>> If do_configure failed, output content of config.log
>> to configure log, it is helpful to trace the do_configure
>> failure on the build system which is hard to login.
>> (such as autobuilder)
>>
>> Add a knob OUTPUT_CONFIG_LOG to control config.log output
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta/classes/autotools.bbclass | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
> We did used to do this, it was removed:
>
> http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/autotools.bbclass?id=ba837f10555998a8677eb99bfc6698e0cc1f7942

OK, I got it

//Hongxu

> Cheers,
>
> Richard
>