* [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON @ 2020-02-19 2:36 Anuj Mittal 2020-02-19 2:39 ` Khem Raj 0 siblings, 1 reply; 6+ messages in thread From: Anuj Mittal @ 2020-02-19 2:36 UTC (permalink / raw) To: openembedded-core Use the correct variable so options actually get used and use the correct qt option name to prevent errors. Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> --- .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb index a6eb9986dd..07a0bf5085 100644 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" # This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig # in a gstreamer1.0-plugins-good bbappend). -EXTRA_OECONF += " \ +EXTRA_OEMESON += " \ -Daalib=disabled \ -Ddirectsound=disabled \ -Ddv=disabled \ @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ -Doss4=disabled \ -Dosxaudio=disabled \ -Dosxvideo=disabled \ - -Dqt=disabled \ + -Dqt5=disabled \ -Dshout2=disabled \ -Dtwolame=disabled \ -Dwaveform=disabled \ -- 2.24.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON 2020-02-19 2:36 [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON Anuj Mittal @ 2020-02-19 2:39 ` Khem Raj 2020-02-19 2:43 ` Mittal, Anuj 0 siblings, 1 reply; 6+ messages in thread From: Khem Raj @ 2020-02-19 2:39 UTC (permalink / raw) To: Anuj Mittal; +Cc: Patches and discussions about the oe-core layer On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal <anuj.mittal@intel.com> wrote: > > Use the correct variable so options actually get used and use the > correct qt option name to prevent errors. > > Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> > --- > .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb > index a6eb9986dd..07a0bf5085 100644 > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb > @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" > # This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig > # in a gstreamer1.0-plugins-good bbappend). > > -EXTRA_OECONF += " \ > +EXTRA_OEMESON += " \ > -Daalib=disabled \ > -Ddirectsound=disabled \ > -Ddv=disabled \ > @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ > -Doss4=disabled \ > -Dosxaudio=disabled \ > -Dosxvideo=disabled \ > - -Dqt=disabled \ > + -Dqt5=disabled \ this perhaps should be a packageconfig so people using meta-qt5 can enable it > -Dshout2=disabled \ > -Dtwolame=disabled \ > -Dwaveform=disabled \ > -- > 2.24.1 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON 2020-02-19 2:39 ` Khem Raj @ 2020-02-19 2:43 ` Mittal, Anuj 2020-02-19 2:55 ` Khem Raj 0 siblings, 1 reply; 6+ messages in thread From: Mittal, Anuj @ 2020-02-19 2:43 UTC (permalink / raw) To: raj.khem@gmail.com; +Cc: openembedded-core@lists.openembedded.org On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote: > On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal <anuj.mittal@intel.com> > wrote: > > Use the correct variable so options actually get used and use the > > correct qt option name to prevent errors. > > > > Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> > > --- > > .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb | 4 > > ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0- > > plugins-good_1.16.1.bb b/meta/recipes- > > multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb > > index a6eb9986dd..07a0bf5085 100644 > > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > > good_1.16.1.bb > > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > > good_1.16.1.bb > > @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = > > "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" > > # This is better done in a separate qt5 layer (which then should > > add a "qt5" packageconfig > > # in a gstreamer1.0-plugins-good bbappend). > > > > -EXTRA_OECONF += " \ > > +EXTRA_OEMESON += " \ > > -Daalib=disabled \ > > -Ddirectsound=disabled \ > > -Ddv=disabled \ > > @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ > > -Doss4=disabled \ > > -Dosxaudio=disabled \ > > -Dosxvideo=disabled \ > > - -Dqt=disabled \ > > + -Dqt5=disabled \ > > this perhaps should be a packageconfig so people using meta-qt5 can > enable it Yes probably but in a separate change I think. This just ensures that the right options are used and nothing else is changed. Thanks, Anuj > > > -Dshout2=disabled \ > > -Dtwolame=disabled \ > > -Dwaveform=disabled \ > > -- > > 2.24.1 > > > > -- > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON 2020-02-19 2:43 ` Mittal, Anuj @ 2020-02-19 2:55 ` Khem Raj 2020-02-19 3:04 ` Mittal, Anuj 0 siblings, 1 reply; 6+ messages in thread From: Khem Raj @ 2020-02-19 2:55 UTC (permalink / raw) To: Mittal, Anuj; +Cc: openembedded-core@lists.openembedded.org On 2/18/20 6:43 PM, Mittal, Anuj wrote: > On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote: >> On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal <anuj.mittal@intel.com> >> wrote: >>> Use the correct variable so options actually get used and use the >>> correct qt option name to prevent errors. >>> >>> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> >>> --- >>> .../gstreamer/gstreamer1.0-plugins-good_1.16.1.bb | 4 >>> ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0- >>> plugins-good_1.16.1.bb b/meta/recipes- >>> multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb >>> index a6eb9986dd..07a0bf5085 100644 >>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- >>> good_1.16.1.bb >>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- >>> good_1.16.1.bb >>> @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = >>> "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" >>> # This is better done in a separate qt5 layer (which then should >>> add a "qt5" packageconfig >>> # in a gstreamer1.0-plugins-good bbappend). >>> >>> -EXTRA_OECONF += " \ >>> +EXTRA_OEMESON += " \ >>> -Daalib=disabled \ >>> -Ddirectsound=disabled \ >>> -Ddv=disabled \ >>> @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ >>> -Doss4=disabled \ >>> -Dosxaudio=disabled \ >>> -Dosxvideo=disabled \ >>> - -Dqt=disabled \ >>> + -Dqt5=disabled \ >> this perhaps should be a packageconfig so people using meta-qt5 can >> enable it > Yes probably but in a separate change I think. This just ensures that > the right options are used and nothing else is changed. perhaps no, since it will regress meta-qt5 which already does something like this https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend this being wrong in OE-core was ok for meta-qt5. > > Thanks, > > Anuj > >>> -Dshout2=disabled \ >>> -Dtwolame=disabled \ >>> -Dwaveform=disabled \ >>> -- >>> 2.24.1 >>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON 2020-02-19 2:55 ` Khem Raj @ 2020-02-19 3:04 ` Mittal, Anuj 2020-02-19 3:35 ` Khem Raj 0 siblings, 1 reply; 6+ messages in thread From: Mittal, Anuj @ 2020-02-19 3:04 UTC (permalink / raw) To: raj.khem@gmail.com; +Cc: openembedded-core@lists.openembedded.org On Tue, 2020-02-18 at 18:55 -0800, Khem Raj wrote: > On 2/18/20 6:43 PM, Mittal, Anuj wrote: > > On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote: > > > On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal < > > > anuj.mittal@intel.com> > > > wrote: > > > > Use the correct variable so options actually get used and use > > > > the > > > > correct qt option name to prevent errors. > > > > > > > > Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> > > > > --- > > > > .../gstreamer/gstreamer1.0-plugins- > > > > good_1.16.1.bb | 4 > > > > ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0- > > > > plugins-good_1.16.1.bb b/meta/recipes- > > > > multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb > > > > index a6eb9986dd..07a0bf5085 100644 > > > > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > > > > good_1.16.1.bb > > > > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- > > > > good_1.16.1.bb > > > > @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = > > > > "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" > > > > # This is better done in a separate qt5 layer (which then > > > > should > > > > add a "qt5" packageconfig > > > > # in a gstreamer1.0-plugins-good bbappend). > > > > > > > > -EXTRA_OECONF += " \ > > > > +EXTRA_OEMESON += " \ > > > > -Daalib=disabled \ > > > > -Ddirectsound=disabled \ > > > > -Ddv=disabled \ > > > > @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ > > > > -Doss4=disabled \ > > > > -Dosxaudio=disabled \ > > > > -Dosxvideo=disabled \ > > > > - -Dqt=disabled \ > > > > + -Dqt5=disabled \ > > > this perhaps should be a packageconfig so people using meta-qt5 > > > can > > > enable it > > Yes probably but in a separate change I think. This just ensures > > that > > the right options are used and nothing else is changed. > > perhaps no, since it will regress meta-qt5 which already does > something > like this > > https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend > > > this being wrong in OE-core was ok for meta-qt5. Okay, should that PACKAGECONFIG be added here? I don't use or test qt so can't test the change. Thanks, Anuj ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON 2020-02-19 3:04 ` Mittal, Anuj @ 2020-02-19 3:35 ` Khem Raj 0 siblings, 0 replies; 6+ messages in thread From: Khem Raj @ 2020-02-19 3:35 UTC (permalink / raw) To: Mittal, Anuj; +Cc: openembedded-core@lists.openembedded.org On 2/18/20 7:04 PM, Mittal, Anuj wrote: > On Tue, 2020-02-18 at 18:55 -0800, Khem Raj wrote: >> On 2/18/20 6:43 PM, Mittal, Anuj wrote: >>> On Tue, 2020-02-18 at 18:39 -0800, Khem Raj wrote: >>>> On Tue, Feb 18, 2020 at 6:37 PM Anuj Mittal < >>>> anuj.mittal@intel.com> >>>> wrote: >>>>> Use the correct variable so options actually get used and use >>>>> the >>>>> correct qt option name to prevent errors. >>>>> >>>>> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> >>>>> --- >>>>> .../gstreamer/gstreamer1.0-plugins- >>>>> good_1.16.1.bb | 4 >>>>> ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0- >>>>> plugins-good_1.16.1.bb b/meta/recipes- >>>>> multimedia/gstreamer/gstreamer1.0-plugins-good_1.16.1.bb >>>>> index a6eb9986dd..07a0bf5085 100644 >>>>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- >>>>> good_1.16.1.bb >>>>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- >>>>> good_1.16.1.bb >>>>> @@ -55,7 +55,7 @@ PACKAGECONFIG[x11] = >>>>> "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}" >>>>> # This is better done in a separate qt5 layer (which then >>>>> should >>>>> add a "qt5" packageconfig >>>>> # in a gstreamer1.0-plugins-good bbappend). >>>>> >>>>> -EXTRA_OECONF += " \ >>>>> +EXTRA_OEMESON += " \ >>>>> -Daalib=disabled \ >>>>> -Ddirectsound=disabled \ >>>>> -Ddv=disabled \ >>>>> @@ -64,7 +64,7 @@ EXTRA_OECONF += " \ >>>>> -Doss4=disabled \ >>>>> -Dosxaudio=disabled \ >>>>> -Dosxvideo=disabled \ >>>>> - -Dqt=disabled \ >>>>> + -Dqt5=disabled \ >>>> this perhaps should be a packageconfig so people using meta-qt5 >>>> can >>>> enable it >>> Yes probably but in a separate change I think. This just ensures >>> that >>> the right options are used and nothing else is changed. >> >> perhaps no, since it will regress meta-qt5 which already does >> something >> like this >> >> https://github.com/meta-qt5/meta-qt5/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_%25.bbappend >> >> >> this being wrong in OE-core was ok for meta-qt5. > > Okay, should that PACKAGECONFIG be added here? I don't use or test qt > so can't test the change. thats fine, add it as a PACKAGECONFIG as done in bbappend and then we can eventually stop defining it from meta-qt5 > > Thanks, > > Anuj > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-19 3:35 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-19 2:36 [PATCH v2] gstreamer1.0-plugins-good: change EXTRA_OECONF -> EXTRA_OEMESON Anuj Mittal 2020-02-19 2:39 ` Khem Raj 2020-02-19 2:43 ` Mittal, Anuj 2020-02-19 2:55 ` Khem Raj 2020-02-19 3:04 ` Mittal, Anuj 2020-02-19 3:35 ` Khem Raj
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox