[PATCH] vim: add nativesdk to BBCLASSEXTEND

[PATCH] vim: add nativesdk to BBCLASSEXTEND

[Nathan Rossi]

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
 meta/recipes-support/vim/vim_8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
index 709b6ddb55..7e4654e472 100644
--- a/meta/recipes-support/vim/vim_8.2.bb
+++ b/meta/recipes-support/vim/vim_8.2.bb
@@ -3,7 +3,7 @@ require vim.inc
 PROVIDES = "xxd"
 
 PACKAGECONFIG_class-native = ""
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
---
2.28.0

Re: [OE-core] [PATCH] vim: add nativesdk to BBCLASSEXTEND

[Ahmad Fatoum]

Hello Nathan,

On 11/4/20 2:17 PM, Nathan Rossi wrote:
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
>  meta/recipes-support/vim/vim_8.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
> index 709b6ddb55..7e4654e472 100644
> --- a/meta/recipes-support/vim/vim_8.2.bb
> +++ b/meta/recipes-support/vim/vim_8.2.bb
> @@ -3,7 +3,7 @@ require vim.inc
>  PROVIDES = "xxd"
>  
>  PACKAGECONFIG_class-native = ""
> -BBCLASSEXTEND = "native"
> +BBCLASSEXTEND = "native nativesdk"

Apologies if this is self-evident, but why should nativesdk be added here?
A commit message explaining the why would be quite helpful.

>  
>  ALTERNATIVE_${PN}_append = " xxd"
>  ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
> ---
> 2.28.0
> 
> 
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [OE-core] [PATCH] vim: add nativesdk to BBCLASSEXTEND

[Nathan Rossi]

On Wed, 4 Nov 2020 at 23:32, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> Hello Nathan,
>
> On 11/4/20 2:17 PM, Nathan Rossi wrote:
> > Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> > ---
> >  meta/recipes-support/vim/vim_8.2.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
> > index 709b6ddb55..7e4654e472 100644
> > --- a/meta/recipes-support/vim/vim_8.2.bb
> > +++ b/meta/recipes-support/vim/vim_8.2.bb
> > @@ -3,7 +3,7 @@ require vim.inc
> >  PROVIDES = "xxd"
> >
> >  PACKAGECONFIG_class-native = ""
> > -BBCLASSEXTEND = "native"
> > +BBCLASSEXTEND = "native nativesdk"
>
> Apologies if this is self-evident, but why should nativesdk be added here?

It should be added so that vim can be included as part of a
buildtools-tarball/sdk. It is useful to be able to provide an editor
in a relatocable form, for when hosts do not provide an editor. It is
also useful for the xxd tool.

> A commit message explaining the why would be quite helpful.

Sorry, I've made quite a few of these mechanical add nativesdk patches
recently, and in the past. The reason for the change is almost always
for sdk/buildtools-tarball. I can add the above description if that
explanation is sufficient?

Regards,
Nathan

>
> >
> >  ALTERNATIVE_${PN}_append = " xxd"
> >  ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
> > ---
> > 2.28.0
> >
> >
> >
> > 
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [OE-core] [PATCH] vim: add nativesdk to BBCLASSEXTEND

[Ahmad Fatoum]

Hello,

On 11/5/20 2:30 AM, Nathan Rossi wrote:
> On Wed, 4 Nov 2020 at 23:32, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>> On 11/4/20 2:17 PM, Nathan Rossi wrote:
>>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
>>> ---
>>>  meta/recipes-support/vim/vim_8.2.bb | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
>>> index 709b6ddb55..7e4654e472 100644
>>> --- a/meta/recipes-support/vim/vim_8.2.bb
>>> +++ b/meta/recipes-support/vim/vim_8.2.bb
>>> @@ -3,7 +3,7 @@ require vim.inc
>>>  PROVIDES = "xxd"
>>>
>>>  PACKAGECONFIG_class-native = ""
>>> -BBCLASSEXTEND = "native"
>>> +BBCLASSEXTEND = "native nativesdk"
>>
>> Apologies if this is self-evident, but why should nativesdk be added here?
> 
> It should be added so that vim can be included as part of a
> buildtools-tarball/sdk. It is useful to be able to provide an editor
> in a relatocable form, for when hosts do not provide an editor. It is
> also useful for the xxd tool.

I see. Thanks!

>> A commit message explaining the why would be quite helpful.
> 
> Sorry, I've made quite a few of these mechanical add nativesdk patches
> recently, and in the past. The reason for the change is almost always
> for sdk/buildtools-tarball. I can add the above description if that
> explanation is sufficient?

I'd appreciate that. I am trying to read along to get more familiar with OE
and commit messages make this considerably easier.

Cheers,
Ahmad

> 
> Regards,
> Nathan
> 
>>
>>>
>>>  ALTERNATIVE_${PN}_append = " xxd"
>>>  ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
>>> ---
>>> 2.28.0
>>>
>>>
>>>
>>> 
>>>
>>
>> --
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |