Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check
@ 2021-10-14 17:55 Michael Halstead
  2021-10-14 21:40 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Halstead @ 2021-10-14 17:55 UTC (permalink / raw)
  To: openembedded-core; +Cc: Michael Halstead

Ensure the jinja2 module is available during bringup.

Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org>
---
 scripts/autobuilder-worker-prereq-tests | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/autobuilder-worker-prereq-tests b/scripts/autobuilder-worker-prereq-tests
index 5d7e6e2601..82e9a77bd5 100755
--- a/scripts/autobuilder-worker-prereq-tests
+++ b/scripts/autobuilder-worker-prereq-tests
@@ -35,6 +35,11 @@ if [ "$?" != "0" ]; then
     echo "Please set git config --global user.email"
     exit 1
 fi
+python3 -c "import jinja2"
+if [ "$?" != "0" ]; then
+    echo "Please ensure jinja2 is available"
+    exit 1
+fi
 bitbake -p
 if [ "$?" != "0" ]; then
     echo "Bitbake parsing failed"
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check
  2021-10-14 17:55 [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check Michael Halstead
@ 2021-10-14 21:40 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2021-10-14 21:40 UTC (permalink / raw)
  To: Michael Halstead, openembedded-core

On Thu, 2021-10-14 at 10:55 -0700, Michael Halstead wrote:
> Ensure the jinja2 module is available during bringup.
> 
> Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org>
> ---
>  scripts/autobuilder-worker-prereq-tests | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/autobuilder-worker-prereq-tests b/scripts/autobuilder-worker-prereq-tests
> index 5d7e6e2601..82e9a77bd5 100755
> --- a/scripts/autobuilder-worker-prereq-tests
> +++ b/scripts/autobuilder-worker-prereq-tests
> @@ -35,6 +35,11 @@ if [ "$?" != "0" ]; then
>      echo "Please set git config --global user.email"
>      exit 1
>  fi
> +python3 -c "import jinja2"
> +if [ "$?" != "0" ]; then
> +    echo "Please ensure jinja2 is available"
> +    exit 1
> +fi
>  bitbake -p
>  if [ "$?" != "0" ]; then
>      echo "Bitbake parsing failed"

Looks good, thanks, I merged it. Should we cover rsync with a test too?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-14 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-14 17:55 [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check Michael Halstead
2021-10-14 21:40 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox