[OE-core][PATCH] classes/populate_sdk_base: Add setscene tasks

[OE-core][PATCH] classes/populate_sdk_base: Add setscene tasks

[Joshua Watt]

do_populate_sdk was added to SSTATETASKS, but had no _setscene task
created to allow it to actually run from sstate. Add it so that SDKs can
be restored from sstate.

Note that like do_image_complete, do_populate_sdk is marked with
SSTATE_SKIP_CREATION by default so sstate is not used for them; adding
this task will allow it to work if the user overrides this default
though.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/classes/populate_sdk_base.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
index 49e166e697..fafdd96749 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -179,6 +179,10 @@ do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-inputdirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-outputdirs] = "${SDK_DEPLOY}"
 do_populate_sdk[stamp-extra-info] = "${MACHINE_ARCH}${SDKMACHINE}"
+python do_populate_sdk_setscene () {
+    sstate_setscene(d)
+}
+addtask do_populate_sdk_setscene
 
 PSEUDO_IGNORE_PATHS .= ",${SDKDEPLOYDIR},${WORKDIR}/oe-sdk-repo,${WORKDIR}/sstate-build-populate_sdk"
 
-- 
2.33.0

Re: [OE-core][PATCH] classes/populate_sdk_base: Add setscene tasks

[Richard Purdie]

On Fri, 2021-10-22 at 16:44 -0500, Joshua Watt wrote:
> do_populate_sdk was added to SSTATETASKS, but had no _setscene task
> created to allow it to actually run from sstate. Add it so that SDKs can
> be restored from sstate.
> 
> Note that like do_image_complete, do_populate_sdk is marked with
> SSTATE_SKIP_CREATION by default so sstate is not used for them; adding
> this task will allow it to work if the user overrides this default
> though.
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/classes/populate_sdk_base.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 49e166e697..fafdd96749 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -179,6 +179,10 @@ do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}"
>  do_populate_sdk[sstate-inputdirs] = "${SDKDEPLOYDIR}"
>  do_populate_sdk[sstate-outputdirs] = "${SDK_DEPLOY}"
>  do_populate_sdk[stamp-extra-info] = "${MACHINE_ARCH}${SDKMACHINE}"
> +python do_populate_sdk_setscene () {
> +    sstate_setscene(d)
> +}
> +addtask do_populate_sdk_setscene
>  
> 

That was deliberately missing since we don't use/need it. I've merged this since
I guess you want to use it but it isn't something I particularly want to
support. It simply won't work for eSDK either.

Cheers,

Richard