Re: [OE-core] [PATCH V2] appstream: upgrade from 1.0.6 to 1.1.2

[Changqing Li <changqing.li@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2419 bytes --]


On 3/11/26 10:27, Changqing Li via lists.openembedded.org wrote:
>
>
> On 3/10/26 19:44, Ross Burton wrote:
>> CAUTION: This email comes from a non Wind River email account!
>> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>
>> On 25 Feb 2026, at 03:40, Changqing Li via lists.openembedded.org<changqing.li=windriver.com@lists.openembedded.org> wrote:
>>> PACKAGECONFIG ?="${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>>> +PACKAGECONFIG:append:class-target = " bash-completion"
>>>
>>> PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd"
>>> PACKAGECONFIG[stemming] = "-Dstemming=true,-Dstemming=false,libstemmer"
>>> PACKAGECONFIG[qt6] = "-Dqt=true,-Dqt=false,qtbase"
>>> +PACKAGECONFIG[bash-completion] = "-Dbash-completion=true,-Dbash-completion=false”
>> I can’t see any other recipes that have a PACKAGECONFIG for bash completion.  Personally I’d just inherit the class and EXTRA_OEMESON:append:class-native = “ -Dbash-completion=false” as the special case is native.
>
> Hi, Ross
>
> Indeed, very few packages offer this PACKAGECONFIG，but both oe-core 
> and meta-networking have one.
>
> I checked several recipes that inherit the class but not provide the 
> PACKAGECONFIG,
>
> all the recipes don't provide option to disable bash-completion. I 
> think this is why they don't provide PACKAGECONFIG.
>
Here I means that the recipes's upstream don't provide an option to 
disable bash-completion, eg:  apt, it will compiled with bash-completion 
by default,  there is no option

to enable/disable bash-completion.  So they don't need a PACKAGECONFIG. 
But appstream provdes option to enable/disable bash-completion. so I add 
one allow user to

disable it.

//Changqing

> upstream appstream provides the option to disable bash-completion, I 
> think we should keep the upstream option.
>
> Regards
>
> Changqing
>
>> Ross
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#232832):https://lists.openembedded.org/g/openembedded-core/message/232832
> Mute This Topic:https://lists.openembedded.org/mt/117989519/3616873
> Group Owner:openembedded-core+owner@lists.openembedded.org
> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [changqing.li@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

[-- Attachment #2: Type: text/html, Size: 5223 bytes --]