Re: [OE-core] [PATCH 2/2] appstream: upgrade from 1.0.6 to 1.1.2

[Changqing Li <changqing.li@windriver.com>]

On 2/24/26 23:44, Peter Kjellerstedt wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>> -----Original Message-----
>> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin via lists.openembedded.org
>> Sent: den 24 februari 2026 10:59
>> To: changqing.li@windriver.com
>> Cc: openembedded-core@lists.openembedded.org
>> Subject: Re: [OE-core] [PATCH 2/2] appstream: upgrade from 1.0.6 to 1.1.2
>>
>> On Tue, 24 Feb 2026 at 02:42, Changqing Li via lists.openembedded.org <changqing.li=windriver.com@lists.openembedded.org> wrote:
>>
>>> +PACKAGECONFIG:class-target += "bash-completion"
> That should be:
>
> PACKAGECONFIG:append:class-target = " bash-completion"
>
> or it will replace the PACKAGECONFIG for target rather than
> add to it.
>
>>>   PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd"
>>>   PACKAGECONFIG[stemming] = "-Dstemming=true,-Dstemming=false,libstemmer"
>>>   PACKAGECONFIG[qt6] = "-Dqt=true,-Dqt=false,qtbase"
>>> +PACKAGECONFIG[bash-completion] = "-Dbash-completion=true,-Dbash-completion=false,bash-completion"
> Remove the dependency on bash-completion (see below).
>
>> bash-completion can perhaps stay disabled for both native and target?
>>
>> Alex
> No, better is to instead inherit the bash-completion bbclass so the
> file(s) are packaged separately, and installed automatically when
> the bash-completion-pkgs feature is enabled.

Thanks  Peter and Alex.  I will send a V2 according to the comments.

//Changqing

>
> //Peter
>