public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Changqing Li <changqing.li@windriver.com>
To: Ross Burton <Ross.Burton@arm.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH V2] appstream: upgrade from 1.0.6 to 1.1.2
Date: Wed, 11 Mar 2026 10:27:55 +0800	[thread overview]
Message-ID: <6c27908f-8f66-42df-980b-1bb4e20bb5f2@windriver.com> (raw)
In-Reply-To: <C0CE5EB9-AB4B-40D5-B625-3C34119E3099@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]


On 3/10/26 19:44, Ross Burton wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On 25 Feb 2026, at 03:40, Changqing Li via lists.openembedded.org<changqing.li=windriver.com@lists.openembedded.org> wrote:
>> PACKAGECONFIG ?="${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>> +PACKAGECONFIG:append:class-target = " bash-completion"
>>
>> PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd"
>> PACKAGECONFIG[stemming] = "-Dstemming=true,-Dstemming=false,libstemmer"
>> PACKAGECONFIG[qt6] = "-Dqt=true,-Dqt=false,qtbase"
>> +PACKAGECONFIG[bash-completion] = "-Dbash-completion=true,-Dbash-completion=false”
> I can’t see any other recipes that have a PACKAGECONFIG for bash completion.  Personally I’d just inherit the class and EXTRA_OEMESON:append:class-native = “ -Dbash-completion=false” as the special case is native.

Hi, Ross

Indeed, very few packages offer this PACKAGECONFIG,but both oe-core and 
meta-networking have one.

I checked several recipes that inherit the class but not provide the 
PACKAGECONFIG,

all the recipes don't provide option to disable bash-completion. I think 
this is why they don't provide PACKAGECONFIG.

upstream appstream provides the option to disable bash-completion, I 
think we should keep the upstream option.

Regards

Changqing

>
> Ross

[-- Attachment #2: Type: text/html, Size: 2987 bytes --]

  reply	other threads:[~2026-03-11  2:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  1:41 [PATCH 1/2] libfyaml: init add Changqing Li
2026-02-24  1:41 ` [PATCH 2/2] appstream: upgrade from 1.0.6 to 1.1.2 Changqing Li
2026-02-24  9:58   ` [OE-core] " Alexander Kanavin
2026-02-24 15:44     ` Peter Kjellerstedt
2026-02-25  3:28       ` Changqing Li
2026-02-25  3:40       ` [PATCH V2] " Changqing Li
2026-03-10 11:44         ` [OE-core] " Ross Burton
2026-03-11  2:27           ` Changqing Li [this message]
     [not found]           ` <189BA872138654D8.2412760@lists.openembedded.org>
2026-03-13  2:30             ` Changqing Li
     [not found]       ` <18976046C73DA293.1454197@lists.openembedded.org>
2026-02-25  4:39         ` Changqing Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c27908f-8f66-42df-980b-1bb4e20bb5f2@windriver.com \
    --to=changqing.li@windriver.com \
    --cc=Ross.Burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox