* [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES
@ 2022-09-01 23:42 Alejandro Enedino Hernandez Samaniego
2022-09-02 14:47 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2022-09-01 23:42 UTC (permalink / raw)
To: openembedded-core; +Cc: Alejandro Enedino Hernandez Samaniego
There could be IMAGE_CLASSES designed to work on images which arent
necessarily compatible with baremetal-images, one example is the
license_image class which relies on the package managers functionality
during do_rootfs, for baremetal images no rootfs is created hence the
package manager shouldnt be invoked, we need to avoid inheriting such
class to fix this behavior.
inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the default
to IMAGE_CLASSES, whilst removing undesired classes in an intermediate
step to avoid incompatibilities.
Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
---
meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/meta/classes-recipe/baremetal-image.bbclass b/meta/classes-recipe/baremetal-image.bbclass
index d3377a92fa..2f07dec4ac 100644
--- a/meta/classes-recipe/baremetal-image.bbclass
+++ b/meta/classes-recipe/baremetal-image.bbclass
@@ -18,8 +18,15 @@
## Emulate image.bbclass
# Handle inherits of any of the image classes we need
IMAGE_CLASSES ??= ""
-IMGCLASSES = " ${IMAGE_CLASSES}"
+BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}"
+
+# The license_image class relies on package managers used on do_rootfs
+# these dont exist for baremetal images since no rootfs is created.
+BAREMETAL_IMAGE_CLASSES:remove = "license_image"
+
+IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}"
inherit ${IMGCLASSES}
+
# Set defaults to satisfy IMAGE_FEATURES check
IMAGE_FEATURES ?= ""
IMAGE_FEATURES[type] = "list"
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES
2022-09-01 23:42 [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES Alejandro Enedino Hernandez Samaniego
@ 2022-09-02 14:47 ` Richard Purdie
2022-09-02 14:53 ` Alejandro Enedino Hernandez Samaniego
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2022-09-02 14:47 UTC (permalink / raw)
To: Alejandro Hernandez Samaniego, openembedded-core
On Thu, 2022-09-01 at 17:42 -0600, Alejandro Hernandez Samaniego wrote:
> There could be IMAGE_CLASSES designed to work on images which arent
> necessarily compatible with baremetal-images, one example is the
> license_image class which relies on the package managers functionality
> during do_rootfs, for baremetal images no rootfs is created hence the
> package manager shouldnt be invoked, we need to avoid inheriting such
> class to fix this behavior.
>
> inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the default
> to IMAGE_CLASSES, whilst removing undesired classes in an intermediate
> step to avoid incompatibilities.
>
> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
> ---
> meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/baremetal-image.bbclass b/meta/classes-recipe/baremetal-image.bbclass
> index d3377a92fa..2f07dec4ac 100644
> --- a/meta/classes-recipe/baremetal-image.bbclass
> +++ b/meta/classes-recipe/baremetal-image.bbclass
> @@ -18,8 +18,15 @@
> ## Emulate image.bbclass
> # Handle inherits of any of the image classes we need
> IMAGE_CLASSES ??= ""
> -IMGCLASSES = " ${IMAGE_CLASSES}"
> +BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}"
> +
> +# The license_image class relies on package managers used on do_rootfs
> +# these dont exist for baremetal images since no rootfs is created.
> +BAREMETAL_IMAGE_CLASSES:remove = "license_image"
> +
> +IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}"
> inherit ${IMGCLASSES}
> +
> # Set defaults to satisfy IMAGE_FEATURES check
> IMAGE_FEATURES ?= ""
> IMAGE_FEATURES[type] = "list"
This is going to become a usability nightmare. Can we patch
license_image to just silently do nothing for baremetal?
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES
2022-09-02 14:47 ` [OE-core] " Richard Purdie
@ 2022-09-02 14:53 ` Alejandro Enedino Hernandez Samaniego
2022-09-02 15:02 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2022-09-02 14:53 UTC (permalink / raw)
To: Richard Purdie; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 2269 bytes --]
On Fri, Sep 2, 2022, 9:47 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Thu, 2022-09-01 at 17:42 -0600, Alejandro Hernandez Samaniego wrote:
> > There could be IMAGE_CLASSES designed to work on images which arent
> > necessarily compatible with baremetal-images, one example is the
> > license_image class which relies on the package managers functionality
> > during do_rootfs, for baremetal images no rootfs is created hence the
> > package manager shouldnt be invoked, we need to avoid inheriting such
> > class to fix this behavior.
> >
> > inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the default
> > to IMAGE_CLASSES, whilst removing undesired classes in an intermediate
> > step to avoid incompatibilities.
> >
> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <
> alejandro@enedino.org>
> > ---
> > meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/classes-recipe/baremetal-image.bbclass
> b/meta/classes-recipe/baremetal-image.bbclass
> > index d3377a92fa..2f07dec4ac 100644
> > --- a/meta/classes-recipe/baremetal-image.bbclass
> > +++ b/meta/classes-recipe/baremetal-image.bbclass
> > @@ -18,8 +18,15 @@
> > ## Emulate image.bbclass
> > # Handle inherits of any of the image classes we need
> > IMAGE_CLASSES ??= ""
> > -IMGCLASSES = " ${IMAGE_CLASSES}"
> > +BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}"
> > +
> > +# The license_image class relies on package managers used on do_rootfs
> > +# these dont exist for baremetal images since no rootfs is created.
> > +BAREMETAL_IMAGE_CLASSES:remove = "license_image"
> > +
> > +IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}"
> > inherit ${IMGCLASSES}
> > +
> > # Set defaults to satisfy IMAGE_FEATURES check
> > IMAGE_FEATURES ?= ""
> > IMAGE_FEATURES[type] = "list"
>
> This is going to become a usability nightmare. Can we patch
> license_image to just silently do nothing for baremetal?
>
I think we can, but we'd have to do that on every class that is
incompatible (I don't expect many to be, but I tried to generate a more
generic solution and use BAREMETAL_, IMAGE_CLASSES as a gate), with that in
mind, Is that still better than this?
> Cheers,
>
> Richard
>
>
[-- Attachment #2: Type: text/html, Size: 3514 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES
2022-09-02 14:53 ` Alejandro Enedino Hernandez Samaniego
@ 2022-09-02 15:02 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2022-09-02 15:02 UTC (permalink / raw)
To: Alejandro Enedino Hernandez Samaniego; +Cc: OE-core
On Fri, 2022-09-02 at 09:53 -0500, Alejandro Enedino Hernandez
Samaniego wrote:
>
>
> On Fri, Sep 2, 2022, 9:47 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Thu, 2022-09-01 at 17:42 -0600, Alejandro Hernandez Samaniego
> > wrote:
> > > There could be IMAGE_CLASSES designed to work on images which
> > > arent
> > > necessarily compatible with baremetal-images, one example is the
> > > license_image class which relies on the package managers
> > > functionality
> > > during do_rootfs, for baremetal images no rootfs is created hence
> > > the
> > > package manager shouldnt be invoked, we need to avoid inheriting
> > > such
> > > class to fix this behavior.
> > >
> > > inherit BAREMETAL_IMAGE_CLASSES for baremetal images but set the
> > > default
> > > to IMAGE_CLASSES, whilst removing undesired classes in an
> > > intermediate
> > > step to avoid incompatibilities.
> > >
> > > Signed-off-by: Alejandro Enedino Hernandez Samaniego
> > > <alejandro@enedino.org>
> > > ---
> > > meta/classes-recipe/baremetal-image.bbclass | 9 ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta/classes-recipe/baremetal-image.bbclass
> > > b/meta/classes-recipe/baremetal-image.bbclass
> > > index d3377a92fa..2f07dec4ac 100644
> > > --- a/meta/classes-recipe/baremetal-image.bbclass
> > > +++ b/meta/classes-recipe/baremetal-image.bbclass
> > > @@ -18,8 +18,15 @@
> > > ## Emulate image.bbclass
> > > # Handle inherits of any of the image classes we need
> > > IMAGE_CLASSES ??= ""
> > > -IMGCLASSES = " ${IMAGE_CLASSES}"
> > > +BAREMETAL_IMAGE_CLASSES ?= " ${IMAGE_CLASSES}"
> > > +
> > > +# The license_image class relies on package managers used on
> > > do_rootfs
> > > +# these dont exist for baremetal images since no rootfs is
> > > created.
> > > +BAREMETAL_IMAGE_CLASSES:remove = "license_image"
> > > +
> > > +IMGCLASSES = " ${BAREMETAL_IMAGE_CLASSES}"
> > > inherit ${IMGCLASSES}
> > > +
> > > # Set defaults to satisfy IMAGE_FEATURES check
> > > IMAGE_FEATURES ?= ""
> > > IMAGE_FEATURES[type] = "list"
> >
> > This is going to become a usability nightmare. Can we patch
> > license_image to just silently do nothing for baremetal?
>
> I think we can, but we'd have to do that on every class that is
> incompatible (I don't expect many to be, but I tried to generate a
> more generic solution and use BAREMETAL_, IMAGE_CLASSES as a gate),
> with that in mind, Is that still better than this?
I think we do need to fixes the classes which don't work. The
alternative is users having two lists of image classes which defeats
much of what the variable was trying to do. We may as well just give up
on IMAGE_CLASSES for baremetal and require it's own list which will be
a pain for users.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-02 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 23:42 [PATCH] baremetal-image.bbclass: avoid inheriting incompatible IMAGE_CLASSES Alejandro Enedino Hernandez Samaniego
2022-09-02 14:47 ` [OE-core] " Richard Purdie
2022-09-02 14:53 ` Alejandro Enedino Hernandez Samaniego
2022-09-02 15:02 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox