* [PATCH 0/3] tune: update arm7a and cortexa8 tune files
@ 2011-08-19 22:06 Darren Hart
2011-08-19 22:06 ` [PATCH 1/3] tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES Darren Hart
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Darren Hart @ 2011-08-19 22:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi, Darren Hart
Correct some typographical errors in the arm7a and cortexa8 files. Add support
for the hard floating point abi. Leave the default as cortexa8-neon.
These are in preparation to enable hardfp for meta-yocto's beagleboard BSP.
The following changes since commit 8aa14b444f16c4fd0afe93eccd238a8fb2bc0292:
newt: update distro tracking fields (2011-08-19 09:29:20 -0700)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dvhart/tune-cortexa8
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/tune-cortexa8
Darren Hart (3):
tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES
tune: remove thumb flag from non-thumb cortexa8 tune variables
tune: Add hard floating point variants of cortexa8 tunes
meta/conf/machine/include/arm/arch-armv7a.inc | 2 +-
meta/conf/machine/include/tune-cortexa8.inc | 20 +++++++++++++++-----
2 files changed, 16 insertions(+), 6 deletions(-)
--
1.7.6
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/3] tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES
2011-08-19 22:06 [PATCH 0/3] tune: update arm7a and cortexa8 tune files Darren Hart
@ 2011-08-19 22:06 ` Darren Hart
2011-08-19 22:06 ` [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables Darren Hart
2011-08-19 22:06 ` [PATCH 3/3] tune: Add hard floating point variants of cortexa8 tunes Darren Hart
2 siblings, 0 replies; 9+ messages in thread
From: Darren Hart @ 2011-08-19 22:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Darren Hart, Koen Kooi
A closing quote was missing for an AVAILTUNES append operation, add it.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Koen Kooi <koen@dominion.thruhere.net>
---
meta/conf/machine/include/arm/arch-armv7a.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/conf/machine/include/arm/arch-armv7a.inc b/meta/conf/machine/include/arm/arch-armv7a.inc
index 704f86b..d508352 100644
--- a/meta/conf/machine/include/arm/arch-armv7a.inc
+++ b/meta/conf/machine/include/arm/arch-armv7a.inc
@@ -20,7 +20,7 @@ PACKAGE_EXTRA_ARCHS_tune-armv7at = "${PACKAGE_EXTRA_ARCHS_tune-armv7t} armv7a ar
PACKAGE_EXTRA_ARCHS_tune-armv7at-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7a-vfp-neon armv7at2-vfp-neon"
# VFP Tunes
-AVAILTUNES += "armv7hf armv7thf armv7hf-neon armv7thf-neon
+AVAILTUNES += "armv7hf armv7thf armv7hf-neon armv7thf-neon"
TUNE_FEATURES_tune-armv7ahf ?= "${TUNE_FEATURES_tune-armv7a} callconvention-hard"
TUNE_FEATURES_tune-armv7athf ?= "${TUNE_FEATURES_tune-armv7at} callconvention-hard"
TUNE_FEATURES_tune-armv7ahf-neon ?= "${TUNE_FEATURES_tune-armv7a-neon} callconvention-hard"
--
1.7.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-19 22:06 [PATCH 0/3] tune: update arm7a and cortexa8 tune files Darren Hart
2011-08-19 22:06 ` [PATCH 1/3] tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES Darren Hart
@ 2011-08-19 22:06 ` Darren Hart
2011-08-20 16:01 ` Khem Raj
2011-08-24 1:25 ` Richard Purdie
2011-08-19 22:06 ` [PATCH 3/3] tune: Add hard floating point variants of cortexa8 tunes Darren Hart
2 siblings, 2 replies; 9+ messages in thread
From: Darren Hart @ 2011-08-19 22:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Darren Hart, Koen Kooi
The thumb flag "t" appears to have been copy/pasted to all the
PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Koen Kooi <koen@dominion.thruhere.net>
---
meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
index 02b560c..67c5f0b 100644
--- a/meta/conf/machine/include/tune-cortexa8.inc
+++ b/meta/conf/machine/include/tune-cortexa8.inc
@@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a} cortexa8"
TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
-PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
-PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
--
1.7.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-19 22:06 ` [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables Darren Hart
@ 2011-08-20 16:01 ` Khem Raj
2011-08-20 17:58 ` Phil Blundell
2011-08-23 18:07 ` Darren Hart
2011-08-24 1:25 ` Richard Purdie
1 sibling, 2 replies; 9+ messages in thread
From: Khem Raj @ 2011-08-20 16:01 UTC (permalink / raw)
To: openembedded-core
On 8/19/2011 3:06 PM, Darren Hart wrote:
> The thumb flag "t" appears to have been copy/pasted to all the
> PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>
hmmm non thumb versions can run thumb packages. So I think its ok to
have t in EXTRA_ARCHS
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Jason Kridner<jkridner@beagleboard.org>
> CC: Koen Kooi<koen@dominion.thruhere.net>
> ---
> meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
> index 02b560c..67c5f0b 100644
> --- a/meta/conf/machine/include/tune-cortexa8.inc
> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a} cortexa8"
> TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
> TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
>
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
> PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-20 16:01 ` Khem Raj
@ 2011-08-20 17:58 ` Phil Blundell
2011-08-20 19:17 ` Khem Raj
2011-08-23 18:07 ` Darren Hart
1 sibling, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2011-08-20 17:58 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Sat, 2011-08-20 at 09:01 -0700, Khem Raj wrote:
> On 8/19/2011 3:06 PM, Darren Hart wrote:
> > The thumb flag "t" appears to have been copy/pasted to all the
> > PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
> >
>
> hmmm non thumb versions can run thumb packages. So I think its ok to
> have t in EXTRA_ARCHS
Er, really? If it can run thumb code, in what sense is it a "non thumb"
version?
p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-20 17:58 ` Phil Blundell
@ 2011-08-20 19:17 ` Khem Raj
0 siblings, 0 replies; 9+ messages in thread
From: Khem Raj @ 2011-08-20 19:17 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Sat, Aug 20, 2011 at 10:58 AM, Phil Blundell <philb@gnu.org> wrote:
> On Sat, 2011-08-20 at 09:01 -0700, Khem Raj wrote:
>> On 8/19/2011 3:06 PM, Darren Hart wrote:
>> > The thumb flag "t" appears to have been copy/pasted to all the
>> > PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>> >
>>
>> hmmm non thumb versions can run thumb packages. So I think its ok to
>> have t in EXTRA_ARCHS
>
> Er, really? If it can run thumb code, in what sense is it a "non thumb"
> version?
>
It was for armv7 pov here not for all arms like v4
with EABI, on cortex and interworking being mandatory it should run thumb code
thats what I meant.
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-20 16:01 ` Khem Raj
2011-08-20 17:58 ` Phil Blundell
@ 2011-08-23 18:07 ` Darren Hart
1 sibling, 0 replies; 9+ messages in thread
From: Darren Hart @ 2011-08-23 18:07 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 08/20/2011 09:01 AM, Khem Raj wrote:
> On 8/19/2011 3:06 PM, Darren Hart wrote:
>> The thumb flag "t" appears to have been copy/pasted to all the
>> PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>>
>
> hmmm non thumb versions can run thumb packages. So I think its ok to
> have t in EXTRA_ARCHS
Perhaps I'm confused with respect how these are used... see below.
>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Jason Kridner<jkridner@beagleboard.org>
>> CC: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>> meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
>> index 02b560c..67c5f0b 100644
>> --- a/meta/conf/machine/include/tune-cortexa8.inc
>> +++ b/meta/conf/machine/include/tune-cortexa8.inc
>> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a} cortexa8"
>> TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
>> TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
>>
>> -PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
If we don't drop the t, do we need to add the non-t version as well?, ie:
-PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}
${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
Here we're adding thumb to thumb, so I took that to mean we needed to
add non-thumb to the non-thumb tune definitions.
>> -PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables
2011-08-19 22:06 ` [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables Darren Hart
2011-08-20 16:01 ` Khem Raj
@ 2011-08-24 1:25 ` Richard Purdie
1 sibling, 0 replies; 9+ messages in thread
From: Richard Purdie @ 2011-08-24 1:25 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Darren Hart, Koen Kooi
On Fri, 2011-08-19 at 15:06 -0700, Darren Hart wrote:
> The thumb flag "t" appears to have been copy/pasted to all the
> PACKAGE_EXTRA_ARCHS tune variables. Remove it from the non-thumb versions.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Jason Kridner <jkridner@beagleboard.org>
> CC: Koen Kooi <koen@dominion.thruhere.net>
> ---
> meta/conf/machine/include/tune-cortexa8.inc | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
> index 02b560c..67c5f0b 100644
> --- a/meta/conf/machine/include/tune-cortexa8.inc
> +++ b/meta/conf/machine/include/tune-cortexa8.inc
> @@ -10,7 +10,7 @@ TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a} cortexa8"
> TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
> TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
>
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
> PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> -PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
I'm not convinced this is a mistake. Even if you select the cortexa8
tune, the machine can still accept thumb packages, we're just not
building them so I think in these cases, PACKAGE_EXTRA_ARCHS is correct
and is intended to be more inclusive.
I've therefore not taken this change.
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] tune: Add hard floating point variants of cortexa8 tunes
2011-08-19 22:06 [PATCH 0/3] tune: update arm7a and cortexa8 tune files Darren Hart
2011-08-19 22:06 ` [PATCH 1/3] tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES Darren Hart
2011-08-19 22:06 ` [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables Darren Hart
@ 2011-08-19 22:06 ` Darren Hart
2 siblings, 0 replies; 9+ messages in thread
From: Darren Hart @ 2011-08-19 22:06 UTC (permalink / raw)
To: openembedded-core; +Cc: Darren Hart, Koen Kooi
Enable machines or distros to select the hard floating point abi for cortexa8
machines. I left out the arm7a thumb+neon combinations as they were not
present in the original non-hf set.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Koen Kooi <koen@dominion.thruhere.net>
---
meta/conf/machine/include/tune-cortexa8.inc | 16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/meta/conf/machine/include/tune-cortexa8.inc b/meta/conf/machine/include/tune-cortexa8.inc
index 67c5f0b..edd1717 100644
--- a/meta/conf/machine/include/tune-cortexa8.inc
+++ b/meta/conf/machine/include/tune-cortexa8.inc
@@ -5,12 +5,22 @@ require conf/machine/include/arm/arch-armv7a.inc
TUNEVALID[cortexa8] = "Enable Cortex-A8 specific processor optimizations"
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa8", "-mtune=cortex-a8", "", d)}"
-AVAILTUNES += "cortexa8 cortexa8t"
+# Little Endian base configs
+AVAILTUNES += "cortexa8 cortexa8t cortexa8-neon"
TUNE_FEATURES_tune-cortexa8 = "${TUNE_FEATURES_tune-armv7a} cortexa8"
TUNE_FEATURES_tune-cortexa8t = "${TUNE_FEATURES_tune-armv7at} cortexa8"
-TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-cortexa8} neon"
-
+TUNE_FEATURES_tune-cortexa8-neon = "${TUNE_FEATURES_tune-armv7a-neon} cortexa8"
PACKAGE_EXTRA_ARCHS_tune-cortexa8 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
PACKAGE_EXTRA_ARCHS_tune-cortexa8t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
PACKAGE_EXTRA_ARCHS_tune-cortexa8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
+# VFP Tunes
+AVAILTUNES += "cortexa8hf cortexa8thf cortexa8hf-neon"
+TUNE_FEATURES_tune-cortexa8hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa8"
+TUNE_FEATURES_tune-cortexa8thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa8"
+TUNE_FEATURES_tune-cortexa8hf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa8"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa8hf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon}"
+
+
--
1.7.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-24 1:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-19 22:06 [PATCH 0/3] tune: update arm7a and cortexa8 tune files Darren Hart
2011-08-19 22:06 ` [PATCH 1/3] tune: add missing closing quote to arch-armv7a.inc for AVAILTUNES Darren Hart
2011-08-19 22:06 ` [PATCH 2/3] tune: remove thumb flag from non-thumb cortexa8 tune variables Darren Hart
2011-08-20 16:01 ` Khem Raj
2011-08-20 17:58 ` Phil Blundell
2011-08-20 19:17 ` Khem Raj
2011-08-23 18:07 ` Darren Hart
2011-08-24 1:25 ` Richard Purdie
2011-08-19 22:06 ` [PATCH 3/3] tune: Add hard floating point variants of cortexa8 tunes Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox