Re: [PATCH 0/2] glib-2.0: Don't check function "qsort_r" in configure.ac

[Xiaofeng Yan <xiaofeng.yan@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]

On 2012年02月06日 15:37, Xiaofeng Yan wrote:
> On 2012年02月06日 15:05, Martin Jansa wrote:
>> On Mon, Feb 06, 2012 at 02:41:09PM +0800, Xiaofeng Yan wrote:
>>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>>
>>> The function "g_qsort_with_data" has two kinds of realization. One 
>>> calls qsort_r
>>> from libglib, the other realize itself. the realization method is 
>>> controlled by macro "HAVE_QSORT_R".
>>> qsort_r from libglib cause sort error. Add no-check-qsort_r.patch 
>>> for fixing this problem.
>>> This patch is to fix bug 1959. After this patch is merged into 
>>> OE-core I will open a new bug to
>>> track the reason why qsort_r report normally. For finishing lsb test 
>>> in YOCTO 1.2 M3 this patch
>>> is applied temporarily.
>>>
>>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>>    Branch: xiaofeng/1959
>>>    Browse: 
>>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/1959
>>>
>>> Thanks,
>>>      Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>> ---
>> no-check-qsort_r.patch is the same as remove.test.for.qsort_r.patch from
>> http://git.openembedded.org/openembedded-core/commit/?id=74f43e3b269c01dba7cd5215a8e825229bd5ecff 
>>
>>
>> which was later removed from glib-2.0-native in
>> http://git.openembedded.org/openembedded-core/commit/?id=37579d7d74d127c90c1e078d05c5bf4ba0b3f755 
>>
>>
>> and later removed completely in
>> http://git.openembedded.org/openembedded-core/commit/?id=812342e44e9e361a0fa93cfcfe65cf4dd6f2fb57 
>>
>>
>> Are you sure this patch is right fix? And no need to split adding patch
>> itself and adding it to SRC_URI to 2 patches.
>>
>> Cheers,
>>
> Hi Martin Jansa,
> I reviewed the above link, no-check-qsort_r.patch is  the same as 
> remove.test.for.qsort_r.patch really. Please check attachment for the 
> test program from LSB 4.1. I think we need this patch because it is an 
> error really. LSB report the next information:
>
> After sorting array, the 0-th element of array should be 1, but is 2
> After sorting array, the 1-th element of array should be 2, but is 1
> After sorting array, the 2-th element of array should be 3, but is 5
> After sorting array, the 4-th element of array should be 5, but is 3
>
>
> I can reuse this patch which was removed before if you think this is a 
> bug. Do you any suggestion?
>
> Compile this test program.
> $ gcc -g `pkg-config --cflags glib-2.0` gobject_value_arrays.c -o 
> gobject -lgobject-2.0
>
>
I reviewed the origin patch from Martin Jansa and found that my patch is 
different from him.  My patch is to remove the check of qsort_r and the 
origin had still this check. I also update my patch because
it have two file:// in SRC_URI.
Thank Martin Jansa.

>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core


[-- Attachment #2: Type: text/html, Size: 5422 bytes --]