Re: [PATCH 1/2] glib-2.0: Don't check function qsort_r

[Peter Tworek <tworaz666@gmail.com>]

On 02/06/2012 04:34 PM, Khem Raj wrote:
> On Mon, Feb 6, 2012 at 1:13 AM, Phil Blundell<philb@gnu.org>  wrote:
>> On Mon, 2012-02-06 at 14:41 +0800, Xiaofeng Yan wrote:
>>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>>
>>> function "g_qsort_with_data" has two kinds of realization. One calls qsort_r
>>> from libglib, the other realize itself.
>>> qsort_r from libglib cause sort error.
>>> For fixing this problem no checking "qsort_r" in configure.ac.
>>>
>>> [YOCTO #1959]
>> This description doesn't make much sense.  libglib is part of glib-2.0
>> itself; I guess you meant to say that qsort_r is from libc6.  But, even
>> leaving that aside, if qsort_r is broken then the appropriate patch
>> would be to fix it, not just to hack glib to use a standalone
>> implementation.  So this patch seems like the wrong thing by any
>> measure.
>>
>> Does glibc's own testsuite also have failures for qsort_r?
> glibc one works ok last time I checked however uclibc does not implement it
Yes, it does. It was implemented somewhere in between 0.9.32 and 0.9.33 
[1]. Last time I've checked it even worked fine with glib-2.0. You just 
need to change glib_cv_have_qsort to yes in meta/site/common-uclibc.

/ptw

[1] 
http://git.uclibc.org/uClibc/commit/?id=515d54433138596e81267237542bd9168b8cc787