From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] glib-2.0: Don't check function qsort_r
Date: Mon, 06 Feb 2012 09:13:43 +0000 [thread overview]
Message-ID: <1328519623.2716.208.camel@x121e.pbcl.net> (raw)
In-Reply-To: <1624cca695c5baf08d376297f7278732dbcbfba6.1328509284.git.xiaofeng.yan@windriver.com>
On Mon, 2012-02-06 at 14:41 +0800, Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
>
> function "g_qsort_with_data" has two kinds of realization. One calls qsort_r
> from libglib, the other realize itself.
> qsort_r from libglib cause sort error.
> For fixing this problem no checking "qsort_r" in configure.ac.
>
> [YOCTO #1959]
This description doesn't make much sense. libglib is part of glib-2.0
itself; I guess you meant to say that qsort_r is from libc6. But, even
leaving that aside, if qsort_r is broken then the appropriate patch
would be to fix it, not just to hack glib to use a standalone
implementation. So this patch seems like the wrong thing by any
measure.
Does glibc's own testsuite also have failures for qsort_r?
p.
next prev parent reply other threads:[~2012-02-06 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 6:41 [PATCH 0/2] glib-2.0: Don't check function "qsort_r" in configure.ac Xiaofeng Yan
2012-02-06 6:41 ` [PATCH 1/2] glib-2.0: Don't check function qsort_r Xiaofeng Yan
2012-02-06 9:13 ` Phil Blundell [this message]
2012-02-06 15:34 ` Khem Raj
2012-02-06 19:13 ` Peter Tworek
2012-02-06 22:54 ` Khem Raj
2012-02-06 6:41 ` [PATCH 2/2] glib-2.0: Add patch "no-check-qsort_r.patch" Xiaofeng Yan
2012-02-06 15:33 ` Khem Raj
2012-02-07 5:40 ` Xiaofeng Yan
2012-02-06 7:05 ` [PATCH 0/2] glib-2.0: Don't check function "qsort_r" in configure.ac Martin Jansa
2012-02-06 7:37 ` Xiaofeng Yan
2012-02-06 9:16 ` Xiaofeng Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328519623.2716.208.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox