Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Denys Dmytriyenko <denys@ti.com>
Subject: Re: [PATCH] rt-tests: fix dependency on eglibc, clean LDFLAGS passing
Date: Tue, 20 Mar 2012 08:01:44 -0700	[thread overview]
Message-ID: <4F689BD8.4040201@linux.intel.com> (raw)
In-Reply-To: <1332202974-27977-1-git-send-email-denis@denix.org>



On 03/19/2012 05:22 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Replace dependency on eglibc with virtual/libc
> Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>

Thanks Denys,

Looking through the rt-tests sources I don't see TARGET_CC_ARCH
anywhere. Have you confirmed that changes made there make their way into
the actual build?

What was the problem you ran into?

--
Darren

> ---
>  meta/recipes-rt/rt-tests/rt-tests_0.83.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> index 6425027..3755c79 100644
> --- a/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> +++ b/meta/recipes-rt/rt-tests/rt-tests_0.83.bb
> @@ -1,7 +1,7 @@
>  DESCRIPTION = "Real-Time preemption testcases"
>  HOMEPAGE = "https://rt.wiki.kernel.org/index.php/Cyclictest"
>  SECTION = "tests"
> -DEPENDS = "linux-libc-headers eglibc"
> +DEPENDS = "linux-libc-headers virtual/libc"
>  LICENSE = "GPLv2 & GPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>                      file://src/cyclictest/cyclictest.c;beginline=7;endline=9;md5=ce162fe491d19d2ec67dff6dbc938d50 \
> @@ -11,13 +11,13 @@ SRCREV = "5f1e84f8b015df3ff950056494134eca3f640d70"
>  
>  # git -> 0.83 needs a PE bump
>  PE = "1"
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "git://github.com/clrkwllms/rt-tests.git"
>  
>  S = "${WORKDIR}/git"
>  
> -CFLAGS += "-I${S}/src/include -D_GNU_SOURCE -Wall -Wno-nonnulli ${LDFLAGS}"
> +TARGET_CC_ARCH += "${LDFLAGS}"
>  
>  # calling 'uname -m' is broken on crossbuilds
>  EXTRA_OEMAKE = "NUMA=0"

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2012-03-20 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20  0:22 [PATCH] rt-tests: fix dependency on eglibc, clean LDFLAGS passing Denys Dmytriyenko
2012-03-20 15:01 ` Darren Hart [this message]
2012-03-20 15:11   ` Koen Kooi
2012-04-07  3:34     ` Khem Raj
2012-03-20 15:28   ` Denys Dmytriyenko
2012-03-20 15:33     ` Darren Hart
2012-03-20 16:09       ` Denys Dmytriyenko
2012-03-20 16:22         ` Darren Hart
2012-03-20 18:39         ` Darren Hart
2012-03-20 18:59           ` Denys Dmytriyenko
2012-03-20 19:03             ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F689BD8.4040201@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=denys@ti.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox