Re: [PATCH] rt-tests: fix dependency on eglibc, clean LDFLAGS passing

[Darren Hart <dvhart@linux.intel.com>]

On 03/20/2012 08:28 AM, Denys Dmytriyenko wrote:
> On Tue, Mar 20, 2012 at 08:01:44AM -0700, Darren Hart wrote:
>>
>>
>> On 03/19/2012 05:22 PM, Denys Dmytriyenko wrote:
>>> From: Denys Dmytriyenko <denys@ti.com>
>>>
>>> Replace dependency on eglibc with virtual/libc
>>> Pass LDFLAGS to TARGET_CC_ARCH, instead of CFLAGS as Makefile overrides it
>>>
>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>
>> Thanks Denys,
>>
>> Looking through the rt-tests sources I don't see TARGET_CC_ARCH
>> anywhere. Have you confirmed that changes made there make their way into
>> the actual build?
> 
> Darren,
> 
> TARGET_CC_ARCH is not an rt-tests specific variable, it's used in OE. 
> Although, TARGET_LDFLAGS might be more appropriate for this purpose, 
> historically TARGET_CC_ARCH was heavily used to pass distro LDFLAGS to the 
> app's build process - grepping it would show many such cases in OE-Core and 
> especially in meta-oe...


OK, thanks for the context. Will you be resubmitting with TARGET_LDFLAGS?


>> What was the problem you ran into?
> 
> Not a problem per se, but it was not getting all the LDFLAGS being passed, 
> more specifically:
> 
> -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> 
> BTW, in Classic OE it was failing on GNU Hash QA check w/o this.
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel