* [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror
@ 2012-08-16 11:17 Andrei Gherzan
2012-08-16 17:33 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Andrei Gherzan @ 2012-08-16 11:17 UTC (permalink / raw)
To: openembedded-core; +Cc: Andrei Gherzan
After commit 2718537b4b04eb3d80ab4d74171b58e7b8dd68b8 (bitbake:
build.py: Only execute mkdirhier if stampdir doesn't exist) build
failes as cached_mtime_noerror needs an argument - stamp dir. This
argument was forgotten.
Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
bitbake/lib/bb/build.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
index d64077e..b484d19 100644
--- a/bitbake/lib/bb/build.py
+++ b/bitbake/lib/bb/build.py
@@ -465,7 +465,7 @@ def stamp_internal(taskname, d, file_name):
stamp = bb.parse.siggen.stampfile(stamp, file_name, taskname, extrainfo)
stampdir = os.path.dirname(stamp)
- if bb.parse.cached_mtime_noerror == 0:
+ if bb.parse.cached_mtime_noerror(stampdir) == 0:
bb.utils.mkdirhier(stampdir)
return stamp
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror
2012-08-16 11:17 [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror Andrei Gherzan
@ 2012-08-16 17:33 ` Saul Wold
0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-08-16 17:33 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Andrei Gherzan
On 08/16/2012 04:17 AM, Andrei Gherzan wrote:
> After commit 2718537b4b04eb3d80ab4d74171b58e7b8dd68b8 (bitbake:
> build.py: Only execute mkdirhier if stampdir doesn't exist) build
> failes as cached_mtime_noerror needs an argument - stamp dir. This
> argument was forgotten.
>
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
> bitbake/lib/bb/build.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
> index d64077e..b484d19 100644
> --- a/bitbake/lib/bb/build.py
> +++ b/bitbake/lib/bb/build.py
> @@ -465,7 +465,7 @@ def stamp_internal(taskname, d, file_name):
> stamp = bb.parse.siggen.stampfile(stamp, file_name, taskname, extrainfo)
>
> stampdir = os.path.dirname(stamp)
> - if bb.parse.cached_mtime_noerror == 0:
> + if bb.parse.cached_mtime_noerror(stampdir) == 0:
> bb.utils.mkdirhier(stampdir)
>
> return stamp
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror
@ 2012-08-16 11:21 Andrei Gherzan
2012-08-16 11:28 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Andrei Gherzan @ 2012-08-16 11:21 UTC (permalink / raw)
To: openembedded-core; +Cc: Andrei Gherzan
After commit 2718537b4b04eb3d80ab4d74171b58e7b8dd68b8 (bitbake:
build.py: Only execute mkdirhier if stampdir doesn't exist) build
failes as cached_mtime_noerror needs an argument - stamp dir. This
argument was forgotten.
Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
bitbake/lib/bb/build.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
index d64077e..b484d19 100644
--- a/bitbake/lib/bb/build.py
+++ b/bitbake/lib/bb/build.py
@@ -465,7 +465,7 @@ def stamp_internal(taskname, d, file_name):
stamp = bb.parse.siggen.stampfile(stamp, file_name, taskname, extrainfo)
stampdir = os.path.dirname(stamp)
- if bb.parse.cached_mtime_noerror == 0:
+ if bb.parse.cached_mtime_noerror(stampdir) == 0:
bb.utils.mkdirhier(stampdir)
return stamp
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror
2012-08-16 11:21 Andrei Gherzan
@ 2012-08-16 11:28 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2012-08-16 11:28 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Andrei Gherzan
On Thu, 2012-08-16 at 14:21 +0300, Andrei Gherzan wrote:
> After commit 2718537b4b04eb3d80ab4d74171b58e7b8dd68b8 (bitbake:
> build.py: Only execute mkdirhier if stampdir doesn't exist) build
> failes as cached_mtime_noerror needs an argument - stamp dir. This
> argument was forgotten.
>
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
> bitbake/lib/bb/build.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
> index d64077e..b484d19 100644
> --- a/bitbake/lib/bb/build.py
> +++ b/bitbake/lib/bb/build.py
> @@ -465,7 +465,7 @@ def stamp_internal(taskname, d, file_name):
> stamp = bb.parse.siggen.stampfile(stamp, file_name, taskname, extrainfo)
>
> stampdir = os.path.dirname(stamp)
> - if bb.parse.cached_mtime_noerror == 0:
> + if bb.parse.cached_mtime_noerror(stampdir) == 0:
> bb.utils.mkdirhier(stampdir)
>
> return stamp
I suspect I'd fixed this locally but pushed an old version. I've merged
this, thanks.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-16 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-16 11:17 [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror Andrei Gherzan
2012-08-16 17:33 ` Saul Wold
-- strict thread matches above, loose matches on Subject: below --
2012-08-16 11:21 Andrei Gherzan
2012-08-16 11:28 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox