Re: [PATCH][RFC] coreutils: Upgrade to upstream version 8.17

From: Saul Wold <sgw@linux.intel.com>
To: Radu Moisan <radu.moisan@intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][RFC] coreutils: Upgrade to upstream version 8.17
Date: Mon, 20 Aug 2012 09:45:48 -0700	[thread overview]
Message-ID: <503269BC.1000106@linux.intel.com> (raw)
In-Reply-To: <5031D36D.7040107@intel.com>

On 08/19/2012 11:04 PM, Radu Moisan wrote:
>
> On 08/17/2012 06:55 PM, Saul Wold wrote:
>> On 08/17/2012 06:05 AM, Radu Moisan wrote:
>>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>>> ---
>>>   .../coreutils-8.17/realpath-works-yes.patch        |   13
>>> +++++++++++++
>>>   .../remove-gets.patch                              |   20
>>> +++++++++++---------
>>>   .../remove-usr-local-lib-from-m4.patch             |    0
>>>   .../{coreutils_8.14.bb => coreutils_8.17.bb}       |    9 +++++----
>>>   4 files changed, 29 insertions(+), 13 deletions(-)
>>>   create mode 100644
>>> meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>>>   rename meta/recipes-core/coreutils/{coreutils-8.14 =>
>>> coreutils-8.17}/remove-gets.patch (47%)
>>>   rename meta/recipes-core/coreutils/{coreutils-8.14 =>
>>> coreutils-8.17}/remove-usr-local-lib-from-m4.patch (100%)
>>>   rename meta/recipes-core/coreutils/{coreutils_8.14.bb =>
>>> coreutils_8.17.bb} (91%)
>>>
>>> diff --git
>>> a/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>>> b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>>> new file mode 100644
>>> index 0000000..6bbe7ee
>>> --- /dev/null
>>> +++
>>> b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch
>>
>> Your new patch needs a header, explaining why, and adding
>> Upstream-Status and Signed-off-by tags.
>>
> I meant this only as an RFC, to get feedback for my patch, from a
> functional point of view, it is not intended to be the final patch.
> I have a Signed-off-by tag, are you referring to something else?
> Can you give me more details about Upstream-Status? I've google'd this
> problem for a bit but could not find an existing patch for it, nor a bug
> filled for this matter. Since I don't know yet if what I'm fixing it's
> really a bug (or a misconfiguration on my side) I send this RFC to get a
> hold of whether I'm on the good track here or not. If this patch turns
> out to be valid, I'll get in touch with the guys from coreutils' mailing
> lists, and try to push it upstream.

Radu,

For patches included in a given recipe we also have Signed-off-by as 
well as the Upstream-Status tag as defined by:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Please review this again.

Thanks
	Sau!

>
> radu
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>