Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Radu Moisan <radu.moisan@intel.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][RFC] coreutils: Upgrade to upstream version 8.17
Date: Tue, 21 Aug 2012 11:46:52 +0300	[thread overview]
Message-ID: <50334AFC.8080502@intel.com> (raw)
In-Reply-To: <503269BC.1000106@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]


>>> Your new patch needs a header, explaining why, and adding
>>> Upstream-Status and Signed-off-by tags.
>>>
>> I meant this only as an RFC, to get feedback for my patch, from a
>> functional point of view, it is not intended to be the final patch.
>> I have a Signed-off-by tag, are you referring to something else?
>> Can you give me more details about Upstream-Status? I've google'd this
>> problem for a bit but could not find an existing patch for it, nor a bug
>> filled for this matter. Since I don't know yet if what I'm fixing it's
>> really a bug (or a misconfiguration on my side) I send this RFC to get a
>> hold of whether I'm on the good track here or not. If this patch turns
>> out to be valid, I'll get in touch with the guys from coreutils' mailing
>> lists, and try to push it upstream.
>
> Radu,
>
> For patches included in a given recipe we also have Signed-off-by as 
> well as the Upstream-Status tag as defined by:
>
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>
> Please review this again.
Soul,
I understood your point, and in the *actual* patch I will update the 
Sign-off-by and a short description, and an Upstream Status. However, I 
reviewed again  Commit_Patch_Message_Guidelines and there is nothing in 
there mentioned about RFCs. This is an RFC, and it was intended to get a 
quick feedback from people more familiar/experienced with 
coreutils/autotools. I need feedback about the functional change of this 
patch. In my first reply I described as extensively as I could my 
problem and my question.

As far as the RFCs go, how long should I wait on an RFC? It's been more 
then a few days and nobody commented. Would it be appropriate to assume 
that if nobody had any comments, the patch is valid?

Radu

[-- Attachment #2: Type: text/html, Size: 2807 bytes --]

      reply	other threads:[~2012-08-21  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 13:05 [PATCH][RFC] coreutils: Upgrade to upstream version 8.17 Radu Moisan
2012-08-17 13:06 ` Radu Moisan
2012-08-17 15:55 ` Saul Wold
2012-08-20  6:04   ` Radu Moisan
2012-08-20 16:45     ` Saul Wold
2012-08-21  8:46       ` Radu Moisan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50334AFC.8080502@intel.com \
    --to=radu.moisan@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox