Openembedded Core Discussions
 help / color / mirror / Atom feed
From: jhuang0 <jackie.huang@windriver.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: "Zhao, Zhenfeng" <Zhenfeng.Zhao@windriver.com>,
	"Yang, Liezhi" <Liezhi.Yang@windriver.com>
Subject: Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native
Date: Fri, 24 Aug 2012 11:18:19 +0800	[thread overview]
Message-ID: <5036F27B.2050906@windriver.com> (raw)
In-Reply-To: <500E2FFF.2050202@windriver.com>



On 7/24/2012 1:17 PM, jhuang0 wrote:
>
>
> On 7/23/2012 6:00 PM, Richard Purdie wrote:
>> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
>>> From: Jackie Huang<jackie.huang@windriver.com>
>>>
>>> do_install needs command 'msgfmt', it would fail if the command
>>> doesn't exist on the host, add DEPENDS gettext-native to fix this.
>>>
>>> [YOCTO #2811]
>>>
>>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com>
>>> ---
>>>   meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb
>>> b/meta/recipes-extended/quota/quota_4.00.bb
>>> index 5fef9cb..25f6381 100644
>>> --- a/meta/recipes-extended/quota/quota_4.00.bb
>>> +++ b/meta/recipes-extended/quota/quota_4.00.bb
>>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] =
>>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>>>
>>>   S = "${WORKDIR}/quota-tools"
>>>
>>> +DEPENDS = "gettext-native"
>>> +
>>>   inherit autotools
>>>
>>>   EXTRA_OEMAKE += 'STRIP=""'
>>
>> Shouldn't this be "inherit gettext" ?
>
> No, quota doesn't depend on gettext at runtime, so I don't think we need
> 'inherit gettext'.

quota only needs command 'msgfmt' which provied by gettext in 
do_install, so I don't think we need 'inherit gettext' to both depends 
on gettext-native and virtual/gettext. Could anyone explain why we 
should use 'inherit gettext' instead of just depending on gettext-native?

Thanks,
Jackie

>
> Thanks,
> Jackie
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745



  reply	other threads:[~2012-08-24  3:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23  8:38 [PATCH 0/1] quota 4.00: add DEPENDS gettext-native jackie.huang
2012-07-23  8:38 ` [PATCH 1/1] " jackie.huang
2012-07-23 10:00   ` Richard Purdie
2012-07-24  5:17     ` jhuang0
2012-08-24  3:18       ` jhuang0 [this message]
2012-09-06 14:00         ` Ahsan, Noor
2012-09-12 14:02   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5036F27B.2050906@windriver.com \
    --to=jackie.huang@windriver.com \
    --cc=Liezhi.Yang@windriver.com \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox