* [PATCH 0/1] quota 4.00: add DEPENDS gettext-native @ 2012-07-23 8:38 jackie.huang 2012-07-23 8:38 ` [PATCH 1/1] " jackie.huang 0 siblings, 1 reply; 7+ messages in thread From: jackie.huang @ 2012-07-23 8:38 UTC (permalink / raw) To: openembedded-core From: Jackie Huang <jackie.huang@windriver.com> do_install needs command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this. [YOCTO #2811] Signed-off-by: Jackie Huang <jackie.huang@windriver.com> --- The following changes since commit da1de01aa74da0f38f07af523a9861824f7b0c95: Pyphon-native: Fix typo (2012-07-22 14:20:26 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib jhuang0/defect2811_quota_msgfmt http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/defect2811_quota_msgfmt Jackie Huang (1): quota 4.00: add DEPENDS gettext-native meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- 1.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-07-23 8:38 [PATCH 0/1] quota 4.00: add DEPENDS gettext-native jackie.huang @ 2012-07-23 8:38 ` jackie.huang 2012-07-23 10:00 ` Richard Purdie 2012-09-12 14:02 ` Richard Purdie 0 siblings, 2 replies; 7+ messages in thread From: jackie.huang @ 2012-07-23 8:38 UTC (permalink / raw) To: openembedded-core From: Jackie Huang <jackie.huang@windriver.com> do_install needs command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this. [YOCTO #2811] Signed-off-by: Jackie Huang <jackie.huang@windriver.com> --- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb index 5fef9cb..25f6381 100644 --- a/meta/recipes-extended/quota/quota_4.00.bb +++ b/meta/recipes-extended/quota/quota_4.00.bb @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f S = "${WORKDIR}/quota-tools" +DEPENDS = "gettext-native" + inherit autotools EXTRA_OEMAKE += 'STRIP=""' -- 1.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-07-23 8:38 ` [PATCH 1/1] " jackie.huang @ 2012-07-23 10:00 ` Richard Purdie 2012-07-24 5:17 ` jhuang0 2012-09-12 14:02 ` Richard Purdie 1 sibling, 1 reply; 7+ messages in thread From: Richard Purdie @ 2012-07-23 10:00 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: > From: Jackie Huang <jackie.huang@windriver.com> > > do_install needs command 'msgfmt', it would fail if the command > doesn't exist on the host, add DEPENDS gettext-native to fix this. > > [YOCTO #2811] > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > --- > meta/recipes-extended/quota/quota_4.00.bb | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb > index 5fef9cb..25f6381 100644 > --- a/meta/recipes-extended/quota/quota_4.00.bb > +++ b/meta/recipes-extended/quota/quota_4.00.bb > @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f > > S = "${WORKDIR}/quota-tools" > > +DEPENDS = "gettext-native" > + > inherit autotools > > EXTRA_OEMAKE += 'STRIP=""' Shouldn't this be "inherit gettext" ? Cheers, Richard ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-07-23 10:00 ` Richard Purdie @ 2012-07-24 5:17 ` jhuang0 2012-08-24 3:18 ` jhuang0 0 siblings, 1 reply; 7+ messages in thread From: jhuang0 @ 2012-07-24 5:17 UTC (permalink / raw) To: Patches and discussions about the oe-core layer, Richard Purdie On 7/23/2012 6:00 PM, Richard Purdie wrote: > On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: >> From: Jackie Huang<jackie.huang@windriver.com> >> >> do_install needs command 'msgfmt', it would fail if the command >> doesn't exist on the host, add DEPENDS gettext-native to fix this. >> >> [YOCTO #2811] >> >> Signed-off-by: Jackie Huang<jackie.huang@windriver.com> >> --- >> meta/recipes-extended/quota/quota_4.00.bb | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb >> index 5fef9cb..25f6381 100644 >> --- a/meta/recipes-extended/quota/quota_4.00.bb >> +++ b/meta/recipes-extended/quota/quota_4.00.bb >> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f >> >> S = "${WORKDIR}/quota-tools" >> >> +DEPENDS = "gettext-native" >> + >> inherit autotools >> >> EXTRA_OEMAKE += 'STRIP=""' > > Shouldn't this be "inherit gettext" ? No, quota doesn't depend on gettext at runtime, so I don't think we need 'inherit gettext'. Thanks, Jackie > > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-07-24 5:17 ` jhuang0 @ 2012-08-24 3:18 ` jhuang0 2012-09-06 14:00 ` Ahsan, Noor 0 siblings, 1 reply; 7+ messages in thread From: jhuang0 @ 2012-08-24 3:18 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: Zhao, Zhenfeng, Yang, Liezhi On 7/24/2012 1:17 PM, jhuang0 wrote: > > > On 7/23/2012 6:00 PM, Richard Purdie wrote: >> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: >>> From: Jackie Huang<jackie.huang@windriver.com> >>> >>> do_install needs command 'msgfmt', it would fail if the command >>> doesn't exist on the host, add DEPENDS gettext-native to fix this. >>> >>> [YOCTO #2811] >>> >>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com> >>> --- >>> meta/recipes-extended/quota/quota_4.00.bb | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb >>> b/meta/recipes-extended/quota/quota_4.00.bb >>> index 5fef9cb..25f6381 100644 >>> --- a/meta/recipes-extended/quota/quota_4.00.bb >>> +++ b/meta/recipes-extended/quota/quota_4.00.bb >>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = >>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f >>> >>> S = "${WORKDIR}/quota-tools" >>> >>> +DEPENDS = "gettext-native" >>> + >>> inherit autotools >>> >>> EXTRA_OEMAKE += 'STRIP=""' >> >> Shouldn't this be "inherit gettext" ? > > No, quota doesn't depend on gettext at runtime, so I don't think we need > 'inherit gettext'. quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native? Thanks, Jackie > > Thanks, > Jackie > >> >> Cheers, >> >> Richard >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-08-24 3:18 ` jhuang0 @ 2012-09-06 14:00 ` Ahsan, Noor 0 siblings, 0 replies; 7+ messages in thread From: Ahsan, Noor @ 2012-09-06 14:00 UTC (permalink / raw) To: jhuang0, Patches and discussions about the oe-core layer Cc: Zhao, Zhenfeng, Yang, Liezhi Hello, Kindly someone merge this patch. We are hitting this issue. Regards, Noor -----Original Message----- From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of jhuang0 Sent: Friday, August 24, 2012 8:18 AM To: Patches and discussions about the oe-core layer Cc: Zhao, Zhenfeng; Yang, Liezhi Subject: Re: [OE-core] [PATCH 1/1] quota 4.00: add DEPENDS gettext-native On 7/24/2012 1:17 PM, jhuang0 wrote: > > > On 7/23/2012 6:00 PM, Richard Purdie wrote: >> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: >>> From: Jackie Huang<jackie.huang@windriver.com> >>> >>> do_install needs command 'msgfmt', it would fail if the command >>> doesn't exist on the host, add DEPENDS gettext-native to fix this. >>> >>> [YOCTO #2811] >>> >>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com> >>> --- >>> meta/recipes-extended/quota/quota_4.00.bb | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb >>> b/meta/recipes-extended/quota/quota_4.00.bb >>> index 5fef9cb..25f6381 100644 >>> --- a/meta/recipes-extended/quota/quota_4.00.bb >>> +++ b/meta/recipes-extended/quota/quota_4.00.bb >>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = >>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f >>> >>> S = "${WORKDIR}/quota-tools" >>> >>> +DEPENDS = "gettext-native" >>> + >>> inherit autotools >>> >>> EXTRA_OEMAKE += 'STRIP=""' >> >> Shouldn't this be "inherit gettext" ? > > No, quota doesn't depend on gettext at runtime, so I don't think we > need 'inherit gettext'. quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native? Thanks, Jackie > > Thanks, > Jackie > >> >> Cheers, >> >> Richard >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745 _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native 2012-07-23 8:38 ` [PATCH 1/1] " jackie.huang 2012-07-23 10:00 ` Richard Purdie @ 2012-09-12 14:02 ` Richard Purdie 1 sibling, 0 replies; 7+ messages in thread From: Richard Purdie @ 2012-09-12 14:02 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: > From: Jackie Huang <jackie.huang@windriver.com> > > do_install needs command 'msgfmt', it would fail if the command > doesn't exist on the host, add DEPENDS gettext-native to fix this. > > [YOCTO #2811] > > Signed-off-by: Jackie Huang <jackie.huang@windriver.com> > --- > meta/recipes-extended/quota/quota_4.00.bb | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Merged to master, thanks. Sorry for the delay on this on, the patch is the correct fix in this case (just a little unusual). Cheers, Richard ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-12 14:16 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-23 8:38 [PATCH 0/1] quota 4.00: add DEPENDS gettext-native jackie.huang 2012-07-23 8:38 ` [PATCH 1/1] " jackie.huang 2012-07-23 10:00 ` Richard Purdie 2012-07-24 5:17 ` jhuang0 2012-08-24 3:18 ` jhuang0 2012-09-06 14:00 ` Ahsan, Noor 2012-09-12 14:02 ` Richard Purdie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox