* [PATCH 0/2] linux-yocto: x32 and features update
@ 2012-09-11 15:17 Bruce Ashfield
2012-09-11 15:17 ` [PATCH 1/2] linux-yocto*: append to KERNEL_FEATURES instead of assigning Bruce Ashfield
2012-09-11 15:17 ` [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook Bruce Ashfield
0 siblings, 2 replies; 11+ messages in thread
From: Bruce Ashfield @ 2012-09-11 15:17 UTC (permalink / raw)
To: richard.purdie; +Cc: openembedded-core, saul.wold
Richard/Saul,
This is my part of a change that Saul will complete with the
addition of x32 as a machine override for x86 BSPs that have
x32 as their tuning.
With this change, the x32 configuration fragment will be appended
to any give x86 BSP configuration and it will support the userspace
tuning.
Also bundled with this change is an associated change to not have
the linux-yocto recipes directly assign KERNEL_FEATURES, but
instead always append to the variable. This allows features like
x32 to be tested by setting the variable in a local.conf or
machine .conf file.
Cheers,
Bruce
cc: Saul Wold <saul.wold@intel.com>
The following changes since commit cc8bfedabfe61a0e06a8a8199f8c0fce4738260a:
linux-yocto/3.4: v3.4.10 and uprobes/kprobes configuration updates (2012-09-10 14:05:15 -0400)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib zedd/x32
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/x32
Bruce Ashfield (2):
linux-yocto*: append to KERNEL_FEATURES instead of assigning
linux-yocto/3.4: add x32 configuration fragment and tuning hook
meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 5 +++--
meta/recipes-kernel/linux/linux-yocto_3.0.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto_3.2.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto_3.4.bb | 5 +++--
6 files changed, 10 insertions(+), 8 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] linux-yocto*: append to KERNEL_FEATURES instead of assigning
2012-09-11 15:17 [PATCH 0/2] linux-yocto: x32 and features update Bruce Ashfield
@ 2012-09-11 15:17 ` Bruce Ashfield
2012-09-11 15:17 ` [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook Bruce Ashfield
1 sibling, 0 replies; 11+ messages in thread
From: Bruce Ashfield @ 2012-09-11 15:17 UTC (permalink / raw)
To: richard.purdie; +Cc: openembedded-core, saul.wold
It is sometimes useful for KERNEL_FEATURES to be set in a machine
or other configuration file. The linux-yocto recipes currently
initialize the variable, which clobbers any values set by .conf
files.
Appending to the variables allows these settings to propagate to
the kernel configuration, while maintaining the existing set of
added kernel features.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto_3.0.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto_3.2.bb | 2 +-
meta/recipes-kernel/linux/linux-yocto_3.4.bb | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb b/meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb
index a16b549..0cdc7c0 100644
--- a/meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb
+++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb
@@ -22,7 +22,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0.git;protocol=git;bareclone
COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
# Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb b/meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb
index 05362ef..a3900ce 100644
--- a/meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb
+++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.2.bb
@@ -23,7 +23,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2.git;protocol=git;bareclone
COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
# Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = "features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
index 3b36378..4fd3845 100644
--- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
+++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
@@ -23,7 +23,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;bareclone
COMPATIBLE_MACHINE = "(qemux86|qemux86-64|qemuarm)"
# Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.0.bb b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
index d16cdf0..e917beb 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.0.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.0.bb
@@ -27,7 +27,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.0;protocol=git;bareclone=1;b
COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
# Functionality flags
-KERNEL_FEATURES = "features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.2.bb b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
index ba4b536..45414d5 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.2.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.2.bb
@@ -27,7 +27,7 @@ SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.2;protocol=git;bareclone=1;b
COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
# Functionality flags
-KERNEL_FEATURES="features/netfilter"
+KERNEL_FEATURES_append=" features/netfilter"
KERNEL_FEATURES_append=" features/taskstats"
KERNEL_FEATURES_append_qemux86=" cfg/sound"
KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
index 7258cba..59ad4b2 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
@@ -24,6 +24,6 @@ COMPATIBLE_MACHINE = "qemuarm|qemux86|qemuppc|qemumips|qemux86-64"
# Functionality flags
KERNEL_REVISION_CHECKING=""
-KERNEL_FEATURES="features/netfilter"
+KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append_qemux86=" cfg/sound"
KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:17 [PATCH 0/2] linux-yocto: x32 and features update Bruce Ashfield
2012-09-11 15:17 ` [PATCH 1/2] linux-yocto*: append to KERNEL_FEATURES instead of assigning Bruce Ashfield
@ 2012-09-11 15:17 ` Bruce Ashfield
2012-09-11 15:33 ` Saul Wold
1 sibling, 1 reply; 11+ messages in thread
From: Bruce Ashfield @ 2012-09-11 15:17 UTC (permalink / raw)
To: richard.purdie; +Cc: openembedded-core, saul.wold
When x32 is the tuning for a x86 MACHINE, the kernel should also have
CONFIG_X86_X32=y.
This can be accomplished by adding the x32 configuraion fragment to the
KERNEL_FEATURES when x32 is the tuning for a given machine.
cc: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
index 4fd3845..156fb93 100644
--- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
+++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
@@ -10,7 +10,7 @@ KMETA = "meta"
SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
-SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
PR = "${INC_PR}.0"
PV = "${LINUX_VERSION}+git${SRCPV}"
@@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append = " features/taskstats"
KERNEL_FEATURES_append_qemux86 = " cfg/sound"
KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
\ No newline at end of file
diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
index 59ad4b2..bcd1292 100644
--- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
+++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
@@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?= "b9a720ca38d298ed457f37d099c85771f9164b19"
SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
-SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
+SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
@@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
KERNEL_FEATURES_append = " features/netfilter"
KERNEL_FEATURES_append_qemux86=" cfg/sound"
KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
+KERNEL_FEATURES_append_x32 = " cfg/x32"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:17 ` [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook Bruce Ashfield
@ 2012-09-11 15:33 ` Saul Wold
2012-09-11 15:39 ` Bruce Ashfield
0 siblings, 1 reply; 11+ messages in thread
From: Saul Wold @ 2012-09-11 15:33 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: openembedded-core
On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
> When x32 is the tuning for a x86 MACHINE, the kernel should also have
> CONFIG_X86_X32=y.
>
> This can be accomplished by adding the x32 configuraion fragment to the
> KERNEL_FEATURES when x32 is the tuning for a given machine.
>
> cc: Saul Wold <sgw@linux.intel.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> index 4fd3845..156fb93 100644
> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> @@ -10,7 +10,7 @@ KMETA = "meta"
>
> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>
> PR = "${INC_PR}.0"
> PV = "${LINUX_VERSION}+git${SRCPV}"
> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
> KERNEL_FEATURES_append = " features/taskstats"
> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
> +KERNEL_FEATURES_append_x32 = " cfg/x32"
Scratch this bit and below, as I think I will use the other mechanism
you talked about to go from a .conf file.
Sau!
> \ No newline at end of file
> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> index 59ad4b2..bcd1292 100644
> --- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> +++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
> @@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?= "b9a720ca38d298ed457f37d099c85771f9164b19"
> SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
> SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
> SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
> -SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>
> SRC_URI = "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
>
> @@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
> KERNEL_FEATURES_append = " features/netfilter"
> KERNEL_FEATURES_append_qemux86=" cfg/sound"
> KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:33 ` Saul Wold
@ 2012-09-11 15:39 ` Bruce Ashfield
2012-09-11 15:41 ` Saul Wold
0 siblings, 1 reply; 11+ messages in thread
From: Bruce Ashfield @ 2012-09-11 15:39 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On 12-09-11 11:33 AM, Saul Wold wrote:
> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
>> CONFIG_X86_X32=y.
>>
>> This can be accomplished by adding the x32 configuraion fragment to the
>> KERNEL_FEATURES when x32 is the tuning for a given machine.
>>
>> cc: Saul Wold <sgw@linux.intel.com>
>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>> ---
>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> index 4fd3845..156fb93 100644
>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> @@ -10,7 +10,7 @@ KMETA = "meta"
>>
>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>>
>> PR = "${INC_PR}.0"
>> PV = "${LINUX_VERSION}+git${SRCPV}"
>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
>> KERNEL_FEATURES_append = " features/taskstats"
>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>
> Scratch this bit and below, as I think I will use the other mechanism
> you talked about to go from a .conf file.
Works for me. The meta change is staged and pushed out, I'll update this
patch to not have the KERNEL_FEATURES portion.
Bruce
>
> Sau!
>
>> \ No newline at end of file
>> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>> b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>> index 59ad4b2..bcd1292 100644
>> --- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>> +++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>> @@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?=
>> "b9a720ca38d298ed457f37d099c85771f9164b19"
>> SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>> SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>> SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>> -SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>>
>> SRC_URI =
>> "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
>>
>>
>> @@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
>> KERNEL_FEATURES_append = " features/netfilter"
>> KERNEL_FEATURES_append_qemux86=" cfg/sound"
>> KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:39 ` Bruce Ashfield
@ 2012-09-11 15:41 ` Saul Wold
2012-09-11 15:58 ` Richard Purdie
0 siblings, 1 reply; 11+ messages in thread
From: Saul Wold @ 2012-09-11 15:41 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: openembedded-core
On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
> On 12-09-11 11:33 AM, Saul Wold wrote:
>> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
>>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
>>> CONFIG_X86_X32=y.
>>>
>>> This can be accomplished by adding the x32 configuraion fragment to the
>>> KERNEL_FEATURES when x32 is the tuning for a given machine.
>>>
>>> cc: Saul Wold <sgw@linux.intel.com>
>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>>> ---
>>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
>>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>> index 4fd3845..156fb93 100644
>>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>> @@ -10,7 +10,7 @@ KMETA = "meta"
>>>
>>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
>>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
>>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>>>
>>> PR = "${INC_PR}.0"
>>> PV = "${LINUX_VERSION}+git${SRCPV}"
>>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
>>> KERNEL_FEATURES_append = " features/taskstats"
>>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
>>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>>
>> Scratch this bit and below, as I think I will use the other mechanism
>> you talked about to go from a .conf file.
>
> Works for me. The meta change is staged and pushed out, I'll update this
> patch to not have the KERNEL_FEATURES portion.
>
Thanks, see my other email to RP, since x32 is a feature that any x86-64
machine might want to enable based on the DEFAULTTUNE it makes more
sense to be in the machine config includes.
Sau!
> Bruce
>
>>
>> Sau!
>>
>>> \ No newline at end of file
>>> diff --git a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>>> b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>>> index 59ad4b2..bcd1292 100644
>>> --- a/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>>> +++ b/meta/recipes-kernel/linux/linux-yocto_3.4.bb
>>> @@ -9,7 +9,7 @@ SRCREV_machine_qemuppc ?=
>>> "b9a720ca38d298ed457f37d099c85771f9164b19"
>>> SRCREV_machine_qemux86 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>>> SRCREV_machine_qemux86-64 ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>>> SRCREV_machine ?= "46d8c757b3be1953f30d6745505d24436e2d6844"
>>> -SRCREV_meta ?= "a82db2f0fc3ceebf3cb47e9dd05e4856ff9966ab"
>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>>>
>>> SRC_URI =
>>> "git://git.yoctoproject.org/linux-yocto-3.4.git;protocol=git;nocheckout=1;branch=${KBRANCH},meta;name=machine,meta"
>>>
>>>
>>>
>>> @@ -27,3 +27,4 @@ KERNEL_REVISION_CHECKING=""
>>> KERNEL_FEATURES_append = " features/netfilter"
>>> KERNEL_FEATURES_append_qemux86=" cfg/sound"
>>> KERNEL_FEATURES_append_qemux86-64=" cfg/sound"
>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>>>
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:41 ` Saul Wold
@ 2012-09-11 15:58 ` Richard Purdie
2012-09-11 16:07 ` Saul Wold
0 siblings, 1 reply; 11+ messages in thread
From: Richard Purdie @ 2012-09-11 15:58 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On Tue, 2012-09-11 at 08:41 -0700, Saul Wold wrote:
> On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
> > On 12-09-11 11:33 AM, Saul Wold wrote:
> >> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
> >>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
> >>> CONFIG_X86_X32=y.
> >>>
> >>> This can be accomplished by adding the x32 configuraion fragment to the
> >>> KERNEL_FEATURES when x32 is the tuning for a given machine.
> >>>
> >>> cc: Saul Wold <sgw@linux.intel.com>
> >>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >>> ---
> >>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
> >>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
> >>> 2 files changed, 4 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>> index 4fd3845..156fb93 100644
> >>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>> @@ -10,7 +10,7 @@ KMETA = "meta"
> >>>
> >>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
> >>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
> >>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
> >>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
> >>>
> >>> PR = "${INC_PR}.0"
> >>> PV = "${LINUX_VERSION}+git${SRCPV}"
> >>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
> >>> KERNEL_FEATURES_append = " features/taskstats"
> >>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
> >>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
> >>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
> >>
> >> Scratch this bit and below, as I think I will use the other mechanism
> >> you talked about to go from a .conf file.
> >
> > Works for me. The meta change is staged and pushed out, I'll update this
> > patch to not have the KERNEL_FEATURES portion.
> >
> Thanks, see my other email to RP, since x32 is a feature that any x86-64
> machine might want to enable based on the DEFAULTTUNE it makes more
> sense to be in the machine config includes.
No, it doesn't.
What we need here is:
-KERNEL_FEATURES_append = " features/taskstats"
+KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
which is simple, effective and to the point. If we start needing lots of
these, we can look at an x32 override but right now I don't see the
need.
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 15:58 ` Richard Purdie
@ 2012-09-11 16:07 ` Saul Wold
2012-09-12 12:25 ` Richard Purdie
0 siblings, 1 reply; 11+ messages in thread
From: Saul Wold @ 2012-09-11 16:07 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 09/11/2012 08:58 AM, Richard Purdie wrote:
> On Tue, 2012-09-11 at 08:41 -0700, Saul Wold wrote:
>> On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
>>> On 12-09-11 11:33 AM, Saul Wold wrote:
>>>> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
>>>>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
>>>>> CONFIG_X86_X32=y.
>>>>>
>>>>> This can be accomplished by adding the x32 configuraion fragment to the
>>>>> KERNEL_FEATURES when x32 is the tuning for a given machine.
>>>>>
>>>>> cc: Saul Wold <sgw@linux.intel.com>
>>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>>>>> ---
>>>>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
>>>>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
>>>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>>>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>>>> index 4fd3845..156fb93 100644
>>>>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>>>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>>>>> @@ -10,7 +10,7 @@ KMETA = "meta"
>>>>>
>>>>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
>>>>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
>>>>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
>>>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>>>>>
>>>>> PR = "${INC_PR}.0"
>>>>> PV = "${LINUX_VERSION}+git${SRCPV}"
>>>>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
>>>>> KERNEL_FEATURES_append = " features/taskstats"
>>>>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
>>>>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
>>>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>>>>
>>>> Scratch this bit and below, as I think I will use the other mechanism
>>>> you talked about to go from a .conf file.
>>>
>>> Works for me. The meta change is staged and pushed out, I'll update this
>>> patch to not have the KERNEL_FEATURES portion.
>>>
>> Thanks, see my other email to RP, since x32 is a feature that any x86-64
>> machine might want to enable based on the DEFAULTTUNE it makes more
>> sense to be in the machine config includes.
>
> No, it doesn't.
>
> What we need here is:
>
> -KERNEL_FEATURES_append = " features/taskstats"
> +KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
>
No, this would then only address the qemu machine, what about all the HW
BSP that might want it, they would need to add this same line. If I add
the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32,
then any x86-64 BSP can just enable that TUNE, isn't that the point of
the machine config tuning?
> which is simple, effective and to the point. If we start needing lots of
> these, we can look at an x32 override but right now I don't see the
> need.
>
And it does not have to be an x32 override, we just set it in the
arch-ia32.inc file where we define that TUNE.
That seems the best way.
Sau!
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-11 16:07 ` Saul Wold
@ 2012-09-12 12:25 ` Richard Purdie
2012-09-12 12:58 ` Bruce Ashfield
0 siblings, 1 reply; 11+ messages in thread
From: Richard Purdie @ 2012-09-12 12:25 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On Tue, 2012-09-11 at 09:07 -0700, Saul Wold wrote:
> On 09/11/2012 08:58 AM, Richard Purdie wrote:
> > On Tue, 2012-09-11 at 08:41 -0700, Saul Wold wrote:
> >> On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
> >>> On 12-09-11 11:33 AM, Saul Wold wrote:
> >>>> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
> >>>>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
> >>>>> CONFIG_X86_X32=y.
> >>>>>
> >>>>> This can be accomplished by adding the x32 configuraion fragment to the
> >>>>> KERNEL_FEATURES when x32 is the tuning for a given machine.
> >>>>>
> >>>>> cc: Saul Wold <sgw@linux.intel.com>
> >>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >>>>> ---
> >>>>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
> >>>>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
> >>>>> 2 files changed, 4 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>>>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>>>> index 4fd3845..156fb93 100644
> >>>>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>>>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >>>>> @@ -10,7 +10,7 @@ KMETA = "meta"
> >>>>>
> >>>>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
> >>>>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
> >>>>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
> >>>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
> >>>>>
> >>>>> PR = "${INC_PR}.0"
> >>>>> PV = "${LINUX_VERSION}+git${SRCPV}"
> >>>>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
> >>>>> KERNEL_FEATURES_append = " features/taskstats"
> >>>>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
> >>>>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
> >>>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
> >>>>
> >>>> Scratch this bit and below, as I think I will use the other mechanism
> >>>> you talked about to go from a .conf file.
> >>>
> >>> Works for me. The meta change is staged and pushed out, I'll update this
> >>> patch to not have the KERNEL_FEATURES portion.
> >>>
> >> Thanks, see my other email to RP, since x32 is a feature that any x86-64
> >> machine might want to enable based on the DEFAULTTUNE it makes more
> >> sense to be in the machine config includes.
> >
> > No, it doesn't.
> >
> > What we need here is:
> >
> > -KERNEL_FEATURES_append = " features/taskstats"
> > +KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
> >
> No, this would then only address the qemu machine, what about all the HW
> BSP that might want it, they would need to add this same line. If I add
> the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32,
> then any x86-64 BSP can just enable that TUNE, isn't that the point of
> the machine config tuning?
It is the point, however, the key part of this you're ignoring is that
the kernel fragment management only happens for linux-yocto. Only the
linux-yocto recipe supports the KERNEL_FEATURES mechanism.
The arch-ia32.inc file and any machine config *cannot* depend on
linux-yocto.
So this glue belongs in linux-yocto. I agree is suboptimal for people
not using it but such is life, there isn't any generic mechanism we can
place this into.
> > which is simple, effective and to the point. If we start needing lots of
> > these, we can look at an x32 override but right now I don't see the
> > need.
> >
> And it does not have to be an x32 override, we just set it in the
> arch-ia32.inc file where we define that TUNE.
>
> That seems the best way.
Its not. See above.
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-12 12:25 ` Richard Purdie
@ 2012-09-12 12:58 ` Bruce Ashfield
2012-09-12 13:48 ` Richard Purdie
0 siblings, 1 reply; 11+ messages in thread
From: Bruce Ashfield @ 2012-09-12 12:58 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core, Saul Wold
On Wed, Sep 12, 2012 at 8:25 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2012-09-11 at 09:07 -0700, Saul Wold wrote:
>> On 09/11/2012 08:58 AM, Richard Purdie wrote:
>> > On Tue, 2012-09-11 at 08:41 -0700, Saul Wold wrote:
>> >> On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
>> >>> On 12-09-11 11:33 AM, Saul Wold wrote:
>> >>>> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
>> >>>>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
>> >>>>> CONFIG_X86_X32=y.
>> >>>>>
>> >>>>> This can be accomplished by adding the x32 configuraion fragment to the
>> >>>>> KERNEL_FEATURES when x32 is the tuning for a given machine.
>> >>>>>
>> >>>>> cc: Saul Wold <sgw@linux.intel.com>
>> >>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>> >>>>> ---
>> >>>>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
>> >>>>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
>> >>>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>> >>>>>
>> >>>>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> >>>>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> >>>>> index 4fd3845..156fb93 100644
>> >>>>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> >>>>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
>> >>>>> @@ -10,7 +10,7 @@ KMETA = "meta"
>> >>>>>
>> >>>>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
>> >>>>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
>> >>>>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
>> >>>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
>> >>>>>
>> >>>>> PR = "${INC_PR}.0"
>> >>>>> PV = "${LINUX_VERSION}+git${SRCPV}"
>> >>>>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
>> >>>>> KERNEL_FEATURES_append = " features/taskstats"
>> >>>>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
>> >>>>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
>> >>>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
>> >>>>
>> >>>> Scratch this bit and below, as I think I will use the other mechanism
>> >>>> you talked about to go from a .conf file.
>> >>>
>> >>> Works for me. The meta change is staged and pushed out, I'll update this
>> >>> patch to not have the KERNEL_FEATURES portion.
>> >>>
>> >> Thanks, see my other email to RP, since x32 is a feature that any x86-64
>> >> machine might want to enable based on the DEFAULTTUNE it makes more
>> >> sense to be in the machine config includes.
>> >
>> > No, it doesn't.
>> >
>> > What we need here is:
>> >
>> > -KERNEL_FEATURES_append = " features/taskstats"
>> > +KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
>> >
>> No, this would then only address the qemu machine, what about all the HW
>> BSP that might want it, they would need to add this same line. If I add
>> the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32,
>> then any x86-64 BSP can just enable that TUNE, isn't that the point of
>> the machine config tuning?
>
> It is the point, however, the key part of this you're ignoring is that
> the kernel fragment management only happens for linux-yocto. Only the
> linux-yocto recipe supports the KERNEL_FEATURES mechanism.
>
> The arch-ia32.inc file and any machine config *cannot* depend on
> linux-yocto.
>
> So this glue belongs in linux-yocto. I agree is suboptimal for people
> not using it but such is life, there isn't any generic mechanism we can
> place this into.
:)
linux-yocto it is, I've respun the patches to include the TUNE_FEATURES check
and pushed them to poky-contrib zedd/x32:
7aeb32 linux-yocto/3.4: add x32 configuration fragment
d34a34c linux-yocto*: append to KERNEL_FEATURES instead of assigning
I don't have a x32 build handy, but I assume Saul will take them for a spin.
If you want a full resend of the series, shout and I'll git send-email them out.
Cheers,
Bruce
>
>> > which is simple, effective and to the point. If we start needing lots of
>> > these, we can look at an x32 override but right now I don't see the
>> > need.
>> >
>> And it does not have to be an x32 override, we just set it in the
>> arch-ia32.inc file where we define that TUNE.
>>
>> That seems the best way.
>
> Its not. See above.
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook
2012-09-12 12:58 ` Bruce Ashfield
@ 2012-09-12 13:48 ` Richard Purdie
0 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2012-09-12 13:48 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: openembedded-core, Saul Wold
On Wed, 2012-09-12 at 08:58 -0400, Bruce Ashfield wrote:
> On Wed, Sep 12, 2012 at 8:25 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Tue, 2012-09-11 at 09:07 -0700, Saul Wold wrote:
> >> On 09/11/2012 08:58 AM, Richard Purdie wrote:
> >> > On Tue, 2012-09-11 at 08:41 -0700, Saul Wold wrote:
> >> >> On 09/11/2012 08:39 AM, Bruce Ashfield wrote:
> >> >>> On 12-09-11 11:33 AM, Saul Wold wrote:
> >> >>>> On 09/11/2012 08:17 AM, Bruce Ashfield wrote:
> >> >>>>> When x32 is the tuning for a x86 MACHINE, the kernel should also have
> >> >>>>> CONFIG_X86_X32=y.
> >> >>>>>
> >> >>>>> This can be accomplished by adding the x32 configuraion fragment to the
> >> >>>>> KERNEL_FEATURES when x32 is the tuning for a given machine.
> >> >>>>>
> >> >>>>> cc: Saul Wold <sgw@linux.intel.com>
> >> >>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >> >>>>> ---
> >> >>>>> meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb | 3 ++-
> >> >>>>> meta/recipes-kernel/linux/linux-yocto_3.4.bb | 3 ++-
> >> >>>>> 2 files changed, 4 insertions(+), 2 deletions(-)
> >> >>>>>
> >> >>>>> diff --git a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >> >>>>> b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >> >>>>> index 4fd3845..156fb93 100644
> >> >>>>> --- a/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >> >>>>> +++ b/meta/recipes-kernel/linux/linux-yocto-rt_3.4.bb
> >> >>>>> @@ -10,7 +10,7 @@ KMETA = "meta"
> >> >>>>>
> >> >>>>> SRCREV_machine ?= "a35693b1287c0e50cdca33a1b95af0ff48b43cd0"
> >> >>>>> SRCREV_machine_qemuppc ?= "85a1190530cb5749f5f831670976b163438dc301"
> >> >>>>> -SRCREV_meta ?= "d9d5fc63d8b38705036e946ea77d971d95de11ad"
> >> >>>>> +SRCREV_meta ?= "e0374ce012e7e6fc8e5bb8b957addb0478950898"
> >> >>>>>
> >> >>>>> PR = "${INC_PR}.0"
> >> >>>>> PV = "${LINUX_VERSION}+git${SRCPV}"
> >> >>>>> @@ -27,3 +27,4 @@ KERNEL_FEATURES_append = " features/netfilter"
> >> >>>>> KERNEL_FEATURES_append = " features/taskstats"
> >> >>>>> KERNEL_FEATURES_append_qemux86 = " cfg/sound"
> >> >>>>> KERNEL_FEATURES_append_qemux86-64 = " cfg/sound"
> >> >>>>> +KERNEL_FEATURES_append_x32 = " cfg/x32"
> >> >>>>
> >> >>>> Scratch this bit and below, as I think I will use the other mechanism
> >> >>>> you talked about to go from a .conf file.
> >> >>>
> >> >>> Works for me. The meta change is staged and pushed out, I'll update this
> >> >>> patch to not have the KERNEL_FEATURES portion.
> >> >>>
> >> >> Thanks, see my other email to RP, since x32 is a feature that any x86-64
> >> >> machine might want to enable based on the DEFAULTTUNE it makes more
> >> >> sense to be in the machine config includes.
> >> >
> >> > No, it doesn't.
> >> >
> >> > What we need here is:
> >> >
> >> > -KERNEL_FEATURES_append = " features/taskstats"
> >> > +KERNEL_FEATURES_append = " features/taskstats ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32", "" ,d)}"
> >> >
> >> No, this would then only address the qemu machine, what about all the HW
> >> BSP that might want it, they would need to add this same line. If I add
> >> the KERNEL_FEATURES_append to the arch-ia32.inc, conditional on mx32,
> >> then any x86-64 BSP can just enable that TUNE, isn't that the point of
> >> the machine config tuning?
> >
> > It is the point, however, the key part of this you're ignoring is that
> > the kernel fragment management only happens for linux-yocto. Only the
> > linux-yocto recipe supports the KERNEL_FEATURES mechanism.
> >
> > The arch-ia32.inc file and any machine config *cannot* depend on
> > linux-yocto.
> >
> > So this glue belongs in linux-yocto. I agree is suboptimal for people
> > not using it but such is life, there isn't any generic mechanism we can
> > place this into.
>
> :)
>
> linux-yocto it is, I've respun the patches to include the TUNE_FEATURES check
> and pushed them to poky-contrib zedd/x32:
>
> 7aeb32 linux-yocto/3.4: add x32 configuration fragment
> d34a34c linux-yocto*: append to KERNEL_FEATURES instead of assigning
>
> I don't have a x32 build handy, but I assume Saul will take them for a spin.
>
> If you want a full resend of the series, shout and I'll git send-email them out.
I've merged this, thanks. I'm assuming Saul will test the end result.
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-09-12 14:01 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11 15:17 [PATCH 0/2] linux-yocto: x32 and features update Bruce Ashfield
2012-09-11 15:17 ` [PATCH 1/2] linux-yocto*: append to KERNEL_FEATURES instead of assigning Bruce Ashfield
2012-09-11 15:17 ` [PATCH 2/2] linux-yocto/3.4: add x32 configuration fragment and tuning hook Bruce Ashfield
2012-09-11 15:33 ` Saul Wold
2012-09-11 15:39 ` Bruce Ashfield
2012-09-11 15:41 ` Saul Wold
2012-09-11 15:58 ` Richard Purdie
2012-09-11 16:07 ` Saul Wold
2012-09-12 12:25 ` Richard Purdie
2012-09-12 12:58 ` Bruce Ashfield
2012-09-12 13:48 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox