Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space
Date: Thu, 27 Sep 2012 08:39:38 -0700	[thread overview]
Message-ID: <5064733A.6000704@linux.intel.com> (raw)
In-Reply-To: <1348753966-45893-1-git-send-email-jason.wessel@windriver.com>

On 09/27/2012 06:52 AM, Jason Wessel wrote:
> Based on the previous commit 604d46c686d06d62d5a07b9c7f4fa170f99307d8
> (Convert tab indentation in python functions into four-space), the
> cml.bbclass was not converted, and in order to properly extend it
> with external bbappend's it needs to be converted.
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
>   meta/classes/cml1.bbclass |   28 ++++++++++++++--------------
>   1 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 37ed792..ba44196 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -15,23 +15,23 @@ HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>   HOST_LOADLIBES = "-lncurses"
>
>   python do_menuconfig() {
> -        try:
> -            mtime = os.path.getmtime(".config")
> -        except OSError:
> -            mtime = 0
> +    try:
> +        mtime = os.path.getmtime(".config")
> +    except OSError:
> +        mtime = 0
>
> -        oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
> +    oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
>
> -        # FIXME this check can be removed when the minimum bitbake version has been bumped
> -        if hasattr(bb.build, 'write_taint'):
> -            try:
> -                newmtime = os.path.getmtime(".config")
> -            except OSError:
> -                newmtime = 0
> +    # FIXME this check can be removed when the minimum bitbake version has been bumped
> +    if hasattr(bb.build, 'write_taint'):
> +        try:
> +            newmtime = os.path.getmtime(".config")
> +        except OSError:
> +            newmtime = 0
>
> -            if newmtime > mtime:
> -                bb.note("Configuration changed, recompile will be forced")
> -                bb.build.write_taint('do_compile', d)
> +        if newmtime > mtime:
> +            bb.note("Configuration changed, recompile will be forced")
> +            bb.build.write_taint('do_compile', d)
>   }
>   do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
>   do_menuconfig[nostamp] = "1"
>

Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-09-27 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 13:52 [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space Jason Wessel
2012-09-27 15:39 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5064733A.6000704@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=jason.wessel@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox