Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space
@ 2012-09-27 13:52 Jason Wessel
  2012-09-27 15:39 ` Saul Wold
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Wessel @ 2012-09-27 13:52 UTC (permalink / raw)
  To: Openembedded-core

Based on the previous commit 604d46c686d06d62d5a07b9c7f4fa170f99307d8
(Convert tab indentation in python functions into four-space), the
cml.bbclass was not converted, and in order to properly extend it
with external bbappend's it needs to be converted.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 meta/classes/cml1.bbclass |   28 ++++++++++++++--------------
 1 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 37ed792..ba44196 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -15,23 +15,23 @@ HOSTLDFLAGS = "${BUILD_LDFLAGS}"
 HOST_LOADLIBES = "-lncurses"
 
 python do_menuconfig() {
-        try:
-            mtime = os.path.getmtime(".config")
-        except OSError:
-            mtime = 0
+    try:
+        mtime = os.path.getmtime(".config")
+    except OSError:
+        mtime = 0
 
-        oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
+    oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
 
-        # FIXME this check can be removed when the minimum bitbake version has been bumped
-        if hasattr(bb.build, 'write_taint'):
-            try:
-                newmtime = os.path.getmtime(".config")
-            except OSError:
-                newmtime = 0
+    # FIXME this check can be removed when the minimum bitbake version has been bumped
+    if hasattr(bb.build, 'write_taint'):
+        try:
+            newmtime = os.path.getmtime(".config")
+        except OSError:
+            newmtime = 0
 
-            if newmtime > mtime:
-                bb.note("Configuration changed, recompile will be forced")
-                bb.build.write_taint('do_compile', d)
+        if newmtime > mtime:
+            bb.note("Configuration changed, recompile will be forced")
+            bb.build.write_taint('do_compile', d)
 }
 do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
 do_menuconfig[nostamp] = "1"
-- 
1.7.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space
  2012-09-27 13:52 [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space Jason Wessel
@ 2012-09-27 15:39 ` Saul Wold
  0 siblings, 0 replies; 2+ messages in thread
From: Saul Wold @ 2012-09-27 15:39 UTC (permalink / raw)
  To: Jason Wessel; +Cc: Openembedded-core

On 09/27/2012 06:52 AM, Jason Wessel wrote:
> Based on the previous commit 604d46c686d06d62d5a07b9c7f4fa170f99307d8
> (Convert tab indentation in python functions into four-space), the
> cml.bbclass was not converted, and in order to properly extend it
> with external bbappend's it needs to be converted.
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
>   meta/classes/cml1.bbclass |   28 ++++++++++++++--------------
>   1 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 37ed792..ba44196 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -15,23 +15,23 @@ HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>   HOST_LOADLIBES = "-lncurses"
>
>   python do_menuconfig() {
> -        try:
> -            mtime = os.path.getmtime(".config")
> -        except OSError:
> -            mtime = 0
> +    try:
> +        mtime = os.path.getmtime(".config")
> +    except OSError:
> +        mtime = 0
>
> -        oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
> +    oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
>
> -        # FIXME this check can be removed when the minimum bitbake version has been bumped
> -        if hasattr(bb.build, 'write_taint'):
> -            try:
> -                newmtime = os.path.getmtime(".config")
> -            except OSError:
> -                newmtime = 0
> +    # FIXME this check can be removed when the minimum bitbake version has been bumped
> +    if hasattr(bb.build, 'write_taint'):
> +        try:
> +            newmtime = os.path.getmtime(".config")
> +        except OSError:
> +            newmtime = 0
>
> -            if newmtime > mtime:
> -                bb.note("Configuration changed, recompile will be forced")
> -                bb.build.write_taint('do_compile', d)
> +        if newmtime > mtime:
> +            bb.note("Configuration changed, recompile will be forced")
> +            bb.build.write_taint('do_compile', d)
>   }
>   do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
>   do_menuconfig[nostamp] = "1"
>

Merged into OE-Core

Thanks
	Sau!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-27 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 13:52 [PATCH] cml1.bbclass: Convert tab indentation in python functions into four-space Jason Wessel
2012-09-27 15:39 ` Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox