From: Robert Yang <liezhi.yang@windriver.com>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] populate_sdk_base.bbclass: check installation machine before installing SDK
Date: Mon, 5 Nov 2012 15:54:42 +0800 [thread overview]
Message-ID: <509770C2.8070202@windriver.com> (raw)
In-Reply-To: <50971D45.6010608@windriver.com>
On 11/05/2012 09:58 AM, Robert Yang wrote:
>
>
> On 11/01/2012 09:23 PM, Laurentiu Palcu wrote:
>> Do not allow installer to continue if the installation machine architecture
>> does not match the intended SDK machine architecture.
>>
>> [YOCTO: #3269]
>>
>> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
>> ---
>> meta/classes/populate_sdk_base.bbclass | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/meta/classes/populate_sdk_base.bbclass
>> b/meta/classes/populate_sdk_base.bbclass
>> index a3ac757..dc715c4 100644
>> --- a/meta/classes/populate_sdk_base.bbclass
>> +++ b/meta/classes/populate_sdk_base.bbclass
>> @@ -118,6 +118,14 @@ fakeroot create_shar() {
>> cat << "EOF" > ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.sh
>> #!/bin/bash
>>
>> +INST_ARCH=$(uname -m | sed -e "s/i[3-6]86/ix86/" -e "s/x86[-_]64/x86_64/")
>> +SDKMACHINE=$(echo ${SDKMACHINE} | sed -e "s/i[5-6]86/ix86/")
>> +
>
> I'm afraid this doesn't work, how does the script know the SDKMACHINE ?
> The SDKMACHINE would always be null in
> poky-eglibc-x86_64-i586-toolchain-gmae-1.3+snapshot-20121104.sh
>
This was because i didn't set the SDKMACHINE, I seldom set it when build
the sdk, but it seems that we should set it since it needs
include conf/machine-sdk/${SDKMACHINE}.conf
Can we check whether the SDKMACHINE is null before build the SDK or use
SDK_ARCH rather than the SDKMACHINE here ? Otherwise, if we don't set the
SDKMACHINE, the SDK would be built, but it can't be installed, we would
always get this error:
Error: Installation machine not supported!
// Robert
> // Robert
>
>
>> +if [ "$INST_ARCH" != "$SDKMACHINE" ]; then
>> + echo "Error: Installation machine not supported!"
>> + exit -1
>> +fi
>> +
>> DEFAULT_INSTALL_DIR="${SDKPATH}"
>> COMPONENTS_LEN=$(echo ".${SDKPATH}" | sed "s/\// /g" | wc -w)
>>
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
next prev parent reply other threads:[~2012-11-05 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 13:23 [PATCH] populate_sdk_base.bbclass: check installation machine before installing SDK Laurentiu Palcu
2012-11-05 1:58 ` Robert Yang
2012-11-05 7:54 ` Robert Yang [this message]
2012-11-05 11:51 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509770C2.8070202@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=laurentiu.palcu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox