[PATCH] libacpi: Remove QA warning: No GNU_HASH in the elf binary

[PATCH] libacpi: Remove QA warning: No GNU_HASH in the elf binary

[Shakeel, Muhammad]

From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

Handle LDFLAGS properly in the Makefile to remove warning:
QA Issue: No GNU_HASH in the elf binary

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 meta/recipes-bsp/libacpi/files/ldflags.patch |   34 ++++++++++++++++++++++++++
 meta/recipes-bsp/libacpi/libacpi_0.2.bb      |    3 ++-
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/libacpi/files/ldflags.patch b/meta/recipes-bsp/libacpi/files/ldflags.patch
new file mode 100644
index 0000000..8049aa8
--- /dev/null
+++ b/meta/recipes-bsp/libacpi/files/ldflags.patch
@@ -0,0 +1,34 @@
+---
+ Makefile  |    3 ++-
+ config.mk |    1 +
+ 2 files changed, 3 insertions(+), 1 deletion(-)
+
+--- libacpi-0.2.orig/Makefile
++++ libacpi-0.2/Makefile
+@@ -19,6 +19,7 @@ options:
+ 	@echo "CFLAGS   = ${CFLAGS}"
+ 	@echo "CC       = ${CC}"
+ 	@echo "SOFLAGS  = ${SOFLAGS}"
++	@echo "LDFLAGS  = ${LDFLAGS}"
+ 	@echo "LD       = ${LD}"
+ 
+ .c.o:
+@@ -34,7 +35,7 @@ libacpi.a: ${OBJ}
+ 
+ libacpi.so: ${OBJ}
+ 	@echo LD $@
+-	@${CC} ${SOFLAGS} -o $@.${SOVERSION} ${OBJ}
++	@${CC} ${SOFLAGS} ${LDFLAGS} -o $@.${SOVERSION} ${OBJ}
+ 
+ test-libacpi: ${OBJ_test}
+ 	@echo LD $@
+--- libacpi-0.2.orig/config.mk
++++ libacpi-0.2/config.mk
+@@ -10,6 +10,7 @@ MANPREFIX = ${PREFIX}/share/man
+ SOFLAGS = -shared -Wl,-soname,${SONAME}
+ CFLAGS += -fPIC -g --pedantic -Wall -Wextra
+ ARFLAGS = cr
++LDFLAGS =
+ 
+ # Compiler and linker
+ CC = cc
diff --git a/meta/recipes-bsp/libacpi/libacpi_0.2.bb b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
index b0fbf0b..f4c323d 100644
--- a/meta/recipes-bsp/libacpi/libacpi_0.2.bb
+++ b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
@@ -10,7 +10,8 @@ PR = "r6"
 SRC_URI = "http://www.ngolde.de/download/libacpi-${PV}.tar.gz \
 	   file://makefile-fix.patch \
 	   file://libacpi_fix_for_x32.patch \
-	   file://use_correct_strip_in_cross_environment.patch"
+	   file://use_correct_strip_in_cross_environment.patch \
+	   file://ldflags.patch "
 
 SRC_URI[md5sum] = "05b53dd7bead66dda35fec502b91066c"
 SRC_URI[sha256sum] = "13086e31d428b9c125954d48ac497b754bbbce2ef34ea29ecd903e82e25bad29"
-- 
1.7.9.5

Re: [PATCH] libacpi: Remove QA warning: No GNU_HASH in the elf binary

[Saul Wold]

On 12/11/2012 12:12 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> Handle LDFLAGS properly in the Makefile to remove warning:
> QA Issue: No GNU_HASH in the elf binary
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
>   meta/recipes-bsp/libacpi/files/ldflags.patch |   34 ++++++++++++++++++++++++++
>   meta/recipes-bsp/libacpi/libacpi_0.2.bb      |    3 ++-
>   2 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/libacpi/files/ldflags.patch b/meta/recipes-bsp/libacpi/files/ldflags.patch
> new file mode 100644
> index 0000000..8049aa8
> --- /dev/null
> +++ b/meta/recipes-bsp/libacpi/files/ldflags.patch
> @@ -0,0 +1,34 @@

There is no patch header, this needs an Upstream-Status and Signed-off-by:

Thanks
	Sau!


> +---
> + Makefile  |    3 ++-
> + config.mk |    1 +
> + 2 files changed, 3 insertions(+), 1 deletion(-)
> +
> +--- libacpi-0.2.orig/Makefile
> ++++ libacpi-0.2/Makefile
> +@@ -19,6 +19,7 @@ options:
> + 	@echo "CFLAGS   = ${CFLAGS}"
> + 	@echo "CC       = ${CC}"
> + 	@echo "SOFLAGS  = ${SOFLAGS}"
> ++	@echo "LDFLAGS  = ${LDFLAGS}"
> + 	@echo "LD       = ${LD}"
> +
> + .c.o:
> +@@ -34,7 +35,7 @@ libacpi.a: ${OBJ}
> +
> + libacpi.so: ${OBJ}
> + 	@echo LD $@
> +-	@${CC} ${SOFLAGS} -o $@.${SOVERSION} ${OBJ}
> ++	@${CC} ${SOFLAGS} ${LDFLAGS} -o $@.${SOVERSION} ${OBJ}
> +
> + test-libacpi: ${OBJ_test}
> + 	@echo LD $@
> +--- libacpi-0.2.orig/config.mk
> ++++ libacpi-0.2/config.mk
> +@@ -10,6 +10,7 @@ MANPREFIX = ${PREFIX}/share/man
> + SOFLAGS = -shared -Wl,-soname,${SONAME}
> + CFLAGS += -fPIC -g --pedantic -Wall -Wextra
> + ARFLAGS = cr
> ++LDFLAGS =
> +
> + # Compiler and linker
> + CC = cc
> diff --git a/meta/recipes-bsp/libacpi/libacpi_0.2.bb b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> index b0fbf0b..f4c323d 100644
> --- a/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> +++ b/meta/recipes-bsp/libacpi/libacpi_0.2.bb
> @@ -10,7 +10,8 @@ PR = "r6"
>   SRC_URI = "http://www.ngolde.de/download/libacpi-${PV}.tar.gz \
>   	   file://makefile-fix.patch \
>   	   file://libacpi_fix_for_x32.patch \
> -	   file://use_correct_strip_in_cross_environment.patch"
> +	   file://use_correct_strip_in_cross_environment.patch \
> +	   file://ldflags.patch "
>
>   SRC_URI[md5sum] = "05b53dd7bead66dda35fec502b91066c"
>   SRC_URI[sha256sum] = "13086e31d428b9c125954d48ac497b754bbbce2ef34ea29ecd903e82e25bad29"
>