* [PATCH] bluez4: add readline dependency @ 2013-04-08 12:56 Alex DAMIAN 2013-04-08 17:57 ` Saul Wold 2013-04-22 17:15 ` Javier Viguera 0 siblings, 2 replies; 8+ messages in thread From: Alex DAMIAN @ 2013-04-08 12:56 UTC (permalink / raw) To: paul.eggleton, raj.khem, cristian.iorga, openembedded-core Cc: Alexandru DAMIAN From: Alexandru DAMIAN <alexandru.damian@intel.com> bluez4 uses readline to be build, but the dependency is not listed This is listed in the configuration log. So we add it. Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com> --- meta/recipes-connectivity/bluez/bluez4.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc index bff24d3..42d82b0 100644 --- a/meta/recipes-connectivity/bluez/bluez4.inc +++ b/meta/recipes-connectivity/bluez/bluez4.inc @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \ file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191" -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" RDEPENDS_${PN}-dev = "bluez-hcidump" PACKAGECONFIG ??= "\ -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-08 12:56 [PATCH] bluez4: add readline dependency Alex DAMIAN @ 2013-04-08 17:57 ` Saul Wold 2013-04-08 18:19 ` Mark Hatle 2013-04-09 14:52 ` Damian, Alexandru 2013-04-22 17:15 ` Javier Viguera 1 sibling, 2 replies; 8+ messages in thread From: Saul Wold @ 2013-04-08 17:57 UTC (permalink / raw) To: Alex DAMIAN; +Cc: paul.eggleton, openembedded-core On 04/08/2013 05:56 AM, Alex DAMIAN wrote: > From: Alexandru DAMIAN <alexandru.damian@intel.com> > > bluez4 uses readline to be build, but the dependency is not listed > This is listed in the configuration log. > So we add it. > As far as I can tell it's needed only for gatttool, is this a tool that we need / want to provide for bluez? This seems to be a tools for viewing the Generic Attribute Profile (GATT). It can be disabled by setting "ac_cv_lib_readline_main=no" Sau! > Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com> > --- > meta/recipes-connectivity/bluez/bluez4.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc > index bff24d3..42d82b0 100644 > --- a/meta/recipes-connectivity/bluez/bluez4.inc > +++ b/meta/recipes-connectivity/bluez/bluez4.inc > @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ > file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ > file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \ > file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191" > -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" > +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" > RDEPENDS_${PN}-dev = "bluez-hcidump" > > PACKAGECONFIG ??= "\ > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-08 17:57 ` Saul Wold @ 2013-04-08 18:19 ` Mark Hatle 2013-04-09 14:52 ` Damian, Alexandru 1 sibling, 0 replies; 8+ messages in thread From: Mark Hatle @ 2013-04-08 18:19 UTC (permalink / raw) To: openembedded-core On 4/8/13 12:57 PM, Saul Wold wrote: > On 04/08/2013 05:56 AM, Alex DAMIAN wrote: >> From: Alexandru DAMIAN <alexandru.damian@intel.com> >> >> bluez4 uses readline to be build, but the dependency is not listed >> This is listed in the configuration log. >> So we add it. >> > As far as I can tell it's needed only for gatttool, is this a tool that > we need / want to provide for bluez? > > This seems to be a tools for viewing the Generic Attribute Profile (GATT). > > It can be disabled by setting "ac_cv_lib_readline_main=no" We -really- want to avoid readline if possible, as it brings in GPLv3 dependencies into the system. If that tool is generically useful, I'd suggest a PACKAGECONFIG setting then. --Mark > > Sau! > > >> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com> >> --- >> meta/recipes-connectivity/bluez/bluez4.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc >> index bff24d3..42d82b0 100644 >> --- a/meta/recipes-connectivity/bluez/bluez4.inc >> +++ b/meta/recipes-connectivity/bluez/bluez4.inc >> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ >> file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ >> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \ >> file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191" >> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" >> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" >> RDEPENDS_${PN}-dev = "bluez-hcidump" >> >> PACKAGECONFIG ??= "\ >> > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-08 17:57 ` Saul Wold 2013-04-08 18:19 ` Mark Hatle @ 2013-04-09 14:52 ` Damian, Alexandru 2013-04-09 14:58 ` Iorga, Cristian 1 sibling, 1 reply; 8+ messages in thread From: Damian, Alexandru @ 2013-04-09 14:52 UTC (permalink / raw) To: Saul Wold; +Cc: Paul Eggleton, Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 1752 bytes --] I guess it's up to the patch maintainer to decide :). Alex On Mon, Apr 8, 2013 at 8:57 PM, Saul Wold <sgw@linux.intel.com> wrote: > On 04/08/2013 05:56 AM, Alex DAMIAN wrote: > >> From: Alexandru DAMIAN <alexandru.damian@intel.com> >> >> bluez4 uses readline to be build, but the dependency is not listed >> This is listed in the configuration log. >> So we add it. >> >> As far as I can tell it's needed only for gatttool, is this a tool that > we need / want to provide for bluez? > > This seems to be a tools for viewing the Generic Attribute Profile (GATT). > > It can be disabled by setting "ac_cv_lib_readline_main=no" > > > Sau! > > > > Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com> >> --- >> meta/recipes-connectivity/**bluez/bluez4.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-connectivity/**bluez/bluez4.inc >> b/meta/recipes-connectivity/**bluez/bluez4.inc >> index bff24d3..42d82b0 100644 >> --- a/meta/recipes-connectivity/**bluez/bluez4.inc >> +++ b/meta/recipes-connectivity/**bluez/bluez4.inc >> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=** >> 12f884d2ae1ff87c09e5b7ccc2c4ca**7e \ >> file://COPYING.LIB;md5=** >> fb504b67c50331fc78734fed90fb0e**09 \ >> file://src/main.c;beginline=1;**endline=24;md5=** >> 9bc54b93cd7e17bf03f52513f39f92**6e \ >> file://sbc/sbc.c;beginline=1;**endline=25;md5=** >> 1a40781ed30d50d8639323a184aeb1**91" >> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" >> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" >> RDEPENDS_${PN}-dev = "bluez-hcidump" >> >> PACKAGECONFIG ??= "\ >> >> [-- Attachment #2: Type: text/html, Size: 2710 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-09 14:52 ` Damian, Alexandru @ 2013-04-09 14:58 ` Iorga, Cristian 2013-04-09 15:04 ` Burton, Ross 0 siblings, 1 reply; 8+ messages in thread From: Iorga, Cristian @ 2013-04-09 14:58 UTC (permalink / raw) To: Damian, Alexandru, Saul Wold Cc: Paul Eggleton, Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2602 bytes --] GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE). However, it will be useful once Bluez5 will be in place. I say we should add it. Regards, Cristian From: Damian, Alexandru [mailto:alexandru.damian@intel.com] Sent: Tuesday, April 09, 2013 5:53 PM To: Saul Wold Cc: Paul Eggleton; Khem Raj; Iorga, Cristian; Patches and discussions about the oe-core layer Subject: Re: [OE-core] [PATCH] bluez4: add readline dependency I guess it's up to the patch maintainer to decide :). Alex On Mon, Apr 8, 2013 at 8:57 PM, Saul Wold <sgw@linux.intel.com<mailto:sgw@linux.intel.com>> wrote: On 04/08/2013 05:56 AM, Alex DAMIAN wrote: From: Alexandru DAMIAN <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> bluez4 uses readline to be build, but the dependency is not listed This is listed in the configuration log. So we add it. As far as I can tell it's needed only for gatttool, is this a tool that we need / want to provide for bluez? This seems to be a tools for viewing the Generic Attribute Profile (GATT). It can be disabled by setting "ac_cv_lib_readline_main=no" Sau! Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>> --- meta/recipes-connectivity/bluez/bluez4.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc index bff24d3..42d82b0 100644 --- a/meta/recipes-connectivity/bluez/bluez4.inc +++ b/meta/recipes-connectivity/bluez/bluez4.inc @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \ file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191<file:///\\COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\src\main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\sbc\sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191>" -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" RDEPENDS_${PN}-dev = "bluez-hcidump" PACKAGECONFIG ??= "\ [-- Attachment #2: Type: text/html, Size: 7216 bytes --] ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-09 14:58 ` Iorga, Cristian @ 2013-04-09 15:04 ` Burton, Ross 2013-04-09 15:11 ` Saul Wold 0 siblings, 1 reply; 8+ messages in thread From: Burton, Ross @ 2013-04-09 15:04 UTC (permalink / raw) To: Iorga, Cristian Cc: Patches and discussions about the oe-core layer, Paul Eggleton, Damian, Alexandru On 9 April 2013 15:58, Iorga, Cristian <cristian.iorga@intel.com> wrote: > GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE). > > However, it will be useful once Bluez5 will be in place. > > I say we should add it. As it's a tool that does introduce extra dependencies, we can easily packageconfig it to let people chose. Ross ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-09 15:04 ` Burton, Ross @ 2013-04-09 15:11 ` Saul Wold 0 siblings, 0 replies; 8+ messages in thread From: Saul Wold @ 2013-04-09 15:11 UTC (permalink / raw) To: Burton, Ross Cc: Paul Eggleton, Damian, Alexandru, Patches and discussions about the oe-core layer On 04/09/2013 08:04 AM, Burton, Ross wrote: > On 9 April 2013 15:58, Iorga, Cristian <cristian.iorga@intel.com> wrote: >> GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE). >> >> However, it will be useful once Bluez5 will be in place. >> >> I say we should add it. > > As it's a tool that does introduce extra dependencies, we can easily > packageconfig it to let people chose. > As Mark also said this, I would agree this should be a PACKAGECONFIG and the tool packaged in it's own package. Sau! > Ross > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] bluez4: add readline dependency 2013-04-08 12:56 [PATCH] bluez4: add readline dependency Alex DAMIAN 2013-04-08 17:57 ` Saul Wold @ 2013-04-22 17:15 ` Javier Viguera 1 sibling, 0 replies; 8+ messages in thread From: Javier Viguera @ 2013-04-22 17:15 UTC (permalink / raw) To: openembedded-core Hi all, On 08/04/13 14:56, Alex DAMIAN wrote: > -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck" > +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline" I saw this patch got included in oe-core and poky *master* branch as-is (not using PACKAGECONFIG). I was bitten by this problem using *danny* branches as well. Any chance that this fix gets also cherry-picked to danny? - Javier Viguera Software Engineer Digi International® Spain S.A.U. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-04-22 17:40 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-08 12:56 [PATCH] bluez4: add readline dependency Alex DAMIAN 2013-04-08 17:57 ` Saul Wold 2013-04-08 18:19 ` Mark Hatle 2013-04-09 14:52 ` Damian, Alexandru 2013-04-09 14:58 ` Iorga, Cristian 2013-04-09 15:04 ` Burton, Ross 2013-04-09 15:11 ` Saul Wold 2013-04-22 17:15 ` Javier Viguera
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox