[PATCH 0/2] switch to using busybox instead of tinylogin

[PATCH 0/2] switch to using busybox instead of tinylogin

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

The following changes since commit 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:

  ref-manual: Added xmlto and dblatex packages for docs (2013-05-22 17:23:41 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox

Chen Qi (2):
  packagegroup-core-boot: use busybox as the default login manager
  busybox: enable login/password commands by default

 meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26 ++++++++++----------
 .../packagegroups/packagegroup-core-boot.bb        |    2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

-- 
1.7.9.5

[PATCH 1/2] packagegroup-core-boot: use busybox as the default login manager

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

tinylogin has been deprecated and the functionality ported into busybox.
So we switch to using busybox instead of tinylogin.

[YOCTO #4207]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 .../packagegroups/packagegroup-core-boot.bb        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index 9306a34..d69c41d 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -25,7 +25,7 @@ RCONFLICTS_${PN} = "task-core-boot"
 
 # Distro can override the following VIRTUAL-RUNTIME providers:
 VIRTUAL-RUNTIME_dev_manager ?= "udev"
-VIRTUAL-RUNTIME_login_manager ?= "tinylogin"
+VIRTUAL-RUNTIME_login_manager ?= "busybox"
 VIRTUAL-RUNTIME_init_manager ?= "sysvinit"
 VIRTUAL-RUNTIME_initscripts ?= "initscripts"
 VIRTUAL-RUNTIME_keymaps ?= "keymaps"
-- 
1.7.9.5

[PATCH 2/2] busybox: enable login/password commands by default

[Qi.Chen]

From: Chen Qi <Qi.Chen@windriver.com>

As we switch to using busybox as the default login manager, we here
modify the defconfig file of busybox to enable the commands that
were previously provided by tinylogin.

These commands are: addgroup, adduser, delgroup, deluser, login, su,
getty, sulogin, passwd and vlock.

[YOCTO #4207]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox-1.20.2/defconfig b/meta/recipes-core/busybox/busybox-1.20.2/defconfig
index bdfdadf..72f792d 100644
--- a/meta/recipes-core/busybox/busybox-1.20.2/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.20.2/defconfig
@@ -449,39 +449,39 @@ CONFIG_INIT_TERMINAL_TYPE=""
 #
 # CONFIG_ADD_SHELL is not set
 # CONFIG_REMOVE_SHELL is not set
-# CONFIG_FEATURE_SHADOWPASSWDS is not set
+CONFIG_FEATURE_SHADOWPASSWDS=y
 # CONFIG_USE_BB_PWD_GRP is not set
 # CONFIG_USE_BB_SHADOW is not set
 CONFIG_USE_BB_CRYPT=y
 # CONFIG_USE_BB_CRYPT_SHA is not set
-# CONFIG_ADDUSER is not set
-# CONFIG_FEATURE_ADDUSER_LONG_OPTIONS is not set
+CONFIG_ADDUSER=y
+CONFIG_FEATURE_ADDUSER_LONG_OPTIONS=y
 # CONFIG_FEATURE_CHECK_NAMES is not set
 CONFIG_FIRST_SYSTEM_ID=0
 CONFIG_LAST_SYSTEM_ID=0
-# CONFIG_ADDGROUP is not set
-# CONFIG_FEATURE_ADDGROUP_LONG_OPTIONS is not set
+CONFIG_ADDGROUP=y
+CONFIG_FEATURE_ADDGROUP_LONG_OPTIONS=y
 # CONFIG_FEATURE_ADDUSER_TO_GROUP is not set
-# CONFIG_DELUSER is not set
-# CONFIG_DELGROUP is not set
+CONFIG_DELUSER=y
+CONFIG_DELGROUP=y
 # CONFIG_FEATURE_DEL_USER_FROM_GROUP is not set
-# CONFIG_GETTY is not set
-# CONFIG_LOGIN is not set
+CONFIG_GETTY=y
+CONFIG_LOGIN=y
 # CONFIG_LOGIN_SESSION_AS_CHILD is not set
 # CONFIG_PAM is not set
 # CONFIG_LOGIN_SCRIPTS is not set
 # CONFIG_FEATURE_NOLOGIN is not set
 # CONFIG_FEATURE_SECURETTY is not set
-# CONFIG_PASSWD is not set
+CONFIG_PASSWD=y
 # CONFIG_FEATURE_PASSWD_WEAK_CHECK is not set
 # CONFIG_CRYPTPW is not set
 # CONFIG_CHPASSWD is not set
 CONFIG_FEATURE_DEFAULT_PASSWD_ALGO=""
-# CONFIG_SU is not set
+CONFIG_SU=y
 # CONFIG_FEATURE_SU_SYSLOG is not set
 # CONFIG_FEATURE_SU_CHECKS_SHELLS is not set
-# CONFIG_SULOGIN is not set
-# CONFIG_VLOCK is not set
+CONFIG_SULOGIN=y
+CONFIG_VLOCK=y
 
 #
 # Linux Ext2 FS Progs
-- 
1.7.9.5

Re: [PATCH 2/2] busybox: enable login/password commands by default

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On Tue, May 28, 2013 at 2:39 AM, <Qi.Chen@windriver.com> wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
>
> As we switch to using busybox as the default login manager, we here
> modify the defconfig file of busybox to enable the commands that
> were previously provided by tinylogin.
>
> These commands are: addgroup, adduser, delgroup, deluser, login, su,
> getty, sulogin, passwd and vlock.
>
> [YOCTO #4207]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>

This patch needs to be applied before packagegroup one.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[-- Attachment #2: Type: text/html, Size: 1339 bytes --]

Re: [PATCH 0/2] switch to using busybox instead of tinylogin

[Jonathan Liu]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

On 28 May 2013 15:39, <Qi.Chen@windriver.com> wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
>
> The following changes since commit
> 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>   ref-manual: Added xmlto and dblatex packages for docs (2013-05-22
> 17:23:41 +0100)
>
> are available in the git repository at:
>
>   git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
>
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
> Chen Qi (2):
>   packagegroup-core-boot: use busybox as the default login manager
>   busybox: enable login/password commands by default
>
>  meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26
> ++++++++++----------
>  .../packagegroups/packagegroup-core-boot.bb        |    2 +-
>  2 files changed, 14 insertions(+), 14 deletions(-)
>

After switching from tinylogin to busybox, the following commands that used
to be provided by tinylogin are provided by other packages instead of
busybox:
-/bin/login [shadow]
-/sbin/getty [util-linux-agetty]
-/usr/bin/passwd  [shadow]
-/usr/bin/su [shadow]

Perhaps util-linux-agetty and shadow packages have higher alternatives
priority?

Regards,
Jonathan

[-- Attachment #2: Type: text/html, Size: 2051 bytes --]

Re: [PATCH 0/2] switch to using busybox instead of tinylogin

[ChenQi]

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

On 05/28/2013 02:25 PM, Jonathan Liu wrote:
> On 28 May 2013 15:39, <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     From: Chen Qi <Qi.Chen@windriver.com <mailto:Qi.Chen@windriver.com>>
>
>     The following changes since commit
>     21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>       ref-manual: Added xmlto and dblatex packages for docs
>     (2013-05-22 17:23:41 +0100)
>
>     are available in the git repository at:
>
>       git://git.pokylinux.org/poky-contrib
>     <http://git.pokylinux.org/poky-contrib> ChenQi/tinylogin-busybox
>     http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
>     Chen Qi (2):
>       packagegroup-core-boot: use busybox as the default login manager
>       busybox: enable login/password commands by default
>
>      meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26
>     ++++++++++----------
>      .../packagegroups/packagegroup-core-boot.bb
>     <http://packagegroup-core-boot.bb>        |    2 +-
>      2 files changed, 14 insertions(+), 14 deletions(-)
>
>
> After switching from tinylogin to busybox, the following commands that 
> used to be provided by tinylogin are provided by other packages 
> instead of busybox:
> -/bin/login [shadow]
> -/sbin/getty [util-linux-agetty]
> -/usr/bin/passwd  [shadow]
> -/usr/bin/su [shadow]
>
> Perhaps util-linux-agetty and shadow packages have higher alternatives 
> priority?
>
The answer seems to be 'yes'.

meta/recipes-core/busybox/busybox.inc:ALTERNATIVE_PRIORITY = "50"
meta/recipes-extended/shadow/shadow_4.1.4.3.bb:ALTERNATIVE_PRIORITY = "200"
meta/recipes-core/util-linux/util-linux.inc:ALTERNATIVE_PRIORITY = "100"

//Chen Qi

> Regards,
> Jonathan


[-- Attachment #2: Type: text/html, Size: 4094 bytes --]

Re: [PATCH 0/2] switch to using busybox instead of tinylogin

[Saul Wold]

On 05/28/2013 02:39 PM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> The following changes since commit 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>    ref-manual: Added xmlto and dblatex packages for docs (2013-05-22 17:23:41 +0100)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
> Chen Qi (2):
>    packagegroup-core-boot: use busybox as the default login manager
>    busybox: enable login/password commands by default
>
As Otavio suggested, these need to be re-ordered.

Does this all work correctly without the need to use "setuid" of the 
busybox binary, it seems we currently are doing setuid for the busybox 
binary since we include SUID app, but what would happen to tinylogin if 
we remove that?

Sau!

>   meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26 ++++++++++----------
>   .../packagegroups/packagegroup-core-boot.bb        |    2 +-
>   2 files changed, 14 insertions(+), 14 deletions(-)
>