* [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
@ 2013-07-08 17:16 eu
2013-07-10 18:50 ` Saul Wold
0 siblings, 1 reply; 6+ messages in thread
From: eu @ 2013-07-08 17:16 UTC (permalink / raw)
To: openembedded-core
From: "Felipe F. Tonello" <eu@felipetonello.com>
When installing pulseaudio-module-console-kit package in an image the
consolekit dependecy cannot be find. This patch makes sure that the consolekit
recipe will be build.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index e4fc648..f925e7d 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
file://src/pulsecore/resampler.h;beginline=4;endline=23;md5=c3d539b93f8c82a1780bfa3cfa544a95"
DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool"
# optional
-DEPENDS += "udev alsa-lib glib-2.0 dbus gconf"
+DEPENDS += "udev alsa-lib glib-2.0 dbus gconf consolekit"
SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
file://gcc4-compile-fix.patch \
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
2013-07-08 17:16 [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package eu
@ 2013-07-10 18:50 ` Saul Wold
2013-07-11 10:32 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Saul Wold @ 2013-07-10 18:50 UTC (permalink / raw)
To: eu; +Cc: openembedded-core
On 07/08/2013 10:16 AM, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> When installing pulseaudio-module-console-kit package in an image the
> consolekit dependecy cannot be find. This patch makes sure that the consolekit
> recipe will be build.
>
Is this really a build-time dependency or a runtime dependency specific
to the pulseaudio-module?
Sau!
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
> meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index e4fc648..f925e7d 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
> file://src/pulsecore/resampler.h;beginline=4;endline=23;md5=c3d539b93f8c82a1780bfa3cfa544a95"
> DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool"
> # optional
> -DEPENDS += "udev alsa-lib glib-2.0 dbus gconf"
> +DEPENDS += "udev alsa-lib glib-2.0 dbus gconf consolekit"
>
> SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
> file://gcc4-compile-fix.patch \
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
2013-07-10 18:50 ` Saul Wold
@ 2013-07-11 10:32 ` Burton, Ross
2013-07-11 12:20 ` Paul Eggleton
2013-07-11 12:26 ` Martin Jansa
0 siblings, 2 replies; 6+ messages in thread
From: Burton, Ross @ 2013-07-11 10:32 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> Is this really a build-time dependency or a runtime dependency specific to
> the pulseaudio-module?
It's a runtime dependency, but from memory bitbake doesn't manage to
piece the chain together enough to actually build consolekit (probably
because the packages are dynamically created).
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
2013-07-11 10:32 ` Burton, Ross
@ 2013-07-11 12:20 ` Paul Eggleton
2013-07-11 12:26 ` Martin Jansa
1 sibling, 0 replies; 6+ messages in thread
From: Paul Eggleton @ 2013-07-11 12:20 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Thursday 11 July 2013 11:32:14 Burton, Ross wrote:
> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> > Is this really a build-time dependency or a runtime dependency specific to
> > the pulseaudio-module?
>
> It's a runtime dependency, but from memory bitbake doesn't manage to
> piece the chain together enough to actually build consolekit (probably
> because the packages are dynamically created).
If it's a stated RDEPENDS in the recipe it must be, and pulseaudio.inc already
has RDEPENDS_pulseaudio-module-console-kit =+ "consolekit" so unless the
module package doesn't actually end up being "pulseaudio-module-console-kit"
I'm not sure why anything else should be needed. It's usually only when the
dependencies get added dynamically at package time that bitbake not building a
dependency can be a problem (we've seen this with recipes containing perl
scripts for example).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
2013-07-11 10:32 ` Burton, Ross
2013-07-11 12:20 ` Paul Eggleton
@ 2013-07-11 12:26 ` Martin Jansa
2013-07-16 22:07 ` Felipe Tonello
1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2013-07-11 12:26 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Thu, Jul 11, 2013 at 11:32:14AM +0100, Burton, Ross wrote:
> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> > Is this really a build-time dependency or a runtime dependency specific to
> > the pulseaudio-module?
>
> It's a runtime dependency, but from memory bitbake doesn't manage to
> piece the chain together enough to actually build consolekit (probably
> because the packages are dynamically created).
The problem is that RDEPENDS_<dynamic_package> = "foo"
doesn't enforce foo to be built before <dynamic_package> is used in
image:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=3498
So if <dynamic_package> is the only thing pulling "foo" into the image
you can get do_rootfs error about missing "foo".
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
2013-07-11 12:26 ` Martin Jansa
@ 2013-07-16 22:07 ` Felipe Tonello
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Tonello @ 2013-07-16 22:07 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
Hi Martin,
On Thu, Jul 11, 2013 at 5:26 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Jul 11, 2013 at 11:32:14AM +0100, Burton, Ross wrote:
>> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
>> > Is this really a build-time dependency or a runtime dependency specific to
>> > the pulseaudio-module?
>>
>> It's a runtime dependency, but from memory bitbake doesn't manage to
>> piece the chain together enough to actually build consolekit (probably
>> because the packages are dynamically created).
>
> The problem is that RDEPENDS_<dynamic_package> = "foo"
> doesn't enforce foo to be built before <dynamic_package> is used in
> image:
>
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=3498
>
> So if <dynamic_package> is the only thing pulling "foo" into the image
> you can get do_rootfs error about missing "foo".
>
> Cheers,
>
Yes, that's exactly what happens. I added this dep in my bbappend for
a temporary fix, but I would like to see a final fix for it.
Regards,
Felipe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-16 22:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-08 17:16 [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package eu
2013-07-10 18:50 ` Saul Wold
2013-07-11 10:32 ` Burton, Ross
2013-07-11 12:20 ` Paul Eggleton
2013-07-11 12:26 ` Martin Jansa
2013-07-16 22:07 ` Felipe Tonello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox