* [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine
@ 2013-07-29 3:58 Bian Naimeng
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 3:58 UTC (permalink / raw)
To: openembedded-core
The main purposes are following.
- make it possible for developers/distributor to customize their specific machine
based common machine configurations such as meta/conf/machine/inc/qemuxx.inc
- make our specific machine compatible with bb file which depends on COMPATIBLE_MACHINE="qemuxx|..."
- easy to developers to merge mainline to their branch which containing specific machine.
Bian Naimeng (6):
qemuarm.conf: provide a common qemuarm machine configuration,
so developer/distributor can customize their specific one.
qemuxmips64.conf: provide a common qemuxmips64 machine configuration,
so developer/distributor can customize their specific one.
qemumips.conf: provide a common qemumips machine configuration,
so developer/distributor can customize their specific one.
qemuppc.conf: provide a common qemuppc machine configuration,
so developer/distributor can customize their specific one.
qemux86-64.conf: provide a common qemux86-64 machine configuration,
so developer/distributor can customize their specific one.
qemux86.conf: provide a common qemux86 machine configuration,
so developer/distributor can customize their specific one.
meta/conf/machine/include/qemuarm.inc | 10 ++++++++++
meta/conf/machine/include/qemumips.inc | 11 +++++++++++
meta/conf/machine/include/qemumips64.inc | 11 +++++++++++
meta/conf/machine/include/qemuppc.inc | 9 +++++++++
meta/conf/machine/include/qemux86-64.inc | 24 ++++++++++++++++++++++++
meta/conf/machine/include/qemux86.inc | 24 ++++++++++++++++++++++++
meta/conf/machine/qemuarm.conf | 10 ++--------
meta/conf/machine/qemumips.conf | 12 ++----------
meta/conf/machine/qemumips64.conf | 12 ++----------
meta/conf/machine/qemuppc.conf | 8 +-------
meta/conf/machine/qemux86-64.conf | 23 +----------------------
meta/conf/machine/qemux86.conf | 25 ++-----------------------
12 files changed, 99 insertions(+), 80 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
@ 2013-07-29 4:02 ` Bian Naimeng
2013-07-29 15:36 ` Phil Blundell
2013-07-29 4:04 ` [RFC][PATCH 2/6]qemuarm.conf: provide a common qemux86-64 " Bian Naimeng
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:02 UTC (permalink / raw)
To: openembedded-core
qemux86.conf: provide a common qemux86 machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemux86.conf to customize our
configuration, but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemux86.inc | 24 ++++++++++++++++++++++++
meta/conf/machine/qemux86.conf | 25 ++-----------------------
2 files changed, 26 insertions(+), 23 deletions(-)
create mode 100644 meta/conf/machine/include/qemux86.inc
diff --git a/meta/conf/machine/include/qemux86.inc b/meta/conf/machine/include/qemux86.inc
new file mode 100644
index 0000000..a5ef314
--- /dev/null
+++ b/meta/conf/machine/include/qemux86.inc
@@ -0,0 +1,24 @@
+#@DESCRIPTION: Common x86 machine configuration.
+
+PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-i586.inc
+
+KERNEL_IMAGETYPE = "bzImage"
+
+SERIAL_CONSOLE = "115200 ttyS0"
+
+XSERVER = "xserver-xorg \
+ mesa-driver-swrast \
+ xf86-input-vmmouse \
+ xf86-input-keyboard \
+ xf86-input-evdev \
+ xf86-video-vmware"
+
+MACHINE_FEATURES += "x86"
+
+MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index 5f107be..fb183eb 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -1,26 +1,5 @@
#@TYPE: Machine
#@NAME: common_pc
#@DESCRIPTION: Machine configuration for running a common x86
-
-PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
-
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-i586.inc
-
-KERNEL_IMAGETYPE = "bzImage"
-
-SERIAL_CONSOLE = "115200 ttyS0"
-
-XSERVER = "xserver-xorg \
- mesa-driver-swrast \
- xf86-input-vmmouse \
- xf86-input-keyboard \
- xf86-input-evdev \
- xf86-video-vmware"
-
-MACHINE_FEATURES += "x86"
-
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
+#
+require conf/machine/include/qemux86.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [RFC][PATCH 2/6]qemuarm.conf: provide a common qemux86-64 machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
@ 2013-07-29 4:04 ` Bian Naimeng
2013-07-29 4:05 ` [RFC][PATCH 3/6]qemuppc.conf: provide a common qemuppc " Bian Naimeng
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:04 UTC (permalink / raw)
To: openembedded-core
qemux86-64.conf: provide a common qemux86-64 machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemux86-64.conf to customize our
configuration, but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemux86-64.inc | 24 ++++++++++++++++++++++++
meta/conf/machine/qemux86-64.conf | 23 +----------------------
2 files changed, 25 insertions(+), 22 deletions(-)
create mode 100644 meta/conf/machine/include/qemux86-64.inc
diff --git a/meta/conf/machine/include/qemux86-64.inc b/meta/conf/machine/include/qemux86-64.inc
new file mode 100644
index 0000000..25d9884
--- /dev/null
+++ b/meta/conf/machine/include/qemux86-64.inc
@@ -0,0 +1,24 @@
+#@DESCRIPTION: Common x86-64 machine configuration.
+
+PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
+PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
+PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-x86_64.inc
+
+KERNEL_IMAGETYPE = "bzImage"
+
+SERIAL_CONSOLE = "115200 ttyS0"
+
+XSERVER = "xserver-xorg \
+ mesa-driver-swrast \
+ xf86-input-vmmouse \
+ xf86-input-keyboard \
+ xf86-input-evdev \
+ xf86-video-vmware"
+
+MACHINE_FEATURES += "x86"
+
+MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index ff666af..1ba5e96 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -2,25 +2,4 @@
#@NAME: common_pc
#@DESCRIPTION: Machine configuration for running a common x86
-PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
-PREFERRED_PROVIDER_virtual/libgl ?= "mesa"
-PREFERRED_PROVIDER_virtual/libgles1 ?= "mesa"
-PREFERRED_PROVIDER_virtual/libgles2 ?= "mesa"
-
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-x86_64.inc
-
-KERNEL_IMAGETYPE = "bzImage"
-
-SERIAL_CONSOLE = "115200 ttyS0"
-
-XSERVER = "xserver-xorg \
- mesa-driver-swrast \
- xf86-input-vmmouse \
- xf86-input-keyboard \
- xf86-input-evdev \
- xf86-video-vmware"
-
-MACHINE_FEATURES += "x86"
-
-MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "v86d"
+require conf/machine/include/qemux86-64.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [RFC][PATCH 3/6]qemuppc.conf: provide a common qemuppc machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
2013-07-29 4:04 ` [RFC][PATCH 2/6]qemuarm.conf: provide a common qemux86-64 " Bian Naimeng
@ 2013-07-29 4:05 ` Bian Naimeng
2013-07-29 4:07 ` [RFC][PATCH 4/6]qemumips.conf: provide a common qemumips " Bian Naimeng
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:05 UTC (permalink / raw)
To: openembedded-core
qemuppc.conf: provide a common qemuppc machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemuppc.conf to customize our
configuration, but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemuppc.inc | 9 +++++++++
meta/conf/machine/qemuppc.conf | 8 +-------
2 files changed, 10 insertions(+), 7 deletions(-)
create mode 100644 meta/conf/machine/include/qemuppc.inc
diff --git a/meta/conf/machine/include/qemuppc.inc b/meta/conf/machine/include/qemuppc.inc
new file mode 100644
index 0000000..4e6e16e
--- /dev/null
+++ b/meta/conf/machine/include/qemuppc.inc
@@ -0,0 +1,9 @@
+#@DESCRIPTION: Common machine configuration for running an PPC system under qemu emulation
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-ppc603e.inc
+
+KERNEL_IMAGETYPE = "vmlinux"
+
+SERIAL_CONSOLE = "115200 ttyS0"
+
diff --git a/meta/conf/machine/qemuppc.conf b/meta/conf/machine/qemuppc.conf
index 48eecb7..0752aa7 100644
--- a/meta/conf/machine/qemuppc.conf
+++ b/meta/conf/machine/qemuppc.conf
@@ -2,10 +2,4 @@
#@NAME: qemu PPC Emulator setup
#@DESCRIPTION: Machine configuration for running an PPC system under qemu emulation
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-ppc603e.inc
-
-KERNEL_IMAGETYPE = "vmlinux"
-
-SERIAL_CONSOLE = "115200 ttyS0"
-
+require conf/machine/include/qemuppc.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [RFC][PATCH 4/6]qemumips.conf: provide a common qemumips machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
` (2 preceding siblings ...)
2013-07-29 4:05 ` [RFC][PATCH 3/6]qemuppc.conf: provide a common qemuppc " Bian Naimeng
@ 2013-07-29 4:07 ` Bian Naimeng
2013-07-29 4:08 ` [RFC][PATCH 5/6]qemumips64.conf: provide a common qemumips64 " Bian Naimeng
2013-07-29 4:09 ` [RFC][PATCH 6/6]qemuarm.conf: provide a common qemuarm " Bian Naimeng
5 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:07 UTC (permalink / raw)
To: openembedded-core
qemumips.conf: provide a common qemumips machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemumips.conf to customize our
configuration, but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemumips.inc | 11 +++++++++++
meta/conf/machine/qemumips.conf | 12 ++----------
2 files changed, 13 insertions(+), 10 deletions(-)
create mode 100644 meta/conf/machine/include/qemumips.inc
diff --git a/meta/conf/machine/include/qemumips.inc b/meta/conf/machine/include/qemumips.inc
new file mode 100644
index 0000000..9b884a5
--- /dev/null
+++ b/meta/conf/machine/include/qemumips.inc
@@ -0,0 +1,11 @@
+#@DESCRIPTION: Common machine configuration for running an MIPS system under qemu emulation
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-mips32.inc
+
+KERNEL_IMAGETYPE = "vmlinux"
+KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
+
+SERIAL_CONSOLE = "115200 ttyS0"
+
+MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
index ce1c419..b874f7b 100644
--- a/meta/conf/machine/qemumips.conf
+++ b/meta/conf/machine/qemumips.conf
@@ -1,13 +1,5 @@
#@TYPE: Machine
#@NAME: mti_malta32_be MIPS
-#@DESCRIPTION: mti_malta32_be
+#@DESCRIPTION: Machine configuration for running an PPC system under qemu emulation
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-mips32.inc
-
-KERNEL_IMAGETYPE = "vmlinux"
-KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
-
-SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
+require conf/machine/include/qemumips.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [RFC][PATCH 5/6]qemumips64.conf: provide a common qemumips64 machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
` (3 preceding siblings ...)
2013-07-29 4:07 ` [RFC][PATCH 4/6]qemumips.conf: provide a common qemumips " Bian Naimeng
@ 2013-07-29 4:08 ` Bian Naimeng
2013-07-29 4:09 ` [RFC][PATCH 6/6]qemuarm.conf: provide a common qemuarm " Bian Naimeng
5 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:08 UTC (permalink / raw)
To: openembedded-core
qemuxmips64.conf: provide a common qemumips64 machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemuxmips64.conf to customize our
configuration, but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemumips64.inc | 11 +++++++++++
meta/conf/machine/qemumips64.conf | 12 ++----------
2 files changed, 13 insertions(+), 10 deletions(-)
create mode 100644 meta/conf/machine/include/qemumips64.inc
diff --git a/meta/conf/machine/include/qemumips64.inc b/meta/conf/machine/include/qemumips64.inc
new file mode 100644
index 0000000..7ba2f94
--- /dev/null
+++ b/meta/conf/machine/include/qemumips64.inc
@@ -0,0 +1,11 @@
+#@DESCRIPTION: Common machine configuration for running an MIPS64 system under qemu emulation
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-mips64.inc
+
+KERNEL_IMAGETYPE = "vmlinux"
+KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
+
+SERIAL_CONSOLE = "115200 ttyS0"
+
+MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
index b2c7998..1f2ee94 100644
--- a/meta/conf/machine/qemumips64.conf
+++ b/meta/conf/machine/qemumips64.conf
@@ -1,13 +1,5 @@
#@TYPE: Machine
#@NAME: mti-malta64-be MIPS64
-#@DESCRIPTION: mti-malta64-be
+#@DESCRIPTION: Machine configuration for running an MIPS64 system under qemu emulation
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-mips64.inc
-
-KERNEL_IMAGETYPE = "vmlinux"
-KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
-
-SERIAL_CONSOLE = "115200 ttyS0"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
+require conf/machine/include/qemumips64.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [RFC][PATCH 6/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
` (4 preceding siblings ...)
2013-07-29 4:08 ` [RFC][PATCH 5/6]qemumips64.conf: provide a common qemumips64 " Bian Naimeng
@ 2013-07-29 4:09 ` Bian Naimeng
5 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-29 4:09 UTC (permalink / raw)
To: openembedded-core
qemuarm.conf: provide a common qemuarm machine configuration,
so developer/distributor can customize their specific one.
Although, we can modify the meta/conf/machine/qemuarm.conf to customize our
configuration,but it's uncomfortable for developer/distributor maintaining
their branch.
After applying this patch, developer can tell poky using their machine
configuration by prepending their layer to BBPATH(Of course,
the bblayers.conf should be adapted to it).
Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
meta/conf/machine/include/qemuarm.inc | 10 ++++++++++
meta/conf/machine/qemuarm.conf | 10 ++--------
2 files changed, 12 insertions(+), 8 deletions(-)
create mode 100644 meta/conf/machine/include/qemuarm.inc
diff --git a/meta/conf/machine/include/qemuarm.inc b/meta/conf/machine/include/qemuarm.inc
new file mode 100644
index 0000000..366a52a
--- /dev/null
+++ b/meta/conf/machine/include/qemuarm.inc
@@ -0,0 +1,10 @@
+#@DESCRIPTION: Common machine configuration for versatile 926ejs.
+
+require conf/machine/include/qemu.inc
+require conf/machine/include/tune-arm926ejs.inc
+#require conf/machine/include/tune-arm1136jf-s.inc
+
+KERNEL_IMAGETYPE = "zImage"
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
+
diff --git a/meta/conf/machine/qemuarm.conf b/meta/conf/machine/qemuarm.conf
index d07084b..bc6287a 100644
--- a/meta/conf/machine/qemuarm.conf
+++ b/meta/conf/machine/qemuarm.conf
@@ -1,12 +1,6 @@
#@TYPE: Machine
#@NAME: arm_versatile_926ejs
-#@DESCRIPTION: arm_versatile_926ejs
+#@DESCRIPTION: Machine configuration for versatile 926ejs.
-require conf/machine/include/qemu.inc
-require conf/machine/include/tune-arm926ejs.inc
-#require conf/machine/include/tune-arm1136jf-s.inc
-
-KERNEL_IMAGETYPE = "zImage"
-
-SERIAL_CONSOLE = "115200 ttyAMA0"
+require conf/machine/include/qemuarm.inc
--
1.7.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
@ 2013-07-29 15:36 ` Phil Blundell
2013-07-30 1:51 ` Bian Naimeng
0 siblings, 1 reply; 11+ messages in thread
From: Phil Blundell @ 2013-07-29 15:36 UTC (permalink / raw)
To: Bian Naimeng; +Cc: openembedded-core
On Mon, 2013-07-29 at 12:02 +0800, Bian Naimeng wrote:
> qemux86.conf: provide a common qemux86 machine configuration,
> so developer/distributor can customize their specific one.
>
> Although, we can modify the meta/conf/machine/qemux86.conf to customize our
> configuration, but it's uncomfortable for developer/distributor maintaining
> their branch.
> After applying this patch, developer can tell poky using their machine
> configuration by prepending their layer to BBPATH(Of course,
> the bblayers.conf should be adapted to it).
I don't really understand the purpose of this patch. Surely there is
nothing to stop you from shipping an overlay qemux86.conf in some other
layer today, right? What exactly is the advantage of this extra
indirection through an .inc file?
Also, as a side note, your patches 1/6, 2/6 and 6/6 all said
"qemuarm.conf" in the subject lines but only the last of them actually
contained changes to qemuarm.conf.
Also also, the patches in this form are quite hard to follow. Did you
use "git format-patch -M" when creating them?
p.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-29 15:36 ` Phil Blundell
@ 2013-07-30 1:51 ` Bian Naimeng
2013-07-30 8:15 ` Martin Jansa
0 siblings, 1 reply; 11+ messages in thread
From: Bian Naimeng @ 2013-07-30 1:51 UTC (permalink / raw)
To: Phil Blundell; +Cc: openembedded-core
said the following on 2013-7-29 23:36:, Phil Blundell wrote:
> On Mon, 2013-07-29 at 12:02 +0800, Bian Naimeng wrote:
>> qemux86.conf: provide a common qemux86 machine configuration,
>> so developer/distributor can customize their specific one.
>>
>> Although, we can modify the meta/conf/machine/qemux86.conf to customize our
>> configuration, but it's uncomfortable for developer/distributor maintaining
>> their branch.
>> After applying this patch, developer can tell poky using their machine
>> configuration by prepending their layer to BBPATH(Of course,
>> the bblayers.conf should be adapted to it).
>
> I don't really understand the purpose of this patch. Surely there is
> nothing to stop you from shipping an overlay qemux86.conf in some other
> layer today, right? What exactly is the advantage of this extra
> indirection through an .inc file?
>
What my purpose is that make it easy to implement the below case.
1. I want inherit all the configuration item of qemux86.conf.
2. I want add some new items to my qemux86.conf.
3. If there're changes to qemux86.conf, i want merge them to my qemux86.conf
Yes, we can implement this case today.
1. Copy the meta/conf/machine/qemux86.conf to my layer.
2. Add new items to my qemux86.conf
3. Rewrite my qemux86.conf to merge community changes.
However, if applying these patches, it becomes easy.
1. add "require conf/machine/include/qemux86.inc" to my qemux86.conf
2. add new items to my qemux86.conf
3. modify qemux86.inc to update qemux86 configration at community,
so all community changes will be merged to my qemux86.conf automatically
when merging the mainline.
> Also, as a side note, your patches 1/6, 2/6 and 6/6 all said
> "qemuarm.conf" in the subject lines but only the last of them actually
> contained changes to qemuarm.conf.
Sorry for my mistake. The correct one is following.
1/6: qemux86.conf.
2/6: qemux86-64.conf
>
> Also also, the patches in this form are quite hard to follow. Did you
> use "git format-patch -M" when creating them?
Yes, I used "git format-patch -M" to create them.
I will check them by linux/scripts/checkpatch.pl next time.
Thanks
bian
>
> p.
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-30 1:51 ` Bian Naimeng
@ 2013-07-30 8:15 ` Martin Jansa
2013-07-30 8:55 ` Bian Naimeng
0 siblings, 1 reply; 11+ messages in thread
From: Martin Jansa @ 2013-07-30 8:15 UTC (permalink / raw)
To: Bian Naimeng; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2827 bytes --]
On Tue, Jul 30, 2013 at 09:51:54AM +0800, Bian Naimeng wrote:
>
> said the following on 2013-7-29 23:36:, Phil Blundell wrote:
> > On Mon, 2013-07-29 at 12:02 +0800, Bian Naimeng wrote:
> >> qemux86.conf: provide a common qemux86 machine configuration,
> >> so developer/distributor can customize their specific one.
> >>
> >> Although, we can modify the meta/conf/machine/qemux86.conf to customize our
> >> configuration, but it's uncomfortable for developer/distributor maintaining
> >> their branch.
> >> After applying this patch, developer can tell poky using their machine
> >> configuration by prepending their layer to BBPATH(Of course,
> >> the bblayers.conf should be adapted to it).
> >
> > I don't really understand the purpose of this patch. Surely there is
> > nothing to stop you from shipping an overlay qemux86.conf in some other
> > layer today, right? What exactly is the advantage of this extra
> > indirection through an .inc file?
> >
>
> What my purpose is that make it easy to implement the below case.
> 1. I want inherit all the configuration item of qemux86.conf.
> 2. I want add some new items to my qemux86.conf.
> 3. If there're changes to qemux86.conf, i want merge them to my qemux86.conf
>
> Yes, we can implement this case today.
> 1. Copy the meta/conf/machine/qemux86.conf to my layer.
> 2. Add new items to my qemux86.conf
> 3. Rewrite my qemux86.conf to merge community changes.
>
> However, if applying these patches, it becomes easy.
> 1. add "require conf/machine/include/qemux86.inc" to my qemux86.conf
> 2. add new items to my qemux86.conf
> 3. modify qemux86.inc to update qemux86 configration at community,
> so all community changes will be merged to my qemux86.conf automatically
> when merging the mainline.
Without patches
1. add require ${COREBASE}/meta/conf/machine/qemux86.conf at the
beginning of your qemux86.conf copy
2. add new items
>
> > Also, as a side note, your patches 1/6, 2/6 and 6/6 all said
> > "qemuarm.conf" in the subject lines but only the last of them actually
> > contained changes to qemuarm.conf.
>
> Sorry for my mistake. The correct one is following.
> 1/6: qemux86.conf.
> 2/6: qemux86-64.conf
>
> >
> > Also also, the patches in this form are quite hard to follow. Did you
> > use "git format-patch -M" when creating them?
>
> Yes, I used "git format-patch -M" to create them.
> I will check them by linux/scripts/checkpatch.pl next time.
>
> Thanks
> bian
>
> >
> > p.
> >
> >
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
2013-07-30 8:15 ` Martin Jansa
@ 2013-07-30 8:55 ` Bian Naimeng
0 siblings, 0 replies; 11+ messages in thread
From: Bian Naimeng @ 2013-07-30 8:55 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
said the following on 2013-7-30 16:15:, Martin Jansa wrote:
> On Tue, Jul 30, 2013 at 09:51:54AM +0800, Bian Naimeng wrote:
>>
>> said the following on 2013-7-29 23:36:, Phil Blundell wrote:
>>> On Mon, 2013-07-29 at 12:02 +0800, Bian Naimeng wrote:
>>>> qemux86.conf: provide a common qemux86 machine configuration,
>>>> so developer/distributor can customize their specific one.
>>>>
>>>> Although, we can modify the meta/conf/machine/qemux86.conf to customize our
>>>> configuration, but it's uncomfortable for developer/distributor maintaining
>>>> their branch.
>>>> After applying this patch, developer can tell poky using their machine
>>>> configuration by prepending their layer to BBPATH(Of course,
>>>> the bblayers.conf should be adapted to it).
>>>
>>> I don't really understand the purpose of this patch. Surely there is
>>> nothing to stop you from shipping an overlay qemux86.conf in some other
>>> layer today, right? What exactly is the advantage of this extra
>>> indirection through an .inc file?
>>>
>>
>> What my purpose is that make it easy to implement the below case.
>> 1. I want inherit all the configuration item of qemux86.conf.
>> 2. I want add some new items to my qemux86.conf.
>> 3. If there're changes to qemux86.conf, i want merge them to my qemux86.conf
>>
>> Yes, we can implement this case today.
>> 1. Copy the meta/conf/machine/qemux86.conf to my layer.
>> 2. Add new items to my qemux86.conf
>> 3. Rewrite my qemux86.conf to merge community changes.
>>
>> However, if applying these patches, it becomes easy.
>> 1. add "require conf/machine/include/qemux86.inc" to my qemux86.conf
>> 2. add new items to my qemux86.conf
>> 3. modify qemux86.inc to update qemux86 configration at community,
>> so all community changes will be merged to my qemux86.conf automatically
>> when merging the mainline.
>
> Without patches
> 1. add require ${COREBASE}/meta/conf/machine/qemux86.conf at the
> beginning of your qemux86.conf copy
> 2. add new items
>
You are right. ^_^
Thanks
Bian
>>
>>> Also, as a side note, your patches 1/6, 2/6 and 6/6 all said
>>> "qemuarm.conf" in the subject lines but only the last of them actually
>>> contained changes to qemuarm.conf.
>>
>> Sorry for my mistake. The correct one is following.
>> 1/6: qemux86.conf.
>> 2/6: qemux86-64.conf
>>
>>>
>>> Also also, the patches in this form are quite hard to follow. Did you
>>> use "git format-patch -M" when creating them?
>>
>> Yes, I used "git format-patch -M" to create them.
>> I will check them by linux/scripts/checkpatch.pl next time.
>>
>> Thanks
>> bian
>>
>>>
>>> p.
>>>
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-07-30 8:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
2013-07-29 15:36 ` Phil Blundell
2013-07-30 1:51 ` Bian Naimeng
2013-07-30 8:15 ` Martin Jansa
2013-07-30 8:55 ` Bian Naimeng
2013-07-29 4:04 ` [RFC][PATCH 2/6]qemuarm.conf: provide a common qemux86-64 " Bian Naimeng
2013-07-29 4:05 ` [RFC][PATCH 3/6]qemuppc.conf: provide a common qemuppc " Bian Naimeng
2013-07-29 4:07 ` [RFC][PATCH 4/6]qemumips.conf: provide a common qemumips " Bian Naimeng
2013-07-29 4:08 ` [RFC][PATCH 5/6]qemumips64.conf: provide a common qemumips64 " Bian Naimeng
2013-07-29 4:09 ` [RFC][PATCH 6/6]qemuarm.conf: provide a common qemuarm " Bian Naimeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox