Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY
@ 2013-09-09 10:10 jackie.huang
  2013-09-09 10:21 ` Phil Blundell
  0 siblings, 1 reply; 4+ messages in thread
From: jackie.huang @ 2013-09-09 10:10 UTC (permalink / raw)
  To: openembedded-core

From: Randy MacLeod <Randy.MacLeod@windriver.com>

It's a FYI patch for anyone who might be having the same problem.

pulseaudio-4.0 causes an internal compiler error. Temporarily
avoid the build error be omitting the code that makes the
compiler fail until the compiler ICE is addressed.

The error is:
pulsecore/sink.c: In function 'pa_sink_process_msg':
pulsecore/sink.c:3822:1: internal compiler error: in fold_binary_loc, at fold-const.c:9871
 }
  ^

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 ...void-gcc-ICE-drop-useful-code-TEMPORARILY.patch |   55 ++++++++++++++++++++
 .../pulseaudio/pulseaudio_4.0.bb                   |    4 +-
 2 files changed, 58 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-Avoid-gcc-ICE-drop-useful-code-TEMPORARILY.patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-Avoid-gcc-ICE-drop-useful-code-TEMPORARILY.patch b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-Avoid-gcc-ICE-drop-useful-code-TEMPORARILY.patch
new file mode 100644
index 0000000..d104da7
--- /dev/null
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-Avoid-gcc-ICE-drop-useful-code-TEMPORARILY.patch
@@ -0,0 +1,55 @@
+From 4eb3f53619a0c8542ab53dc7ba1d930c025e3046 Mon Sep 17 00:00:00 2001
+From: Randy MacLeod <Randy.MacLeod@windriver.com>
+Date: Sun, 8 Sep 2013 19:36:41 -0400
+Subject: [PATCH] Avoid gcc ICE: drop useful code - TEMPORARILY
+
+---
+ src/pulsecore/sink.c   | 7 ++++++-
+ src/pulsecore/source.c | 9 +++++++--
+ 2 files changed, 13 insertions(+), 3 deletions(-)
+
+diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
+index 9b4b066..233f69f 100644
+--- a/src/pulsecore/sink.c
++++ b/src/pulsecore/sink.c
+@@ -2768,7 +2768,12 @@ int pa_sink_process_msg(pa_msgobject *o, int code, void *userdata, int64_t offse
+         case PA_SINK_MESSAGE_SET_STATE: {
+ 
+             pa_bool_t suspend_change =
+-                (s->thread_info.state == PA_SINK_SUSPENDED && PA_SINK_IS_OPENED(PA_PTR_TO_UINT(userdata))) ||
++
++                (s->thread_info.state == PA_SINK_SUSPENDED 
++#if 0
++		&& PA_SINK_IS_OPENED(PA_PTR_TO_UINT(userdata))
++#endif
++		) ||
+                 (PA_SINK_IS_OPENED(s->thread_info.state) && PA_PTR_TO_UINT(userdata) == PA_SINK_SUSPENDED);
+ 
+             s->thread_info.state = PA_PTR_TO_UINT(userdata);
+diff --git a/src/pulsecore/source.c b/src/pulsecore/source.c
+index c6aa5e3..a6e684d 100644
+--- a/src/pulsecore/source.c
++++ b/src/pulsecore/source.c
+@@ -2100,8 +2100,12 @@ int pa_source_process_msg(pa_msgobject *object, int code, void *userdata, int64_
+         case PA_SOURCE_MESSAGE_SET_STATE: {
+ 
+             pa_bool_t suspend_change =
+-                (s->thread_info.state == PA_SOURCE_SUSPENDED && PA_SOURCE_IS_OPENED(PA_PTR_TO_UINT(userdata))) ||
+-                (PA_SOURCE_IS_OPENED(s->thread_info.state) && PA_PTR_TO_UINT(userdata) == PA_SOURCE_SUSPENDED);
++                ( s->thread_info.state == PA_SOURCE_SUSPENDED 
++#if 0
++		  && 
++		  PA_SOURCE_IS_OPENED(PA_PTR_TO_UINT(userdata))
++#endif
++		 ) || (PA_SOURCE_IS_OPENED(s->thread_info.state) && PA_PTR_TO_UINT(userdata) == PA_SOURCE_SUSPENDED);
+ 
+             s->thread_info.state = PA_PTR_TO_UINT(userdata);
+ 
+@@ -2857,3 +2861,4 @@ done:
+ 
+     return out_formats;
+ }
++
+-- 
+1.8.1
+
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb
index b419c54..156af02 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb
@@ -1,7 +1,9 @@
 require pulseaudio.inc
 
 SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/pulseaudio-${PV}.tar.xz \
-           file://volatiles.04_pulse"
+           file://volatiles.04_pulse \
+	   file://0001-Avoid-gcc-ICE-drop-useful-code-TEMPORARILY.patch \
+	   "
 
 SRC_URI[md5sum] = "591f211db2790a7e4d222f2dc6858db3"
 SRC_URI[sha256sum] = "35ceb36bb1822fe54f0b5e4863b4f486769fdfb8ff2111f01fd8778928f9cdae"
-- 
1.7.4.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY
  2013-09-09 10:10 [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY jackie.huang
@ 2013-09-09 10:21 ` Phil Blundell
  2013-09-09 10:25   ` jhuang0
  0 siblings, 1 reply; 4+ messages in thread
From: Phil Blundell @ 2013-09-09 10:21 UTC (permalink / raw)
  To: jackie.huang; +Cc: openembedded-core

On Mon, 2013-09-09 at 18:10 +0800, jackie.huang@windriver.com wrote:
> From: Randy MacLeod <Randy.MacLeod@windriver.com>
> 
> It's a FYI patch for anyone who might be having the same problem.
> 
> pulseaudio-4.0 causes an internal compiler error. Temporarily
> avoid the build error be omitting the code that makes the
> compiler fail until the compiler ICE is addressed.

Please mention the GCC bug number for this ice so that it's easy to
establish when it has indeed been addressed.

p.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY
  2013-09-09 10:21 ` Phil Blundell
@ 2013-09-09 10:25   ` jhuang0
  2013-09-10  4:40     ` Randy MacLeod
  0 siblings, 1 reply; 4+ messages in thread
From: jhuang0 @ 2013-09-09 10:25 UTC (permalink / raw)
  To: Phil Blundell, MacLeod, Randy; +Cc: openembedded-core



On 9/9/2013 6:21 PM, Phil Blundell wrote:
> On Mon, 2013-09-09 at 18:10 +0800, jackie.huang@windriver.com wrote:
>> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>>
>> It's a FYI patch for anyone who might be having the same problem.
>>
>> pulseaudio-4.0 causes an internal compiler error. Temporarily
>> avoid the build error be omitting the code that makes the
>> compiler fail until the compiler ICE is addressed.
>
> Please mention the GCC bug number for this ice so that it's easy to
> establish when it has indeed been addressed.

Sorry, I don't have the bug number.

Randy,

Do you have one for this?

Thanks,
Jackie

>
> p.
>
>
>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY
  2013-09-09 10:25   ` jhuang0
@ 2013-09-10  4:40     ` Randy MacLeod
  0 siblings, 0 replies; 4+ messages in thread
From: Randy MacLeod @ 2013-09-10  4:40 UTC (permalink / raw)
  To: jhuang0; +Cc: openembedded-core

On 13-09-09 06:25 AM, jhuang0 wrote:
>
>
> On 9/9/2013 6:21 PM, Phil Blundell wrote:
>> On Mon, 2013-09-09 at 18:10 +0800, jackie.huang@windriver.com wrote:
>>> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>>>
>>> It's a FYI patch for anyone who might be having the same problem.
>>>
>>> pulseaudio-4.0 causes an internal compiler error. Temporarily
>>> avoid the build error be omitting the code that makes the
>>> compiler fail until the compiler ICE is addressed.
>>
>> Please mention the GCC bug number for this ice so that it's easy to
>> establish when it has indeed been addressed.
>
> Sorry, I don't have the bug number.
>
> Randy,
>
> Do you have one for this?

Not yet.

In fact I can't reproduce it using just oe-core so
I think my report via Jackie is a false alarm.
Sorry about that.

// Randy
>
> Thanks,
> Jackie
>
>>
>> p.
>>
>>
>>
>>
>


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-10  4:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 10:10 [PATCH] pulseaudio: avoid gcc ICE by omitting code TEMPORARILY jackie.huang
2013-09-09 10:21 ` Phil Blundell
2013-09-09 10:25   ` jhuang0
2013-09-10  4:40     ` Randy MacLeod

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox