* [PATCH 0/1] kernelshark/trace-cmd: fix syntax error of shell
@ 2014-04-04 8:33 Chong Lu
2014-04-04 8:33 ` [PATCH 1/1] " Chong Lu
0 siblings, 1 reply; 8+ messages in thread
From: Chong Lu @ 2014-04-04 8:33 UTC (permalink / raw)
To: openembedded-core
The following changes since commit a5775abb1951ec6cdc7afacd1ae87189e398cff8:
bitbake: user-manual-metadata.xml: Added new section on mapping functions. (2014-04-02 14:15:35 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib chonglu/kernelshark
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/kernelshark
Chong Lu (1):
kernelshark/trace-cmd: fix syntax error of shell
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
.../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
.../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
--
1.8.1.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-04 8:33 [PATCH 0/1] kernelshark/trace-cmd: fix syntax error of shell Chong Lu
@ 2014-04-04 8:33 ` Chong Lu
2014-04-04 10:41 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Chong Lu @ 2014-04-04 8:33 UTC (permalink / raw)
To: openembedded-core
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
.../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
.../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
index 9268a50..d61097d 100644
--- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
+++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
file://addldflags.patch \
file://make-docs-optional.patch \
- file://blktrace-api-compatibility.patch"
+ file://blktrace-api-compatibility.patch \
+ file://kernelshark-fix-syntax-error-of-shell.patch"
S = "${WORKDIR}/git"
EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
new file mode 100644
index 0000000..994a9fa
--- /dev/null
+++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+ Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
+---
+ Makefile | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..be84415 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ # -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+- <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+--
+1.7.9.5
+
diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
new file mode 100644
index 0000000..79abad5
--- /dev/null
+++ b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
@@ -0,0 +1,30 @@
+trace-cmd: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+ Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
+---
+ Makefile | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..7973c53 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ # -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+- <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+--
+1.7.9.5
+
diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
index 74eafbb..a0c823b 100644
--- a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
+++ b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
@@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
+ file://trace-cmd-fix-syntax-error-of-shell.patch \
"
S = "${WORKDIR}/git"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-04 8:33 ` [PATCH 1/1] " Chong Lu
@ 2014-04-04 10:41 ` Richard Purdie
2014-04-08 1:40 ` Chong Lu
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2014-04-04 10:41 UTC (permalink / raw)
To: Chong Lu; +Cc: openembedded-core
On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
> Delete "<<<" syntax of bash in Makefile, else we would get following error:
>
> Syntax error: redirection unexpected
>
> [YOCTO #6112]
>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
> 4 files changed, 63 insertions(+), 1 deletion(-)
> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>
> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> index 9268a50..d61097d 100644
> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
> file://addldflags.patch \
> file://make-docs-optional.patch \
> - file://blktrace-api-compatibility.patch"
> + file://blktrace-api-compatibility.patch \
> + file://kernelshark-fix-syntax-error-of-shell.patch"
> S = "${WORKDIR}/git"
>
> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> new file mode 100644
> index 0000000..994a9fa
> --- /dev/null
> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> @@ -0,0 +1,30 @@
> +kernelshark: fix syntax error of shell
> +
> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
> +
> + Syntax error: redirection unexpected
> +
> +Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?
Cheers,
Richard
> +Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> +---
> + Makefile | 3 +--
> + 1 file changed, 1 insertion(+), 2 deletions(-)
> +
> +diff --git a/Makefile b/Makefile
> +index c1fa906..be84415 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -89,8 +89,7 @@ endif
> +
> + # $(call test-build, snippet, ret) -> ret if snippet compiles
> + # -> empty otherwise
> +-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
> +- <<<'$1' && echo y), $2)
> ++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
> +
> + # have udis86 disassembler library?
> + udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
> +--
> +1.7.9.5
> +
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> new file mode 100644
> index 0000000..79abad5
> --- /dev/null
> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> @@ -0,0 +1,30 @@
> +trace-cmd: fix syntax error of shell
> +
> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
> +
> + Syntax error: redirection unexpected
> +
> +Upstream-Status: Inappropriate [embedded specific]
> +
> +Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> +---
> + Makefile | 3 +--
> + 1 file changed, 1 insertion(+), 2 deletions(-)
> +
> +diff --git a/Makefile b/Makefile
> +index c1fa906..7973c53 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -89,8 +89,7 @@ endif
> +
> + # $(call test-build, snippet, ret) -> ret if snippet compiles
> + # -> empty otherwise
> +-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
> +- <<<'$1' && echo y), $2)
> ++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
> +
> + # have udis86 disassembler library?
> + udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
> +--
> +1.7.9.5
> +
> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
> index 74eafbb..a0c823b 100644
> --- a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
> @@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
> file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
> file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
> file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
> + file://trace-cmd-fix-syntax-error-of-shell.patch \
> "
> S = "${WORKDIR}/git"
>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-04 10:41 ` Richard Purdie
@ 2014-04-08 1:40 ` Chong Lu
2014-04-08 10:08 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Chong Lu @ 2014-04-08 1:40 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 04/04/2014 06:41 PM, Richard Purdie wrote:
> On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
>> Delete "<<<" syntax of bash in Makefile, else we would get following error:
>>
>> Syntax error: redirection unexpected
>>
>> [YOCTO #6112]
>>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
>> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
>> 4 files changed, 63 insertions(+), 1 deletion(-)
>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>>
>> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>> index 9268a50..d61097d 100644
>> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
>> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
>> file://addldflags.patch \
>> file://make-docs-optional.patch \
>> - file://blktrace-api-compatibility.patch"
>> + file://blktrace-api-compatibility.patch \
>> + file://kernelshark-fix-syntax-error-of-shell.patch"
>> S = "${WORKDIR}/git"
>>
>> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>> new file mode 100644
>> index 0000000..994a9fa
>> --- /dev/null
>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>> @@ -0,0 +1,30 @@
>> +kernelshark: fix syntax error of shell
>> +
>> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
>> +
>> + Syntax error: redirection unexpected
>> +
>> +Upstream-Status: Inappropriate [embedded specific]
> How is this embedded specific?
>
> Cheers,
>
> Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself.
So I think this is embedded specific.
Best Regards
Chong
>> +Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> +---
>> + Makefile | 3 +--
>> + 1 file changed, 1 insertion(+), 2 deletions(-)
>> +
>> +diff --git a/Makefile b/Makefile
>> +index c1fa906..be84415 100644
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -89,8 +89,7 @@ endif
>> +
>> + # $(call test-build, snippet, ret) -> ret if snippet compiles
>> + # -> empty otherwise
>> +-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
>> +- <<<'$1' && echo y), $2)
>> ++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
>> +
>> + # have udis86 disassembler library?
>> + udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
>> +--
>> +1.7.9.5
>> +
>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>> new file mode 100644
>> index 0000000..79abad5
>> --- /dev/null
>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>> @@ -0,0 +1,30 @@
>> +trace-cmd: fix syntax error of shell
>> +
>> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
>> +
>> + Syntax error: redirection unexpected
>> +
>> +Upstream-Status: Inappropriate [embedded specific]
>> +
>> +Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> +---
>> + Makefile | 3 +--
>> + 1 file changed, 1 insertion(+), 2 deletions(-)
>> +
>> +diff --git a/Makefile b/Makefile
>> +index c1fa906..7973c53 100644
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -89,8 +89,7 @@ endif
>> +
>> + # $(call test-build, snippet, ret) -> ret if snippet compiles
>> + # -> empty otherwise
>> +-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
>> +- <<<'$1' && echo y), $2)
>> ++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
>> +
>> + # have udis86 disassembler library?
>> + udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
>> +--
>> +1.7.9.5
>> +
>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
>> index 74eafbb..a0c823b 100644
>> --- a/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb
>> @@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
>> file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
>> file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
>> file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
>> + file://trace-cmd-fix-syntax-error-of-shell.patch \
>> "
>> S = "${WORKDIR}/git"
>>
>> --
>> 1.8.1.2
>>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-08 1:40 ` Chong Lu
@ 2014-04-08 10:08 ` Richard Purdie
2014-04-09 7:49 ` Chong Lu
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2014-04-08 10:08 UTC (permalink / raw)
To: Chong Lu; +Cc: openembedded-core
On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote:
> On 04/04/2014 06:41 PM, Richard Purdie wrote:
> > On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
> >> Delete "<<<" syntax of bash in Makefile, else we would get following error:
> >>
> >> Syntax error: redirection unexpected
> >>
> >> [YOCTO #6112]
> >>
> >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> >> ---
> >> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
> >> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> >> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> >> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
> >> 4 files changed, 63 insertions(+), 1 deletion(-)
> >> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> >>
> >> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >> index 9268a50..d61097d 100644
> >> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
> >> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
> >> file://addldflags.patch \
> >> file://make-docs-optional.patch \
> >> - file://blktrace-api-compatibility.patch"
> >> + file://blktrace-api-compatibility.patch \
> >> + file://kernelshark-fix-syntax-error-of-shell.patch"
> >> S = "${WORKDIR}/git"
> >>
> >> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
> >> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >> new file mode 100644
> >> index 0000000..994a9fa
> >> --- /dev/null
> >> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >> @@ -0,0 +1,30 @@
> >> +kernelshark: fix syntax error of shell
> >> +
> >> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
> >> +
> >> + Syntax error: redirection unexpected
> >> +
> >> +Upstream-Status: Inappropriate [embedded specific]
> > How is this embedded specific?
> >
> > Cheers,
> >
> > Richard
> This issue only produced in yocto.
> It is not problem for kernelshark and trace-cmd itself.
> So I think this is embedded specific.
I'm afraid I don't accept this explanation. Is Yocto's make different
somehow which causes this error?
I don't understand why yocto would see this error yet other systems
(which use the same make as far as I know) would not.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-08 10:08 ` Richard Purdie
@ 2014-04-09 7:49 ` Chong Lu
2014-04-09 9:28 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Chong Lu @ 2014-04-09 7:49 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 04/08/2014 06:08 PM, Richard Purdie wrote:
> On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote:
>> On 04/04/2014 06:41 PM, Richard Purdie wrote:
>>> On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
>>>> Delete "<<<" syntax of bash in Makefile, else we would get following error:
>>>>
>>>> Syntax error: redirection unexpected
>>>>
>>>> [YOCTO #6112]
>>>>
>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>>>> ---
>>>> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
>>>> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>>>> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>>>> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
>>>> 4 files changed, 63 insertions(+), 1 deletion(-)
>>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>>>>
>>>> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>> index 9268a50..d61097d 100644
>>>> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
>>>> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
>>>> file://addldflags.patch \
>>>> file://make-docs-optional.patch \
>>>> - file://blktrace-api-compatibility.patch"
>>>> + file://blktrace-api-compatibility.patch \
>>>> + file://kernelshark-fix-syntax-error-of-shell.patch"
>>>> S = "${WORKDIR}/git"
>>>>
>>>> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
>>>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>> new file mode 100644
>>>> index 0000000..994a9fa
>>>> --- /dev/null
>>>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>> @@ -0,0 +1,30 @@
>>>> +kernelshark: fix syntax error of shell
>>>> +
>>>> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
>>>> +
>>>> + Syntax error: redirection unexpected
>>>> +
>>>> +Upstream-Status: Inappropriate [embedded specific]
>>> How is this embedded specific?
>>>
>>> Cheers,
>>>
>>> Richard
>> This issue only produced in yocto.
>> It is not problem for kernelshark and trace-cmd itself.
>> So I think this is embedded specific.
> I'm afraid I don't accept this explanation. Is Yocto's make different
> somehow which causes this error?
>
> I don't understand why yocto would see this error yet other systems
> (which use the same make as far as I know) would not.
>
> Cheers,
>
> Richard
>
Hi Richard,
I built kernelshark and trace-cmd in Ubuntu 12.04.
The dash is default shell in this distrobution.
So, this issue would produce only on host that the default shell is not
bash.
Best Regards
Chong
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-09 7:49 ` Chong Lu
@ 2014-04-09 9:28 ` Richard Purdie
2014-04-09 9:36 ` Chong Lu
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2014-04-09 9:28 UTC (permalink / raw)
To: Chong Lu; +Cc: openembedded-core
On Wed, 2014-04-09 at 15:49 +0800, Chong Lu wrote:
> On 04/08/2014 06:08 PM, Richard Purdie wrote:
> > On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote:
> >> On 04/04/2014 06:41 PM, Richard Purdie wrote:
> >>> On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
> >>>> Delete "<<<" syntax of bash in Makefile, else we would get following error:
> >>>>
> >>>> Syntax error: redirection unexpected
> >>>>
> >>>> [YOCTO #6112]
> >>>>
> >>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> >>>> ---
> >>>> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
> >>>> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> >>>> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
> >>>> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
> >>>> 4 files changed, 63 insertions(+), 1 deletion(-)
> >>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
> >>>>
> >>>> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >>>> index 9268a50..d61097d 100644
> >>>> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >>>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
> >>>> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
> >>>> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
> >>>> file://addldflags.patch \
> >>>> file://make-docs-optional.patch \
> >>>> - file://blktrace-api-compatibility.patch"
> >>>> + file://blktrace-api-compatibility.patch \
> >>>> + file://kernelshark-fix-syntax-error-of-shell.patch"
> >>>> S = "${WORKDIR}/git"
> >>>>
> >>>> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
> >>>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >>>> new file mode 100644
> >>>> index 0000000..994a9fa
> >>>> --- /dev/null
> >>>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
> >>>> @@ -0,0 +1,30 @@
> >>>> +kernelshark: fix syntax error of shell
> >>>> +
> >>>> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
> >>>> +
> >>>> + Syntax error: redirection unexpected
> >>>> +
> >>>> +Upstream-Status: Inappropriate [embedded specific]
> >>> How is this embedded specific?
> >>>
> >>> Cheers,
> >>>
> >>> Richard
> >> This issue only produced in yocto.
> >> It is not problem for kernelshark and trace-cmd itself.
> >> So I think this is embedded specific.
> > I'm afraid I don't accept this explanation. Is Yocto's make different
> > somehow which causes this error?
> >
> > I don't understand why yocto would see this error yet other systems
> > (which use the same make as far as I know) would not.
> >
> > Cheers,
> >
> > Richard
> >
> Hi Richard,
>
> I built kernelshark and trace-cmd in Ubuntu 12.04.
> The dash is default shell in this distrobution.
> So, this issue would produce only on host that the default shell is not
> bash.
Right, so the Upstream-Status is not "embedded specific", its a general
problems for shells which are not bash?
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell
2014-04-09 9:28 ` Richard Purdie
@ 2014-04-09 9:36 ` Chong Lu
0 siblings, 0 replies; 8+ messages in thread
From: Chong Lu @ 2014-04-09 9:36 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 04/09/2014 05:28 PM, Richard Purdie wrote:
> On Wed, 2014-04-09 at 15:49 +0800, Chong Lu wrote:
>> On 04/08/2014 06:08 PM, Richard Purdie wrote:
>>> On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote:
>>>> On 04/04/2014 06:41 PM, Richard Purdie wrote:
>>>>> On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
>>>>>> Delete "<<<" syntax of bash in Makefile, else we would get following error:
>>>>>>
>>>>>> Syntax error: redirection unexpected
>>>>>>
>>>>>> [YOCTO #6112]
>>>>>>
>>>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>>>>>> ---
>>>>>> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
>>>>>> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>>>>>> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++
>>>>>> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
>>>>>> 4 files changed, 63 insertions(+), 1 deletion(-)
>>>>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
>>>>>>
>>>>>> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>>>> index 9268a50..d61097d 100644
>>>>>> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>>>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
>>>>>> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
>>>>>> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
>>>>>> file://addldflags.patch \
>>>>>> file://make-docs-optional.patch \
>>>>>> - file://blktrace-api-compatibility.patch"
>>>>>> + file://blktrace-api-compatibility.patch \
>>>>>> + file://kernelshark-fix-syntax-error-of-shell.patch"
>>>>>> S = "${WORKDIR}/git"
>>>>>>
>>>>>> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
>>>>>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>>>> new file mode 100644
>>>>>> index 0000000..994a9fa
>>>>>> --- /dev/null
>>>>>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
>>>>>> @@ -0,0 +1,30 @@
>>>>>> +kernelshark: fix syntax error of shell
>>>>>> +
>>>>>> +Delete "<<<" syntax of bash in Makefile, else we would get following error:
>>>>>> +
>>>>>> + Syntax error: redirection unexpected
>>>>>> +
>>>>>> +Upstream-Status: Inappropriate [embedded specific]
>>>>> How is this embedded specific?
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Richard
>>>> This issue only produced in yocto.
>>>> It is not problem for kernelshark and trace-cmd itself.
>>>> So I think this is embedded specific.
>>> I'm afraid I don't accept this explanation. Is Yocto's make different
>>> somehow which causes this error?
>>>
>>> I don't understand why yocto would see this error yet other systems
>>> (which use the same make as far as I know) would not.
>>>
>>> Cheers,
>>>
>>> Richard
>>>
>> Hi Richard,
>>
>> I built kernelshark and trace-cmd in Ubuntu 12.04.
>> The dash is default shell in this distrobution.
>> So, this issue would produce only on host that the default shell is not
>> bash.
> Right, so the Upstream-Status is not "embedded specific", its a general
> problems for shells which are not bash?
>
> Cheers,
>
> Richard
>
Ok, thanks. I got it. I will resend V2.
Best Regards
Chong
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-09 9:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-04 8:33 [PATCH 0/1] kernelshark/trace-cmd: fix syntax error of shell Chong Lu
2014-04-04 8:33 ` [PATCH 1/1] " Chong Lu
2014-04-04 10:41 ` Richard Purdie
2014-04-08 1:40 ` Chong Lu
2014-04-08 10:08 ` Richard Purdie
2014-04-09 7:49 ` Chong Lu
2014-04-09 9:28 ` Richard Purdie
2014-04-09 9:36 ` Chong Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox