[PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Robert P. J. Day]

Given that there are no machine-specific files for the tslib recipe
anymore, might as well remove this line.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  still not totally sure i know what i'm doing here, but git history
shows that any machine-specific tslib files vanished long ago, so
there's little reason to hang onto this. i'm willing to be corrected.

diff --git a/meta/recipes-graphics/tslib/tslib_1.1.bb b/meta/recipes-graphics/tslib/tslib_1.1.bb
index 05d58b6..6d8c7dd 100644
--- a/meta/recipes-graphics/tslib/tslib_1.1.bb
+++ b/meta/recipes-graphics/tslib/tslib_1.1.bb
@@ -32,8 +32,6 @@ do_install_append() {
 	install -m 0755 ${WORKDIR}/tslib.sh ${D}${sysconfdir}/profile.d/
 }

-SRC_URI_OVERRIDES_PACKAGE_ARCH = "0"
-
 # People should consider using udev's /dev/input/touchscreen0 symlink
 # instead of detect-stylus
 #RDEPENDS_tslib-conf_weird-machine = "detect-stylus"

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Saul Wold]

On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
>
> Given that there are no machine-specific files for the tslib recipe
> anymore, might as well remove this line.
>

Robert,

Can you please review the commit guidelines

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

The summary line should be in the form of
tslib: Remove ...

I know it's a trivial patch, but it would good to have the commit 
message correct.

Thanks
Sau!

> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
>    still not totally sure i know what i'm doing here, but git history
> shows that any machine-specific tslib files vanished long ago, so
> there's little reason to hang onto this. i'm willing to be corrected.
>
> diff --git a/meta/recipes-graphics/tslib/tslib_1.1.bb b/meta/recipes-graphics/tslib/tslib_1.1.bb
> index 05d58b6..6d8c7dd 100644
> --- a/meta/recipes-graphics/tslib/tslib_1.1.bb
> +++ b/meta/recipes-graphics/tslib/tslib_1.1.bb
> @@ -32,8 +32,6 @@ do_install_append() {
>   	install -m 0755 ${WORKDIR}/tslib.sh ${D}${sysconfdir}/profile.d/
>   }
>
> -SRC_URI_OVERRIDES_PACKAGE_ARCH = "0"
> -
>   # People should consider using udev's /dev/input/touchscreen0 symlink
>   # instead of detect-stylus
>   #RDEPENDS_tslib-conf_weird-machine = "detect-stylus"
>

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Robert P. J. Day]

On Fri, 8 Aug 2014, Saul Wold wrote:

> On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
> >
> > Given that there are no machine-specific files for the tslib recipe
> > anymore, might as well remove this line.
> >
>
> Robert,
>
> Can you please review the commit guidelines
>
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>
> The summary line should be in the form of
> tslib: Remove ...
>
> I know it's a trivial patch, but it would good to have the commit message
> correct.

  quite so, i'll resubmit properly.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Robert P. J. Day]

On Fri, 8 Aug 2014, Saul Wold wrote:

> On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
> >
> > Given that there are no machine-specific files for the tslib recipe
> > anymore, might as well remove this line.
> >
>
> Robert,
>
> Can you please review the commit guidelines
>
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>
> The summary line should be in the form of
> tslib: Remove ...

  serious question -- how does one identify the "primary item" under
consideration if it's scattered over several files. recently, i
submitted a patch to remove a few references to "do_package_write",
a deleted task. the existing references under meta/:

conf/documentation.conf:do_package_write[doc] = "Creates the actual packages and places them in the Package Feed area"
recipes-core/meta/meta-ide-support.bb:do_populate_ide_support[recrdeptask] = "do_package_write"
recipes-core/meta/package-index.bb:do_package_write[noexec] = "1"
recipes-devtools/installer/adt-installer_1.0.bb:do_package_write[noexec] = "1"

  i'm assuming, in this case, the primary item would be
"do_package_write"?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Paul Eggleton]

On Saturday 09 August 2014 09:17:16 Robert P. J. Day wrote:
> On Fri, 8 Aug 2014, Saul Wold wrote:
> > On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
> > > Given that there are no machine-specific files for the tslib recipe
> > > anymore, might as well remove this line.
> > 
> > Robert,
> > 
> > Can you please review the commit guidelines
> > 
> > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> > 
> > The summary line should be in the form of
> > tslib: Remove ...
> 
>   serious question -- how does one identify the "primary item" under
> consideration if it's scattered over several files. recently, i
> submitted a patch to remove a few references to "do_package_write",
> a deleted task. the existing references under meta/:
> 
> conf/documentation.conf:do_package_write[doc] = "Creates the actual packages
> and places them in the Package Feed area"
> recipes-core/meta/meta-ide-support.bb:do_populate_ide_support[recrdeptask]
> = "do_package_write"
> recipes-core/meta/package-index.bb:do_package_write[noexec] = "1"
> recipes-devtools/installer/adt-installer_1.0.bb:do_package_write[noexec] =
> "1"
> 
>   i'm assuming, in this case, the primary item would be
> "do_package_write"?

When you're making a blanket change like this it's OK to not have a "primary 
item". Most of the time though you end up changing just one recipe or class at 
a time, and then you should specify it.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Robert P. J. Day]

On Sun, 10 Aug 2014, Paul Eggleton wrote:

> On Saturday 09 August 2014 09:17:16 Robert P. J. Day wrote:

... snip regarding changes that encompass multiple files ...

> When you're making a blanket change like this it's OK to not have a
> "primary item". Most of the time though you end up changing just one
> recipe or class at a time, and then you should specify it.

  ok, i'll submit this patch shortly. and just FYI, i do understand
that a lot of these patches are eye-rollingly trivial bordering on
aesthetic, but a lot of them are in aid of my courses, wherein i like
to work through OE source files with students and, every so often, i
run across oddities that someone asks about and i have to admit i have
no clue what something represents because i've never seen it before
and it's not documented anywhere. so i do enjoy making stuff like that
go away so i never need to explain it. :-)

  patch coming soon ...

rday

p.s. and with the removal of the thing in the subject line, i am
unaware of a single use of that variable in all of the layers i
normally work with. just an observation.

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [PATCH] Remove "SRC_URI_OVERRIDES_PACKAGE_ARCH = 0" from tslib.bb

[Saul Wold]

On 08/09/2014 06:17 AM, Robert P. J. Day wrote:
> On Fri, 8 Aug 2014, Saul Wold wrote:
>
>> On 08/08/2014 12:31 PM, Robert P. J. Day wrote:
>>>
>>> Given that there are no machine-specific files for the tslib recipe
>>> anymore, might as well remove this line.
>>>
>>
>> Robert,
>>
>> Can you please review the commit guidelines
>>
>> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>>
>> The summary line should be in the form of
>> tslib: Remove ...
>
>    serious question -- how does one identify the "primary item" under
> consideration if it's scattered over several files. recently, i
> submitted a patch to remove a few references to "do_package_write",
> a deleted task. the existing references under meta/:
>
Great question actually and maybe this needs clarification in the Wiki.

Ideally if it's an atomic change around a "primary idea" than that's the 
focus. Sometimes with refactorings we do bulk and sometime it's 
individual, depends on if the small changes will cause bisect failures.

> conf/documentation.conf:do_package_write[doc] = "Creates the actual packages and places them in the Package Feed area"
> recipes-core/meta/meta-ide-support.bb:do_populate_ide_support[recrdeptask] = "do_package_write"
> recipes-core/meta/package-index.bb:do_package_write[noexec] = "1"
> recipes-devtools/installer/adt-installer_1.0.bb:do_package_write[noexec] = "1"
>
>    i'm assuming, in this case, the primary item would be
> "do_package_write"?
>
Yes, that would be the primary idea in this case.

Sau!

> rday
>