Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Yang Shi <yang.shi@windriver.com>
To: Bruce Ashfield <bruce.ashfield@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel: Prevent from installing so files into source dir
Date: Tue, 19 Aug 2014 11:36:20 -0700	[thread overview]
Message-ID: <53F39924.3030802@windriver.com> (raw)
In-Reply-To: <53F396B9.3050608@windriver.com>

On 8/19/2014 11:26 AM, Bruce Ashfield wrote:
> On 14-08-19 02:13 PM, Yang Shi wrote:
>> vdso build could generate so files, avoid installing such so files 
>> into kernel
>> source dir.
>
> Looks good. I never did hit this myself, but this will cover my .so.dbg
> case, and the non debug variant.
>
> That being said, you mentioned that we get a QA error on the .so file
> (about it being stripped) .. that would be useful to have captured in
> this commit log.

OK, V2 is going to be sent soon with the error message captured in the 
commit log.

Thanks,
Yang

>
> Bruce
>
>>
>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 819c302..435b6f0 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>       # dir. This ensures the original Makefiles are used and not the
>>       # redirecting Makefiles in the build directory.
>>       #
>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not 
>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path 
>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>       cp .config $kerneldir
>>       if [ "${S}" != "${B}" ]; then
>>           pwd="$PWD"
>>
>
>
>



      reply	other threads:[~2014-08-19 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 18:13 [PATCH] kernel: Prevent from installing so files into source dir Yang Shi
2014-08-19 18:26 ` Bruce Ashfield
2014-08-19 18:36   ` Yang Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F39924.3030802@windriver.com \
    --to=yang.shi@windriver.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox