[PATCH] kernel: Prevent from installing so files into source dir

[PATCH] kernel: Prevent from installing so files into source dir

[Yang Shi]

vdso build could generate so files, avoid installing such so files into kernel
source dir.

Signed-off-by: Yang Shi <yang.shi@windriver.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 819c302..435b6f0 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -253,7 +253,7 @@ kernel_do_install() {
 	# dir. This ensures the original Makefiles are used and not the
 	# redirecting Makefiles in the build directory.
 	#
-	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
+	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
 	cp .config $kerneldir
 	if [ "${S}" != "${B}" ]; then
 		pwd="$PWD"
-- 
2.0.2

Re: [PATCH] kernel: Prevent from installing so files into source dir

[Bruce Ashfield]

On 14-08-19 02:13 PM, Yang Shi wrote:
> vdso build could generate so files, avoid installing such so files into kernel
> source dir.

Looks good. I never did hit this myself, but this will cover my .so.dbg
case, and the non debug variant.

That being said, you mentioned that we get a QA error on the .so file
(about it being stripped) .. that would be useful to have captured in
this commit log.

Bruce

>
> Signed-off-by: Yang Shi <yang.shi@windriver.com>
> ---
>   meta/classes/kernel.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 819c302..435b6f0 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -253,7 +253,7 @@ kernel_do_install() {
>   	# dir. This ensures the original Makefiles are used and not the
>   	# redirecting Makefiles in the build directory.
>   	#
> -	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
> +	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>   	cp .config $kerneldir
>   	if [ "${S}" != "${B}" ]; then
>   		pwd="$PWD"
>

Re: [PATCH] kernel: Prevent from installing so files into source dir

[Yang Shi]

On 8/19/2014 11:26 AM, Bruce Ashfield wrote:
> On 14-08-19 02:13 PM, Yang Shi wrote:
>> vdso build could generate so files, avoid installing such so files 
>> into kernel
>> source dir.
>
> Looks good. I never did hit this myself, but this will cover my .so.dbg
> case, and the non debug variant.
>
> That being said, you mentioned that we get a QA error on the .so file
> (about it being stripped) .. that would be useful to have captured in
> this commit log.

OK, V2 is going to be sent soon with the error message captured in the 
commit log.

Thanks,
Yang

>
> Bruce
>
>>
>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 819c302..435b6f0 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>       # dir. This ensures the original Makefiles are used and not the
>>       # redirecting Makefiles in the build directory.
>>       #
>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not 
>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name 
>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path 
>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>       cp .config $kerneldir
>>       if [ "${S}" != "${B}" ]; then
>>           pwd="$PWD"
>>
>
>
>