Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] license_class: Add explicity avoid of CLOSED license in validations
Date: Mon, 18 May 2015 14:18:13 -0500	[thread overview]
Message-ID: <555A3AF5.7000807@linux.intel.com> (raw)
In-Reply-To: <1431976573-15545-1-git-send-email-anibal.limon@linux.intel.com>

Sorry i forget to put [FIDO] suffix.

Regards,
     alimon

On 18/05/15 14:16, Aníbal Limón wrote:
> The CLOSED license isn't a generic license it is a set and can
> be any closed source license.
>
> [YOCTO #7752]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>   meta/classes/license.bbclass | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 73a0e97..fdc1170 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -71,6 +71,11 @@ license_create_manifest() {
>   
>   		lics="$(echo ${pkged_lic} | sed "s/[|&()*]/ /g" | sed "s/  */ /g" )"
>   		for lic in ${lics}; do
> +			# add explicity avoid of CLOSED license because isn't generic
> +			if [ "$lic" = "CLOSED" ]; then
> +				continue
> +			fi
> +
>   			# to reference a license file trim trailing + symbol
>   			if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic%+}" ]; then
>   				bbwarn "The license listed ${lic} was not in the licenses collected for ${pkged_pn}"
> @@ -242,8 +247,10 @@ def find_license_files(d):
>   
>               lic_files_paths.append(("generic_" + license_type, os.path.join(license_source, spdx_generic)))
>           else:
> -            # And here is where we warn people that their licenses are lousy
> -            bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> +            # Add explicity avoid of CLOSED license because this isn't generic
> +            if license_type != 'CLOSED':
> +                # And here is where we warn people that their licenses are lousy
> +                bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
>               pass
>   
>       if not generic_directory:



  reply	other threads:[~2015-05-18 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 19:16 [PATCH] license_class: Add explicity avoid of CLOSED license in validations Aníbal Limón
2015-05-18 19:18 ` Aníbal Limón [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-18 20:33 Aníbal Limón
2015-05-22 10:51 ` Steffen Sledz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555A3AF5.7000807@linux.intel.com \
    --to=anibal.limon@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox