Re: [PATCH] license_class: Add explicity avoid of CLOSED license in validations

[Steffen Sledz <sledz@dresearch-fe.de>]

On 18.05.2015 22:33, Aníbal Limón wrote:
> The CLOSED license isn't a generic license it is a set and can
> be any closed source license.
> 
> [YOCTO #7752]
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  meta/classes/license.bbclass | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 7972c79..756e7f0 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -80,6 +80,10 @@ python license_create_manifest() {
>                  lic_file = os.path.join(d.getVar('LICENSE_DIRECTORY', True),
>                                          pkg_dic[pkg]["PN"], "generic_%s" % 
>                                          re.sub('\+', '', lic))
> +                # add explicity avoid of CLOSED license because isn't generic
> +                if lic == "CLOSED":
> +                   continue
> +
>                  if not os.path.exists(lic_file):
>                     bb.warn("The license listed %s was not in the "\ 
>                              "licenses collected for recipe %s" 
> @@ -278,8 +282,10 @@ def find_license_files(d):
>                      lic_files_paths.append(("generic_" + license_type, path))
>                      break
>          else:
> -            # And here is where we warn people that their licenses are lousy
> -            bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> +            # Add explicity avoid of CLOSED license because this isn't generic
> +            if license_type != 'CLOSED':
> +                # And here is where we warn people that their licenses are lousy
> +                bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
>              pass
>  
>      if not generic_directory:

ACK

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058