* [PATCH] license_class: Add explicity avoid of CLOSED license in validations
@ 2015-05-18 20:33 Aníbal Limón
2015-05-22 10:51 ` Steffen Sledz
0 siblings, 1 reply; 4+ messages in thread
From: Aníbal Limón @ 2015-05-18 20:33 UTC (permalink / raw)
To: openembedded-core
The CLOSED license isn't a generic license it is a set and can
be any closed source license.
[YOCTO #7752]
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
meta/classes/license.bbclass | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index 7972c79..756e7f0 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -80,6 +80,10 @@ python license_create_manifest() {
lic_file = os.path.join(d.getVar('LICENSE_DIRECTORY', True),
pkg_dic[pkg]["PN"], "generic_%s" %
re.sub('\+', '', lic))
+ # add explicity avoid of CLOSED license because isn't generic
+ if lic == "CLOSED":
+ continue
+
if not os.path.exists(lic_file):
bb.warn("The license listed %s was not in the "\
"licenses collected for recipe %s"
@@ -278,8 +282,10 @@ def find_license_files(d):
lic_files_paths.append(("generic_" + license_type, path))
break
else:
- # And here is where we warn people that their licenses are lousy
- bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
+ # Add explicity avoid of CLOSED license because this isn't generic
+ if license_type != 'CLOSED':
+ # And here is where we warn people that their licenses are lousy
+ bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
pass
if not generic_directory:
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] license_class: Add explicity avoid of CLOSED license in validations
2015-05-18 20:33 [PATCH] license_class: Add explicity avoid of CLOSED license in validations Aníbal Limón
@ 2015-05-22 10:51 ` Steffen Sledz
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Sledz @ 2015-05-22 10:51 UTC (permalink / raw)
To: Aníbal Limón, openembedded-core
On 18.05.2015 22:33, Aníbal Limón wrote:
> The CLOSED license isn't a generic license it is a set and can
> be any closed source license.
>
> [YOCTO #7752]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/classes/license.bbclass | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 7972c79..756e7f0 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -80,6 +80,10 @@ python license_create_manifest() {
> lic_file = os.path.join(d.getVar('LICENSE_DIRECTORY', True),
> pkg_dic[pkg]["PN"], "generic_%s" %
> re.sub('\+', '', lic))
> + # add explicity avoid of CLOSED license because isn't generic
> + if lic == "CLOSED":
> + continue
> +
> if not os.path.exists(lic_file):
> bb.warn("The license listed %s was not in the "\
> "licenses collected for recipe %s"
> @@ -278,8 +282,10 @@ def find_license_files(d):
> lic_files_paths.append(("generic_" + license_type, path))
> break
> else:
> - # And here is where we warn people that their licenses are lousy
> - bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> + # Add explicity avoid of CLOSED license because this isn't generic
> + if license_type != 'CLOSED':
> + # And here is where we warn people that their licenses are lousy
> + bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> pass
>
> if not generic_directory:
ACK
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] license_class: Add explicity avoid of CLOSED license in validations
@ 2015-05-18 19:16 Aníbal Limón
2015-05-18 19:18 ` Aníbal Limón
0 siblings, 1 reply; 4+ messages in thread
From: Aníbal Limón @ 2015-05-18 19:16 UTC (permalink / raw)
To: openembedded-core
The CLOSED license isn't a generic license it is a set and can
be any closed source license.
[YOCTO #7752]
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
meta/classes/license.bbclass | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index 73a0e97..fdc1170 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -71,6 +71,11 @@ license_create_manifest() {
lics="$(echo ${pkged_lic} | sed "s/[|&()*]/ /g" | sed "s/ */ /g" )"
for lic in ${lics}; do
+ # add explicity avoid of CLOSED license because isn't generic
+ if [ "$lic" = "CLOSED" ]; then
+ continue
+ fi
+
# to reference a license file trim trailing + symbol
if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic%+}" ]; then
bbwarn "The license listed ${lic} was not in the licenses collected for ${pkged_pn}"
@@ -242,8 +247,10 @@ def find_license_files(d):
lic_files_paths.append(("generic_" + license_type, os.path.join(license_source, spdx_generic)))
else:
- # And here is where we warn people that their licenses are lousy
- bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
+ # Add explicity avoid of CLOSED license because this isn't generic
+ if license_type != 'CLOSED':
+ # And here is where we warn people that their licenses are lousy
+ bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
pass
if not generic_directory:
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] license_class: Add explicity avoid of CLOSED license in validations
2015-05-18 19:16 Aníbal Limón
@ 2015-05-18 19:18 ` Aníbal Limón
0 siblings, 0 replies; 4+ messages in thread
From: Aníbal Limón @ 2015-05-18 19:18 UTC (permalink / raw)
To: openembedded-core
Sorry i forget to put [FIDO] suffix.
Regards,
alimon
On 18/05/15 14:16, Aníbal Limón wrote:
> The CLOSED license isn't a generic license it is a set and can
> be any closed source license.
>
> [YOCTO #7752]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/classes/license.bbclass | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 73a0e97..fdc1170 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -71,6 +71,11 @@ license_create_manifest() {
>
> lics="$(echo ${pkged_lic} | sed "s/[|&()*]/ /g" | sed "s/ */ /g" )"
> for lic in ${lics}; do
> + # add explicity avoid of CLOSED license because isn't generic
> + if [ "$lic" = "CLOSED" ]; then
> + continue
> + fi
> +
> # to reference a license file trim trailing + symbol
> if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic%+}" ]; then
> bbwarn "The license listed ${lic} was not in the licenses collected for ${pkged_pn}"
> @@ -242,8 +247,10 @@ def find_license_files(d):
>
> lic_files_paths.append(("generic_" + license_type, os.path.join(license_source, spdx_generic)))
> else:
> - # And here is where we warn people that their licenses are lousy
> - bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> + # Add explicity avoid of CLOSED license because this isn't generic
> + if license_type != 'CLOSED':
> + # And here is where we warn people that their licenses are lousy
> + bb.warn("%s: No generic license file exists for: %s in any provider" % (pn, license_type))
> pass
>
> if not generic_directory:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-22 10:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 20:33 [PATCH] license_class: Add explicity avoid of CLOSED license in validations Aníbal Limón
2015-05-22 10:51 ` Steffen Sledz
-- strict thread matches above, loose matches on Subject: below --
2015-05-18 19:16 Aníbal Limón
2015-05-18 19:18 ` Aníbal Limón
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox