[PATCH 0/1] buildstats-summary: add eventmask

[PATCH 0/1] buildstats-summary: add eventmask

[Chen Qi]

The following changes since commit 7ffe10df73cc20d10fcd41b121074445273bd60e:

  license_class: license_create_manifest improvment (2015-05-09 22:26:02 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib ChenQi/buildstats-summary
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/buildstats-summary

Chen Qi (1):
  buildstats-summary: add eventmask

 meta/classes/buildstats-summary.bbclass | 1 +
 1 file changed, 1 insertion(+)

-- 
1.9.1

[PATCH 1/1] buildstats-summary: add eventmask

[Chen Qi]

Add eventmask for buildstats_summary handler.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/classes/buildstats-summary.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/buildstats-summary.bbclass b/meta/classes/buildstats-summary.bbclass
index c8fbb2f..7bd528e 100644
--- a/meta/classes/buildstats-summary.bbclass
+++ b/meta/classes/buildstats-summary.bbclass
@@ -37,3 +37,4 @@ python buildstats_summary () {
             bb.note("  {0}: {1}% sstate reuse ({2} setscene, {3} scratch)".format(t, 100*len(sstate)/(len(sstate)+len(no_sstate)), len(sstate), len(no_sstate)))
 }
 addhandler buildstats_summary
+buildstats_summary[eventmask] = "bb.event.BuildCompleted"
-- 
1.9.1

Re: [PATCH 1/1] buildstats-summary: add eventmask

[Richard Purdie]

On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
> Add eventmask for buildstats_summary handler.

Why?

This says what you've done but not why we need this...

Cheers,

Richard

Re: [PATCH 1/1] buildstats-summary: add eventmask

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Tue, May 19, 2015 at 3:47 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
> > Add eventmask for buildstats_summary handler.
>
> Why?
>
> This says what you've done but not why we need this...
>
> Cheers,
>
> Richard


Also, this adds the eventmask, but doesn’t remove the then-redundant
isinstance() on the event object.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 969 bytes --]

Re: [PATCH 1/1] buildstats-summary: add eventmask

[ChenQi]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On 05/19/2015 09:40 PM, Christopher Larson wrote:
>
> On Tue, May 19, 2015 at 3:47 AM, Richard Purdie 
> <richard.purdie@linuxfoundation.org 
> <mailto:richard.purdie@linuxfoundation.org>> wrote:
>
>     On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
>     > Add eventmask for buildstats_summary handler.
>
>     Why?
>
>     This says what you've done but not why we need this...
>
>     Cheers,
>
>     Richard
>
>
> Also, this adds the eventmask, but doesn’t remove the then-redundant 
> isinstance() on the event object.

Hi Richard and Christopher,

Thanks for you advice.
I'll send out V2.

Regards,
Chen Qi

> -- 
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics


[-- Attachment #2: Type: text/html, Size: 2303 bytes --]