* [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
@ 2015-05-13 0:14 rongqing.li
2015-05-21 0:43 ` Rongqing Li
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: rongqing.li @ 2015-05-13 0:14 UTC (permalink / raw)
To: openembedded-core
From: Roy Li <rongqing.li@windriver.com>
AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead
to building failure when DEBUG_BUILD is 1.
So Redefine AM_CFLAGS, input it from the environment to overrides
variable in makefile
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/mmc/mmc-utils_git.bb b/meta/recipes-devtools/mmc/mmc-utils_git.bb
index bdb4fed..d6d77d9 100644
--- a/meta/recipes-devtools/mmc/mmc-utils_git.bb
+++ b/meta/recipes-devtools/mmc/mmc-utils_git.bb
@@ -11,6 +11,8 @@ PV = "0.1"
SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${BRANCH} \
file://0001-mmc.h-don-t-include-asm-generic-int-ll64.h.patch"
+EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
+
S = "${WORKDIR}/git"
do_install() {
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-05-13 0:14 [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1 rongqing.li
@ 2015-05-21 0:43 ` Rongqing Li
2015-05-26 1:02 ` Rongqing Li
2015-06-01 1:37 ` Rongqing Li
2 siblings, 0 replies; 7+ messages in thread
From: Rongqing Li @ 2015-05-21 0:43 UTC (permalink / raw)
To: openembedded-core
ping
-Roy
On 2015年05月13日 08:14, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead
> to building failure when DEBUG_BUILD is 1.
> So Redefine AM_CFLAGS, input it from the environment to overrides
> variable in makefile
>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/mmc/mmc-utils_git.bb b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> index bdb4fed..d6d77d9 100644
> --- a/meta/recipes-devtools/mmc/mmc-utils_git.bb
> +++ b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> @@ -11,6 +11,8 @@ PV = "0.1"
> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${BRANCH} \
> file://0001-mmc.h-don-t-include-asm-generic-int-ll64.h.patch"
>
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
> +
> S = "${WORKDIR}/git"
>
> do_install() {
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-05-13 0:14 [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1 rongqing.li
2015-05-21 0:43 ` Rongqing Li
@ 2015-05-26 1:02 ` Rongqing Li
2015-06-01 1:37 ` Rongqing Li
2 siblings, 0 replies; 7+ messages in thread
From: Rongqing Li @ 2015-05-26 1:02 UTC (permalink / raw)
To: openembedded-core
ping
-Roy
On 2015年05月13日 08:14, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead
> to building failure when DEBUG_BUILD is 1.
> So Redefine AM_CFLAGS, input it from the environment to overrides
> variable in makefile
>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/mmc/mmc-utils_git.bb b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> index bdb4fed..d6d77d9 100644
> --- a/meta/recipes-devtools/mmc/mmc-utils_git.bb
> +++ b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> @@ -11,6 +11,8 @@ PV = "0.1"
> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${BRANCH} \
> file://0001-mmc.h-don-t-include-asm-generic-int-ll64.h.patch"
>
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
> +
> S = "${WORKDIR}/git"
>
> do_install() {
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-05-13 0:14 [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1 rongqing.li
2015-05-21 0:43 ` Rongqing Li
2015-05-26 1:02 ` Rongqing Li
@ 2015-06-01 1:37 ` Rongqing Li
2015-06-02 10:38 ` Burton, Ross
2 siblings, 1 reply; 7+ messages in thread
From: Rongqing Li @ 2015-06-01 1:37 UTC (permalink / raw)
To: openembedded-core
ping
-Roy
On 2015年05月13日 08:14, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> AM_CFLAGS in Makefile includes -D_FORTIFY_SOURCE=2 which will lead
> to building failure when DEBUG_BUILD is 1.
> So Redefine AM_CFLAGS, input it from the environment to overrides
> variable in makefile
>
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/mmc/mmc-utils_git.bb b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> index bdb4fed..d6d77d9 100644
> --- a/meta/recipes-devtools/mmc/mmc-utils_git.bb
> +++ b/meta/recipes-devtools/mmc/mmc-utils_git.bb
> @@ -11,6 +11,8 @@ PV = "0.1"
> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${BRANCH} \
> file://0001-mmc.h-don-t-include-asm-generic-int-ll64.h.patch"
>
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
> +
> S = "${WORKDIR}/git"
>
> do_install() {
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-06-01 1:37 ` Rongqing Li
@ 2015-06-02 10:38 ` Burton, Ross
2015-06-03 0:51 ` Rongqing Li
0 siblings, 1 reply; 7+ messages in thread
From: Burton, Ross @ 2015-06-02 10:38 UTC (permalink / raw)
To: Rongqing Li; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On 1 June 2015 at 02:37, Rongqing Li <rongqing.li@windriver.com> wrote:
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
>>
>
This seems fragile as you're relying on future maintainers checking that
upstream don't change the value of AM_CFLAGS. Would passing
-U_FORTIFY_SOURCE via CPPFLAGS solve the problem in a neater way?
Ross
[-- Attachment #2: Type: text/html, Size: 842 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-06-02 10:38 ` Burton, Ross
@ 2015-06-03 0:51 ` Rongqing Li
2015-06-03 0:57 ` Rongqing Li
0 siblings, 1 reply; 7+ messages in thread
From: Rongqing Li @ 2015-06-03 0:51 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2015年06月02日 18:38, Burton, Ross wrote:
>
> On 1 June 2015 at 02:37, Rongqing Li <rongqing.li@windriver.com
> <mailto:rongqing.li@windriver.com>> wrote:
>
> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
>
>
> This seems fragile as you're relying on future maintainers checking that
> upstream don't change the value of AM_CFLAGS. Would passing
> -U_FORTIFY_SOURCE via CPPFLAGS solve the problem in a neater way?
>
> Ross
what should I do? make a patch which remove _FORTIFY_SOURCE from
AM_CFLAGS in
Makefile?
-Roy
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1
2015-06-03 0:51 ` Rongqing Li
@ 2015-06-03 0:57 ` Rongqing Li
0 siblings, 0 replies; 7+ messages in thread
From: Rongqing Li @ 2015-06-03 0:57 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2015年06月03日 08:51, Rongqing Li wrote:
>
>
> On 2015年06月02日 18:38, Burton, Ross wrote:
>>
>> On 1 June 2015 at 02:37, Rongqing Li <rongqing.li@windriver.com
>> <mailto:rongqing.li@windriver.com>> wrote:
>>
>> +EXTRA_OEMAKE = 'AM_CFLAGS="-D_FILE_OFFSET_BITS=64"'
>>
>>
>> This seems fragile as you're relying on future maintainers checking that
>> upstream don't change the value of AM_CFLAGS. Would passing
>> -U_FORTIFY_SOURCE via CPPFLAGS solve the problem in a neater way?
>>
>> Ross
>
>
> what should I do? make a patch which remove _FORTIFY_SOURCE from
> AM_CFLAGS in
> Makefile?
>
>
I see what you said
Thanks
-R
> -Roy
>
>
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-03 0:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-13 0:14 [PATCH][V3] mmc-utils: fix the building failure when DEBUG_BUILD is 1 rongqing.li
2015-05-21 0:43 ` Rongqing Li
2015-05-26 1:02 ` Rongqing Li
2015-06-01 1:37 ` Rongqing Li
2015-06-02 10:38 ` Burton, Ross
2015-06-03 0:51 ` Rongqing Li
2015-06-03 0:57 ` Rongqing Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox