[PATCH] image: Fix a build error by adding kernel dependence to do_rootfs

[PATCH] image: Fix a build error by adding kernel dependence to do_rootfs

[Firo Yang]

Issue: LIN7-4290

do_rootfs needs a file named kernel-abiversion generated by
virtual/kernel:do_packagedata to run depmod.

If do_rootfs scheduled before virtual/kernel:do_packagedata that will
make do_roofs failed because of leaking the file kernel-abiversion.
So add the dependence of virtual/kernel:do_packagedata to do_rootfs
will make it happier.

Signed-off-by: Firo Yang <yongming.yang@windriver.com>
---
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index ed12abb..b6128da 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -77,7 +77,7 @@ LDCONFIGDEPEND_libc-uclibc = ""
 LDCONFIGDEPEND_libc-musl = ""
 
 do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
-do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
+do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot virtual/kernel:do_packagedata"
 do_rootfs[recrdeptask] += "do_packagedata"
 
 def command_variables(d):
-- 
1.9.1

Re: [PATCH] image: Fix a build error by adding kernel dependence to do_rootfs

[Paul Eggleton]

Hi Firo,

On Wednesday 29 July 2015 15:48:28 Firo Yang wrote:
> Issue: LIN7-4290
> 
> do_rootfs needs a file named kernel-abiversion generated by
> virtual/kernel:do_packagedata to run depmod.
> 
> If do_rootfs scheduled before virtual/kernel:do_packagedata that will
> make do_roofs failed because of leaking the file kernel-abiversion.
> So add the dependence of virtual/kernel:do_packagedata to do_rootfs
> will make it happier.
> 
> Signed-off-by: Firo Yang <yongming.yang@windriver.com>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index ed12abb..b6128da 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -77,7 +77,7 @@ LDCONFIGDEPEND_libc-uclibc = ""
>  LDCONFIGDEPEND_libc-musl = ""
> 
>  do_rootfs[depends] += "makedevs-native:do_populate_sysroot
> virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
> -do_rootfs[depends] +=
> "virtual/update-alternatives-native:do_populate_sysroot
> update-rc.d-native:do_populate_sysroot" +do_rootfs[depends] +=
> "virtual/update-alternatives-native:do_populate_sysroot
> update-rc.d-native:do_populate_sysroot virtual/kernel:do_packagedata"
> do_rootfs[recrdeptask] += "do_packagedata"
> 
>  def command_variables(d):

This was already fixed some time ago:

  http://cgit.openembedded.org/openembedded-core/commit/?id=41f0f86ec0a3e0b6f6c9bb4ef71a4215c00bf66c

And modified slightly since then:

  http://cgit.openembedded.org/openembedded-core/commit/?id=2e3c8fd70694dcf9553b5e4c50a57b617a9130b6

If you could please ensure future patches you send are against the
master branch, that would be much appreciated.

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] image: Fix a build error by adding kernel dependence to do_rootfs

[Firo Yang]

On 07/29/2015 04:50 PM, Paul Eggleton wrote:
> Hi Firo,
>
> On Wednesday 29 July 2015 15:48:28 Firo Yang wrote:
>> Issue: LIN7-4290
>>
>> do_rootfs needs a file named kernel-abiversion generated by
>> virtual/kernel:do_packagedata to run depmod.
>>
>> If do_rootfs scheduled before virtual/kernel:do_packagedata that will
>> make do_roofs failed because of leaking the file kernel-abiversion.
>> So add the dependence of virtual/kernel:do_packagedata to do_rootfs
>> will make it happier.
>>
>> Signed-off-by: Firo Yang <yongming.yang@windriver.com>
>> ---
>>   meta/classes/image.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index ed12abb..b6128da 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -77,7 +77,7 @@ LDCONFIGDEPEND_libc-uclibc = ""
>>   LDCONFIGDEPEND_libc-musl = ""
>>
>>   do_rootfs[depends] += "makedevs-native:do_populate_sysroot
>> virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
>> -do_rootfs[depends] +=
>> "virtual/update-alternatives-native:do_populate_sysroot
>> update-rc.d-native:do_populate_sysroot" +do_rootfs[depends] +=
>> "virtual/update-alternatives-native:do_populate_sysroot
>> update-rc.d-native:do_populate_sysroot virtual/kernel:do_packagedata"
>> do_rootfs[recrdeptask] += "do_packagedata"
>>
>>   def command_variables(d):
> This was already fixed some time ago:
>
>    http://cgit.openembedded.org/openembedded-core/commit/?id=41f0f86ec0a3e0b6f6c9bb4ef71a4215c00bf66c
>
> And modified slightly since then:
>
>    http://cgit.openembedded.org/openembedded-core/commit/?id=2e3c8fd70694dcf9553b5e4c50a57b617a9130b6
>
> If you could please ensure future patches you send are against the
> master branch, that would be much appreciated.
Hi Paul

Thanks for your kind reply.
I will do more check before sending patches next time.

Best,
Firo
>
> Thanks,
> Paul
>